-
Notifications
You must be signed in to change notification settings - Fork 322
Add marks to exclude ranges from vulnerability reporting #5538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/propagation/StringModuleTest.groovy
Show resolved
Hide resolved
31fef31 to
5967f11
Compare
487478c to
b4ccc06
Compare
b4ccc06 to
24c5494
Compare
dd-java-agent/agent-iast/src/main/java/com/datadog/iast/model/VulnerabilityMarks.java
Show resolved
Hide resolved
dd-java-agent/agent-iast/src/main/java/com/datadog/iast/model/VulnerabilityType.java
Show resolved
Hide resolved
dd-java-agent/agent-iast/src/main/java/com/datadog/iast/propagation/StringModuleImpl.java
Outdated
Show resolved
Hide resolved
dd-java-agent/agent-iast/src/main/java/com/datadog/iast/taint/Ranges.java
Outdated
Show resolved
Hide resolved
dd-java-agent/agent-iast/src/main/java/com/datadog/iast/taint/Ranges.java
Outdated
Show resolved
Hide resolved
dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/taint/RangesTest.groovy
Outdated
Show resolved
Hide resolved
smola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. But I think we're missing skipping marked ranges from vulnerability reports. If there is one secure range and one non-secure, the secure one should be omitted. This might change in the future if/when we have a spec on how to send this additional info to the backend.
I'm working on it |
…and only add to the evidence not marked ranges
Done! |
What Does This Do
Motivation
Add an exclusion mark system to avoid reporting vulnerabilities if all its ranges are marked as excluded for that type of vulnerability.
Additional Notes