Skip to content

Comments

Use pool class name to get fixed test names#6655

Merged
PerfectSlayer merged 1 commit intomasterfrom
bbujon/fix-test-names
Feb 12, 2024
Merged

Use pool class name to get fixed test names#6655
PerfectSlayer merged 1 commit intomasterfrom
bbujon/fix-test-names

Conversation

@PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Feb 9, 2024

What Does This Do

Use pool class name rather than relying on Object.toString() to get fixed test names

Motivation

This causes issues with CI visibility.

Additional Notes

Jira ticket: APMJAVA-1241

@PerfectSlayer PerfectSlayer added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Feb 9, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 9, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/fix-test-names
git_commit_date 1707488197 1707488782
git_commit_sha a3eb733 8821f72
release_version 1.31.0-SNAPSHOT~a3eb7336df 1.31.0-SNAPSHOT~8821f727c9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1707491827 1707491827
ci_job_id 430483545 430483545
ci_pipeline_id 28033214 28033214
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 12 unstable metrics.

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-09T14:53:15 2024-02-09T15:12:06
git_branch master bbujon/fix-test-names
git_commit_date 1707488197 1707488782
git_commit_sha a3eb733 8821f72
release_version 1.31.0-SNAPSHOT~a3eb7336df 1.31.0-SNAPSHOT~8821f727c9
start_time 2024-02-09T14:53:01 2024-02-09T15:11:53
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1707491827 1707491827
ci_job_id 430483545 430483545
ci_pipeline_id 28033214 28033214
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~8821f727c9, baseline=1.31.0-SNAPSHOT~a3eb7336df
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.161 µs) : 342, 386
.   : milestone, 364,
iast (475.053 µs) : 454, 496
.   : milestone, 475,
iast_FULL (540.449 µs) : 520, 561
.   : milestone, 540,
iast_GLOBAL (500.372 µs) : 479, 522
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (473.231 µs) : 452, 495
.   : milestone, 473,
iast_INACTIVE (438.834 µs) : 418, 460
.   : milestone, 439,
iast_TELEMETRY_OFF (464.928 µs) : 444, 486
.   : milestone, 465,
tracing (432.993 µs) : 412, 454
.   : milestone, 433,
section candidate
no_agent (366.564 µs) : 346, 387
.   : milestone, 367,
iast (479.17 µs) : 458, 500
.   : milestone, 479,
iast_FULL (532.162 µs) : 512, 553
.   : milestone, 532,
iast_GLOBAL (488.853 µs) : 468, 510
.   : milestone, 489,
iast_HARDCODED_SECRET_DISABLED (465.647 µs) : 445, 486
.   : milestone, 466,
iast_INACTIVE (437.539 µs) : 417, 458
.   : milestone, 438,
iast_TELEMETRY_OFF (460.019 µs) : 440, 480
.   : milestone, 460,
tracing (439.352 µs) : 418, 460
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.161 µs [342.423 µs, 385.898 µs] -
iast 475.053 µs [453.925 µs, 496.18 µs] 110.892 µs (30.5%)
iast_FULL 540.449 µs [519.829 µs, 561.069 µs] 176.289 µs (48.4%)
iast_GLOBAL 500.372 µs [478.918 µs, 521.826 µs] 136.211 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED 473.231 µs [451.561 µs, 494.901 µs] 109.071 µs (30.0%)
iast_INACTIVE 438.834 µs [418.025 µs, 459.642 µs] 74.673 µs (20.5%)
iast_TELEMETRY_OFF 464.928 µs [443.664 µs, 486.193 µs] 100.768 µs (27.7%)
tracing 432.993 µs [412.269 µs, 453.717 µs] 68.832 µs (18.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.564 µs [346.47 µs, 386.657 µs] -
iast 479.17 µs [457.975 µs, 500.364 µs] 112.606 µs (30.7%)
iast_FULL 532.162 µs [511.731 µs, 552.593 µs] 165.598 µs (45.2%)
iast_GLOBAL 488.853 µs [468.19 µs, 509.517 µs] 122.289 µs (33.4%)
iast_HARDCODED_SECRET_DISABLED 465.647 µs [444.971 µs, 486.323 µs] 99.083 µs (27.0%)
iast_INACTIVE 437.539 µs [417.068 µs, 458.01 µs] 70.975 µs (19.4%)
iast_TELEMETRY_OFF 460.019 µs [439.62 µs, 480.417 µs] 93.455 µs (25.5%)
tracing 439.352 µs [418.437 µs, 460.267 µs] 72.788 µs (19.9%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~8821f727c9, baseline=1.31.0-SNAPSHOT~a3eb7336df
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.34 ms) : 1321, 1359
.   : milestone, 1340,
appsec (1.757 ms) : 1732, 1782
.   : milestone, 1757,
iast (1.526 ms) : 1501, 1550
.   : milestone, 1526,
profiling (1.483 ms) : 1457, 1508
.   : milestone, 1483,
tracing (1.505 ms) : 1480, 1530
.   : milestone, 1505,
section candidate
no_agent (1.349 ms) : 1330, 1368
.   : milestone, 1349,
appsec (1.759 ms) : 1733, 1784
.   : milestone, 1759,
iast (1.525 ms) : 1500, 1549
.   : milestone, 1525,
profiling (1.533 ms) : 1507, 1559
.   : milestone, 1533,
tracing (1.515 ms) : 1490, 1539
.   : milestone, 1515,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.321 ms, 1.359 ms] -
appsec 1.757 ms [1.732 ms, 1.782 ms] 417.126 µs (31.1%)
iast 1.526 ms [1.501 ms, 1.55 ms] 186.206 µs (13.9%)
profiling 1.483 ms [1.457 ms, 1.508 ms] 143.114 µs (10.7%)
tracing 1.505 ms [1.48 ms, 1.53 ms] 165.617 µs (12.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.33 ms, 1.368 ms] -
appsec 1.759 ms [1.733 ms, 1.784 ms] 409.379 µs (30.3%)
iast 1.525 ms [1.5 ms, 1.549 ms] 175.388 µs (13.0%)
profiling 1.533 ms [1.507 ms, 1.559 ms] 183.776 µs (13.6%)
tracing 1.515 ms [1.49 ms, 1.539 ms] 165.71 µs (12.3%)

@PerfectSlayer PerfectSlayer marked this pull request as ready for review February 12, 2024 09:25
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner February 12, 2024 09:25
@PerfectSlayer
Copy link
Contributor Author

Is it enough to fix the issue raised during the Java Guild meeting? @smola

@PerfectSlayer PerfectSlayer merged commit 58ffdd2 into master Feb 12, 2024
@PerfectSlayer PerfectSlayer deleted the bbujon/fix-test-names branch February 12, 2024 16:40
@github-actions github-actions bot added this to the 1.30.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants