Use pool class name to get fixed test names#6655
Merged
PerfectSlayer merged 1 commit intomasterfrom Feb 12, 2024
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 12 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~8821f727c9, baseline=1.31.0-SNAPSHOT~a3eb7336df
dateFormat X
axisFormat %s
section baseline
no_agent (364.161 µs) : 342, 386
. : milestone, 364,
iast (475.053 µs) : 454, 496
. : milestone, 475,
iast_FULL (540.449 µs) : 520, 561
. : milestone, 540,
iast_GLOBAL (500.372 µs) : 479, 522
. : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (473.231 µs) : 452, 495
. : milestone, 473,
iast_INACTIVE (438.834 µs) : 418, 460
. : milestone, 439,
iast_TELEMETRY_OFF (464.928 µs) : 444, 486
. : milestone, 465,
tracing (432.993 µs) : 412, 454
. : milestone, 433,
section candidate
no_agent (366.564 µs) : 346, 387
. : milestone, 367,
iast (479.17 µs) : 458, 500
. : milestone, 479,
iast_FULL (532.162 µs) : 512, 553
. : milestone, 532,
iast_GLOBAL (488.853 µs) : 468, 510
. : milestone, 489,
iast_HARDCODED_SECRET_DISABLED (465.647 µs) : 445, 486
. : milestone, 466,
iast_INACTIVE (437.539 µs) : 417, 458
. : milestone, 438,
iast_TELEMETRY_OFF (460.019 µs) : 440, 480
. : milestone, 460,
tracing (439.352 µs) : 418, 460
. : milestone, 439,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~8821f727c9, baseline=1.31.0-SNAPSHOT~a3eb7336df
dateFormat X
axisFormat %s
section baseline
no_agent (1.34 ms) : 1321, 1359
. : milestone, 1340,
appsec (1.757 ms) : 1732, 1782
. : milestone, 1757,
iast (1.526 ms) : 1501, 1550
. : milestone, 1526,
profiling (1.483 ms) : 1457, 1508
. : milestone, 1483,
tracing (1.505 ms) : 1480, 1530
. : milestone, 1505,
section candidate
no_agent (1.349 ms) : 1330, 1368
. : milestone, 1349,
appsec (1.759 ms) : 1733, 1784
. : milestone, 1759,
iast (1.525 ms) : 1500, 1549
. : milestone, 1525,
profiling (1.533 ms) : 1507, 1559
. : milestone, 1533,
tracing (1.515 ms) : 1490, 1539
. : milestone, 1515,
|
Contributor
Author
|
Is it enough to fix the issue raised during the Java Guild meeting? @smola |
dougqh
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Use pool class name rather than relying on
Object.toString()to get fixed test namesMotivation
This causes issues with CI visibility.
Additional Notes
Jira ticket: APMJAVA-1241