Skip to content

Comments

Update CODEOWNERS to include dd-trace-java team#6656

Closed
bm1549 wants to merge 1 commit intomasterfrom
brian.marks/codeowners
Closed

Update CODEOWNERS to include dd-trace-java team#6656
bm1549 wants to merge 1 commit intomasterfrom
brian.marks/codeowners

Conversation

@bm1549
Copy link
Contributor

@bm1549 bm1549 commented Feb 9, 2024

What Does This Do

Updates CODEOWNERS to propose a new owner of shared code - @DataDog/dd-trace-java

Motivation

The goal here is to empower teams to move efficiently while reducing the overhead/rubber-stamping required from the current @DataDog/apm-java team

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Feb 9, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master brian.marks/codeowners
git_commit_date 1707488197 1707490750
git_commit_sha a3eb733 42d9504
release_version 1.31.0-SNAPSHOT~a3eb7336df 1.31.0-SNAPSHOT~42d9504747
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1707493797 1707493797
ci_job_id 430541302 430541302
ci_pipeline_id 28037702 28037702
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.31.0-SNAPSHOT~42d9504747, baseline=1.31.0-SNAPSHOT~a3eb7336df

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062600
Total [baseline] (9.281 s) : 0, 9281212
Agent [candidate] (1.062 s) : 0, 1062234
Total [candidate] (9.329 s) : 0, 9329018
section appsec
Agent [baseline] (1.154 s) : 0, 1154067
Total [baseline] (9.402 s) : 0, 9402024
Agent [candidate] (1.159 s) : 0, 1159195
Total [candidate] (9.438 s) : 0, 9438038
section iast
Agent [baseline] (1.181 s) : 0, 1180726
Total [baseline] (9.666 s) : 0, 9666479
Agent [candidate] (1.183 s) : 0, 1183428
Total [candidate] (9.683 s) : 0, 9682755
section profiling
Agent [baseline] (1.274 s) : 0, 1273790
Total [baseline] (9.541 s) : 0, 9541348
Agent [candidate] (1.287 s) : 0, 1287026
Total [candidate] (9.578 s) : 0, 9578205
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.154 s 91.468 ms (8.6%)
Agent iast 1.181 s 118.126 ms (11.1%)
Agent profiling 1.274 s 211.191 ms (19.9%)
Total tracing 9.281 s -
Total appsec 9.402 s 120.812 ms (1.3%)
Total iast 9.666 s 385.267 ms (4.2%)
Total profiling 9.541 s 260.136 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.159 s 96.96 ms (9.1%)
Agent iast 1.183 s 121.194 ms (11.4%)
Agent profiling 1.287 s 224.792 ms (21.2%)
Total tracing 9.329 s -
Total appsec 9.438 s 109.02 ms (1.2%)
Total iast 9.683 s 353.737 ms (3.8%)
Total profiling 9.578 s 249.187 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.31.0-SNAPSHOT~42d9504747, baseline=1.31.0-SNAPSHOT~a3eb7336df

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.788 ms) : 0, 669788
BytebuddyAgent [candidate] (669.114 ms) : 0, 669114
GlobalTracer [baseline] (298.411 ms) : 0, 298411
GlobalTracer [candidate] (298.655 ms) : 0, 298655
AppSec [baseline] (51.739 ms) : 0, 51739
AppSec [candidate] (51.775 ms) : 0, 51775
Remote Config [baseline] (701.619 µs) : 0, 702
Remote Config [candidate] (683.023 µs) : 0, 683
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.596 ms) : 0, 7596
section appsec
BytebuddyAgent [baseline] (665.851 ms) : 0, 665851
BytebuddyAgent [candidate] (668.342 ms) : 0, 668342
GlobalTracer [baseline] (296.778 ms) : 0, 296778
GlobalTracer [candidate] (298.856 ms) : 0, 298856
AppSec [baseline] (149.756 ms) : 0, 149756
AppSec [candidate] (150.112 ms) : 0, 150112
Remote Config [baseline] (651.163 µs) : 0, 651
Remote Config [candidate] (650.392 µs) : 0, 650
Telemetry [baseline] (6.815 ms) : 0, 6815
Telemetry [candidate] (6.854 ms) : 0, 6854
section iast
BytebuddyAgent [baseline] (776.516 ms) : 0, 776516
BytebuddyAgent [candidate] (778.198 ms) : 0, 778198
GlobalTracer [baseline] (287.531 ms) : 0, 287531
GlobalTracer [candidate] (289.458 ms) : 0, 289458
AppSec [baseline] (53.22 ms) : 0, 53220
AppSec [candidate] (54.519 ms) : 0, 54519
Remote Config [baseline] (619.658 µs) : 0, 620
Remote Config [candidate] (601.864 µs) : 0, 602
Telemetry [baseline] (6.514 ms) : 0, 6514
Telemetry [candidate] (6.618 ms) : 0, 6618
IAST [baseline] (22.138 ms) : 0, 22138
IAST [candidate] (19.741 ms) : 0, 19741
section profiling
ProfilingAgent [baseline] (111.054 ms) : 0, 111054
ProfilingAgent [candidate] (113.157 ms) : 0, 113157
BytebuddyAgent [baseline] (663.572 ms) : 0, 663572
BytebuddyAgent [candidate] (672.529 ms) : 0, 672529
GlobalTracer [baseline] (380.642 ms) : 0, 380642
GlobalTracer [candidate] (383.097 ms) : 0, 383097
AppSec [baseline] (52.051 ms) : 0, 52051
AppSec [candidate] (52.267 ms) : 0, 52267
Remote Config [baseline] (664.277 µs) : 0, 664
Remote Config [candidate] (667.433 µs) : 0, 667
Telemetry [baseline] (11.344 ms) : 0, 11344
Telemetry [candidate] (10.119 ms) : 0, 10119
Profiling [baseline] (111.078 ms) : 0, 111078
Profiling [candidate] (113.182 ms) : 0, 113182
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-09T15:26:04 2024-02-09T15:44:54
git_branch master brian.marks/codeowners
git_commit_date 1707488197 1707490750
git_commit_sha a3eb733 42d9504
release_version 1.31.0-SNAPSHOT~a3eb7336df 1.31.0-SNAPSHOT~42d9504747
start_time 2024-02-09T15:25:51 2024-02-09T15:44:41
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1707493797 1707493797
ci_job_id 430541302 430541302
ci_pipeline_id 28037702 28037702
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~42d9504747, baseline=1.31.0-SNAPSHOT~a3eb7336df
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.748 ms) : 1722, 1773
.   : milestone, 1748,
iast (1.488 ms) : 1463, 1512
.   : milestone, 1488,
profiling (1.521 ms) : 1496, 1546
.   : milestone, 1521,
tracing (1.491 ms) : 1466, 1516
.   : milestone, 1491,
section candidate
no_agent (1.359 ms) : 1340, 1378
.   : milestone, 1359,
appsec (1.76 ms) : 1735, 1785
.   : milestone, 1760,
iast (1.506 ms) : 1480, 1531
.   : milestone, 1506,
profiling (1.502 ms) : 1477, 1526
.   : milestone, 1502,
tracing (1.516 ms) : 1491, 1541
.   : milestone, 1516,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.748 ms [1.722 ms, 1.773 ms] 404.291 µs (30.1%)
iast 1.488 ms [1.463 ms, 1.512 ms] 144.411 µs (10.8%)
profiling 1.521 ms [1.496 ms, 1.546 ms] 178.035 µs (13.3%)
tracing 1.491 ms [1.466 ms, 1.516 ms] 147.974 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.34 ms, 1.378 ms] -
appsec 1.76 ms [1.735 ms, 1.785 ms] 401.244 µs (29.5%)
iast 1.506 ms [1.48 ms, 1.531 ms] 146.698 µs (10.8%)
profiling 1.502 ms [1.477 ms, 1.526 ms] 142.925 µs (10.5%)
tracing 1.516 ms [1.491 ms, 1.541 ms] 157.052 µs (11.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~42d9504747, baseline=1.31.0-SNAPSHOT~a3eb7336df
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.876 µs) : 345, 385
.   : milestone, 365,
iast (468.759 µs) : 448, 490
.   : milestone, 469,
iast_FULL (540.785 µs) : 520, 561
.   : milestone, 541,
iast_GLOBAL (512.391 µs) : 489, 536
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (469.454 µs) : 449, 490
.   : milestone, 469,
iast_INACTIVE (444.319 µs) : 423, 466
.   : milestone, 444,
iast_TELEMETRY_OFF (470.541 µs) : 449, 492
.   : milestone, 471,
tracing (437.974 µs) : 417, 459
.   : milestone, 438,
section candidate
no_agent (367.052 µs) : 347, 388
.   : milestone, 367,
iast (476.65 µs) : 455, 498
.   : milestone, 477,
iast_FULL (521.383 µs) : 501, 542
.   : milestone, 521,
iast_GLOBAL (511.687 µs) : 488, 535
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (469.937 µs) : 449, 490
.   : milestone, 470,
iast_INACTIVE (456.021 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (472.53 µs) : 452, 493
.   : milestone, 473,
tracing (432.315 µs) : 412, 453
.   : milestone, 432,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.876 µs [345.133 µs, 384.618 µs] -
iast 468.759 µs [447.894 µs, 489.625 µs] 103.884 µs (28.5%)
iast_FULL 540.785 µs [520.262 µs, 561.308 µs] 175.909 µs (48.2%)
iast_GLOBAL 512.391 µs [488.838 µs, 535.945 µs] 147.515 µs (40.4%)
iast_HARDCODED_SECRET_DISABLED 469.454 µs [448.859 µs, 490.05 µs] 104.579 µs (28.7%)
iast_INACTIVE 444.319 µs [422.995 µs, 465.644 µs] 79.443 µs (21.8%)
iast_TELEMETRY_OFF 470.541 µs [449.444 µs, 491.638 µs] 105.665 µs (29.0%)
tracing 437.974 µs [417.287 µs, 458.661 µs] 73.098 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.052 µs [346.559 µs, 387.544 µs] -
iast 476.65 µs [455.17 µs, 498.129 µs] 109.598 µs (29.9%)
iast_FULL 521.383 µs [500.933 µs, 541.833 µs] 154.331 µs (42.0%)
iast_GLOBAL 511.687 µs [488.221 µs, 535.154 µs] 144.635 µs (39.4%)
iast_HARDCODED_SECRET_DISABLED 469.937 µs [449.471 µs, 490.403 µs] 102.885 µs (28.0%)
iast_INACTIVE 456.021 µs [435.168 µs, 476.873 µs] 88.969 µs (24.2%)
iast_TELEMETRY_OFF 472.53 µs [451.852 µs, 493.208 µs] 105.478 µs (28.7%)
tracing 432.315 µs [411.77 µs, 452.859 µs] 65.263 µs (17.8%)

@bm1549 bm1549 marked this pull request as ready for review February 9, 2024 19:21
@bm1549 bm1549 requested a review from a team as a code owner February 9, 2024 19:21
@bm1549 bm1549 requested review from a team, PerfectSlayer, am312, bantonsson and ygree and removed request for am312 and ygree February 9, 2024 19:21
PerfectSlayer
PerfectSlayer reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got mixed feelings about this.
I would rather see written the expectations for reviewing such shared before sharing ownership 🤷 (like requirements about config public documentations, design doc about our build, etc...)

smola
smola approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@PerfectSlayer written the expectations

But this is a good idea.

@smola smola added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels May 9, 2024
@bm1549 bm1549 closed this May 14, 2024
@bm1549 bm1549 deleted the brian.marks/codeowners branch January 16, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

@smola smola smola approved these changes

@bantonsson bantonsson Awaiting requested review from bantonsson

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bm1549 @smola @PerfectSlayer