Skip to content

Fix folder permission interaction with Gitlab and gradle#6939

Merged
randomanderson merged 1 commit intomasterfrom
landerson/cache-permissions
Apr 24, 2024
Merged

Fix folder permission interaction with Gitlab and gradle#6939
randomanderson merged 1 commit intomasterfrom
landerson/cache-permissions

Conversation

@randomanderson
Copy link
Copy Markdown
Contributor

@randomanderson randomanderson commented Apr 23, 2024

What Does This Do

#6931 inadvertently broke Gitlab builds because of the interactions between the Gitlab cache and gradle:

  • Gradle always attempts to change permissions of the .gradle folder. See here
  • With Gitlab caching, .gradle is owned by root
  • Gradle's attempt fails and the build fails

This PR adds a workaround by copying moving back the cache folder so that it is owned by the gitlab runner user.

Related Gradle issues:
gradle/gradle#14200
gradle/gradle#8673

@randomanderson
fix permissions for cache
ee14ceb 
print script perms

-a

workaround chmod not working

try sudo

churn

some copy trickery

Use move instead of copy
@randomanderson randomanderson added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Apr 23, 2024
@randomanderson randomanderson requested a review from a team as a code owner April 23, 2024 15:30
@randomanderson randomanderson requested review from dougqh and ygree April 23, 2024 15:30
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 23, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master landerson/cache-permissions
git_commit_date 1713861708 1713885750
git_commit_sha f34dfb5 ee14ceb
release_version 1.34.0-SNAPSHOT~f34dfb52a1 1.34.0-SNAPSHOT~ee14ceb163
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713888426 1713888426
ci_job_id 494448728 494448728
ci_pipeline_id 32709875 32709875
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~ee14ceb163, baseline=1.34.0-SNAPSHOT~f34dfb52a1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080894
Total [baseline] (8.547 s) : 0, 8546870
Agent [candidate] (1.08 s) : 0, 1080270
Total [candidate] (8.575 s) : 0, 8574916
section iast
Agent [baseline] (1.207 s) : 0, 1206944
Total [baseline] (8.992 s) : 0, 8992316
Agent [candidate] (1.207 s) : 0, 1207359
Total [candidate] (9.03 s) : 0, 9030284
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1203825
Total [baseline] (8.959 s) : 0, 8958988
Agent [candidate] (1.208 s) : 0, 1208089
Total [candidate] (8.996 s) : 0, 8995844
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1203112
Total [baseline] (9.005 s) : 0, 9005231
Agent [candidate] (1.194 s) : 0, 1193663
Total [candidate] (8.971 s) : 0, 8970817
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.207 s 126.05 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 122.931 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.203 s 122.218 ms (11.3%)
Total tracing 8.547 s -
Total iast 8.992 s 445.446 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.959 s 412.118 ms (4.8%)
Total iast_TELEMETRY_OFF 9.005 s 458.361 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.207 s 127.089 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 127.819 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.194 s 113.393 ms (10.5%)
Total tracing 8.575 s -
Total iast 9.03 s 455.369 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.996 s 420.928 ms (4.9%)
Total iast_TELEMETRY_OFF 8.971 s 395.902 ms (4.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~ee14ceb163, baseline=1.34.0-SNAPSHOT~f34dfb52a1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (677.494 ms) : 0, 677494
BytebuddyAgent [candidate] (676.837 ms) : 0, 676837
GlobalTracer [baseline] (310.993 ms) : 0, 310993
GlobalTracer [candidate] (311.062 ms) : 0, 311062
AppSec [baseline] (49.729 ms) : 0, 49729
AppSec [candidate] (49.541 ms) : 0, 49541
Remote Config [baseline] (649.906 µs) : 0, 650
Remote Config [candidate] (665.765 µs) : 0, 666
Telemetry [baseline] (7.512 ms) : 0, 7512
Telemetry [candidate] (7.615 ms) : 0, 7615
section iast
BytebuddyAgent [baseline] (799.93 ms) : 0, 799930
BytebuddyAgent [candidate] (800.527 ms) : 0, 800527
GlobalTracer [baseline] (289.657 ms) : 0, 289657
GlobalTracer [candidate] (289.53 ms) : 0, 289530
AppSec [baseline] (52.002 ms) : 0, 52002
AppSec [candidate] (50.332 ms) : 0, 50332
IAST [baseline] (22.616 ms) : 0, 22616
IAST [candidate] (24.269 ms) : 0, 24269
Remote Config [baseline] (575.707 µs) : 0, 576
Remote Config [candidate] (577.862 µs) : 0, 578
Telemetry [baseline] (7.442 ms) : 0, 7442
Telemetry [candidate] (7.452 ms) : 0, 7452
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.36 ms) : 0, 798360
BytebuddyAgent [candidate] (801.463 ms) : 0, 801463
GlobalTracer [baseline] (288.961 ms) : 0, 288961
GlobalTracer [candidate] (290.038 ms) : 0, 290038
AppSec [baseline] (51.098 ms) : 0, 51098
AppSec [candidate] (51.074 ms) : 0, 51074
IAST [baseline] (23.859 ms) : 0, 23859
IAST [candidate] (22.774 ms) : 0, 22774
Remote Config [baseline] (561.529 µs) : 0, 562
Remote Config [candidate] (578.865 µs) : 0, 579
Telemetry [baseline] (6.53 ms) : 0, 6530
Telemetry [candidate] (7.46 ms) : 0, 7460
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.157 ms) : 0, 797157
BytebuddyAgent [candidate] (789.86 ms) : 0, 789860
GlobalTracer [baseline] (289.617 ms) : 0, 289617
GlobalTracer [candidate] (287.669 ms) : 0, 287669
AppSec [baseline] (49.399 ms) : 0, 49399
AppSec [candidate] (47.302 ms) : 0, 47302
IAST [baseline] (24.477 ms) : 0, 24477
IAST [candidate] (25.932 ms) : 0, 25932
Remote Config [baseline] (570.18 µs) : 0, 570
Remote Config [candidate] (576.366 µs) : 0, 576
Telemetry [baseline] (7.285 ms) : 0, 7285
Telemetry [candidate] (7.996 ms) : 0, 7996
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~ee14ceb163, baseline=1.34.0-SNAPSHOT~f34dfb52a1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083320
Total [baseline] (10.433 s) : 0, 10432552
Agent [candidate] (1.09 s) : 0, 1090471
Total [candidate] (10.425 s) : 0, 10424929
section appsec
Agent [baseline] (1.189 s) : 0, 1188906
Total [baseline] (10.436 s) : 0, 10435967
Agent [candidate] (1.196 s) : 0, 1196029
Total [candidate] (10.537 s) : 0, 10536614
section iast
Agent [baseline] (1.198 s) : 0, 1198310
Total [baseline] (10.637 s) : 0, 10636936
Agent [candidate] (1.198 s) : 0, 1198369
Total [candidate] (10.66 s) : 0, 10659546
section profiling
Agent [baseline] (1.282 s) : 0, 1282407
Total [baseline] (10.629 s) : 0, 10628699
Agent [candidate] (1.266 s) : 0, 1266048
Total [candidate] (10.621 s) : 0, 10620592
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.189 s 105.586 ms (9.7%)
Agent iast 1.198 s 114.989 ms (10.6%)
Agent profiling 1.282 s 199.086 ms (18.4%)
Total tracing 10.433 s -
Total appsec 10.436 s 3.415 ms (0.0%)
Total iast 10.637 s 204.384 ms (2.0%)
Total profiling 10.629 s 196.147 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent appsec 1.196 s 105.558 ms (9.7%)
Agent iast 1.198 s 107.897 ms (9.9%)
Agent profiling 1.266 s 175.577 ms (16.1%)
Total tracing 10.425 s -
Total appsec 10.537 s 111.685 ms (1.1%)
Total iast 10.66 s 234.617 ms (2.3%)
Total profiling 10.621 s 195.663 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~ee14ceb163, baseline=1.34.0-SNAPSHOT~f34dfb52a1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.868 ms) : 0, 678868
BytebuddyAgent [candidate] (683.205 ms) : 0, 683205
GlobalTracer [baseline] (311.883 ms) : 0, 311883
GlobalTracer [candidate] (313.821 ms) : 0, 313821
AppSec [baseline] (49.592 ms) : 0, 49592
AppSec [candidate] (50.227 ms) : 0, 50227
Remote Config [baseline] (668.29 µs) : 0, 668
Remote Config [candidate] (665.82 µs) : 0, 666
Telemetry [baseline] (7.632 ms) : 0, 7632
Telemetry [candidate] (7.661 ms) : 0, 7661
section appsec
BytebuddyAgent [baseline] (695.802 ms) : 0, 695802
BytebuddyAgent [candidate] (699.526 ms) : 0, 699526
GlobalTracer [baseline] (290.943 ms) : 0, 290943
GlobalTracer [candidate] (293.1 ms) : 0, 293100
AppSec [baseline] (149.402 ms) : 0, 149402
AppSec [candidate] (149.806 ms) : 0, 149806
IAST [baseline] (19.218 ms) : 0, 19218
IAST [candidate] (19.583 ms) : 0, 19583
Remote Config [baseline] (614.158 µs) : 0, 614
Remote Config [candidate] (623.855 µs) : 0, 624
Telemetry [baseline] (8.196 ms) : 0, 8196
Telemetry [candidate] (8.57 ms) : 0, 8570
section iast
BytebuddyAgent [baseline] (794.027 ms) : 0, 794027
BytebuddyAgent [candidate] (794.226 ms) : 0, 794226
GlobalTracer [baseline] (287.556 ms) : 0, 287556
GlobalTracer [candidate] (287.703 ms) : 0, 287703
AppSec [baseline] (48.75 ms) : 0, 48750
AppSec [candidate] (50.116 ms) : 0, 50116
IAST [baseline] (24.154 ms) : 0, 24154
IAST [candidate] (23.353 ms) : 0, 23353
Remote Config [baseline] (569.563 µs) : 0, 570
Remote Config [candidate] (571.416 µs) : 0, 571
Telemetry [baseline] (8.86 ms) : 0, 8860
Telemetry [candidate] (8.077 ms) : 0, 8077
section profiling
BytebuddyAgent [baseline] (685.613 ms) : 0, 685613
BytebuddyAgent [candidate] (676.893 ms) : 0, 676893
GlobalTracer [baseline] (383.767 ms) : 0, 383767
GlobalTracer [candidate] (379.335 ms) : 0, 379335
AppSec [baseline] (50.771 ms) : 0, 50771
AppSec [candidate] (49.86 ms) : 0, 49860
Remote Config [baseline] (724.736 µs) : 0, 725
Remote Config [candidate] (713.147 µs) : 0, 713
Telemetry [baseline] (7.561 ms) : 0, 7561
Telemetry [candidate] (7.508 ms) : 0, 7508
ProfilingAgent [baseline] (96.982 ms) : 0, 96982
ProfilingAgent [candidate] (95.494 ms) : 0, 95494
Profiling [baseline] (97.006 ms) : 0, 97006
Profiling [candidate] (95.518 ms) : 0, 95518
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-23T15:37:56 2024-04-23T15:44:47
git_branch master landerson/cache-permissions
git_commit_date 1713861708 1713885750
git_commit_sha f34dfb5 ee14ceb
release_version 1.34.0-SNAPSHOT~f34dfb52a1 1.34.0-SNAPSHOT~ee14ceb163
start_time 2024-04-23T15:37:43 2024-04-23T15:44:33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713887433 1713887433
ci_job_id 494448730 494448730
ci_pipeline_id 32709875 32709875
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~ee14ceb163, baseline=1.34.0-SNAPSHOT~f34dfb52a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1374
.   : milestone, 1354,
appsec (1.738 ms) : 1714, 1763
.   : milestone, 1738,
appsec_no_iast (1.716 ms) : 1691, 1741
.   : milestone, 1716,
iast (1.491 ms) : 1469, 1514
.   : milestone, 1491,
profiling (1.512 ms) : 1487, 1536
.   : milestone, 1512,
tracing (1.492 ms) : 1468, 1517
.   : milestone, 1492,
section candidate
no_agent (1.364 ms) : 1345, 1383
.   : milestone, 1364,
appsec (1.718 ms) : 1693, 1742
.   : milestone, 1718,
appsec_no_iast (1.721 ms) : 1697, 1746
.   : milestone, 1721,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.563 ms) : 1538, 1588
.   : milestone, 1563,
tracing (1.482 ms) : 1458, 1506
.   : milestone, 1482,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.334 ms, 1.374 ms] -
appsec 1.738 ms [1.714 ms, 1.763 ms] 384.358 µs (28.4%)
appsec_no_iast 1.716 ms [1.691 ms, 1.741 ms] 362.082 µs (26.7%)
iast 1.491 ms [1.469 ms, 1.514 ms] 137.283 µs (10.1%)
profiling 1.512 ms [1.487 ms, 1.536 ms] 157.55 µs (11.6%)
tracing 1.492 ms [1.468 ms, 1.517 ms] 138.353 µs (10.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.364 ms [1.345 ms, 1.383 ms] -
appsec 1.718 ms [1.693 ms, 1.742 ms] 353.419 µs (25.9%)
appsec_no_iast 1.721 ms [1.697 ms, 1.746 ms] 356.823 µs (26.2%)
iast 1.491 ms [1.468 ms, 1.514 ms] 126.282 µs (9.3%)
profiling 1.563 ms [1.538 ms, 1.588 ms] 198.652 µs (14.6%)
tracing 1.482 ms [1.458 ms, 1.506 ms] 117.425 µs (8.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~ee14ceb163, baseline=1.34.0-SNAPSHOT~f34dfb52a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.909 µs) : 351, 391
.   : milestone, 371,
iast (482.887 µs) : 461, 505
.   : milestone, 483,
iast_FULL (541.814 µs) : 521, 563
.   : milestone, 542,
iast_GLOBAL (506.378 µs) : 484, 529
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (479.794 µs) : 458, 502
.   : milestone, 480,
iast_INACTIVE (451.947 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (487.29 µs) : 465, 509
.   : milestone, 487,
tracing (445.479 µs) : 425, 466
.   : milestone, 445,
section candidate
no_agent (371.805 µs) : 352, 391
.   : milestone, 372,
iast (479.594 µs) : 458, 501
.   : milestone, 480,
iast_FULL (548.585 µs) : 527, 571
.   : milestone, 549,
iast_GLOBAL (504.47 µs) : 482, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (478.437 µs) : 458, 499
.   : milestone, 478,
iast_INACTIVE (457.602 µs) : 437, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (477.388 µs) : 456, 499
.   : milestone, 477,
tracing (449.573 µs) : 429, 470
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.909 µs [350.993 µs, 390.824 µs] -
iast 482.887 µs [460.984 µs, 504.79 µs] 111.978 µs (30.2%)
iast_FULL 541.814 µs [520.586 µs, 563.042 µs] 170.906 µs (46.1%)
iast_GLOBAL 506.378 µs [484.09 µs, 528.666 µs] 135.47 µs (36.5%)
iast_HARDCODED_SECRET_DISABLED 479.794 µs [458.001 µs, 501.587 µs] 108.885 µs (29.4%)
iast_INACTIVE 451.947 µs [431.323 µs, 472.571 µs] 81.039 µs (21.8%)
iast_TELEMETRY_OFF 487.29 µs [465.304 µs, 509.276 µs] 116.381 µs (31.4%)
tracing 445.479 µs [424.895 µs, 466.062 µs] 74.57 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.805 µs [352.462 µs, 391.147 µs] -
iast 479.594 µs [458.407 µs, 500.78 µs] 107.789 µs (29.0%)
iast_FULL 548.585 µs [526.609 µs, 570.562 µs] 176.781 µs (47.5%)
iast_GLOBAL 504.47 µs [482.487 µs, 526.454 µs] 132.665 µs (35.7%)
iast_HARDCODED_SECRET_DISABLED 478.437 µs [457.712 µs, 499.163 µs] 106.632 µs (28.7%)
iast_INACTIVE 457.602 µs [436.608 µs, 478.596 µs] 85.797 µs (23.1%)
iast_TELEMETRY_OFF 477.388 µs [456.215 µs, 498.561 µs] 105.583 µs (28.4%)
tracing 449.573 µs [428.968 µs, 470.178 µs] 77.769 µs (20.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master landerson/cache-permissions
git_commit_date 1713861708 1713885750
git_commit_sha f34dfb5 ee14ceb
release_version 1.34.0-SNAPSHOT~f34dfb52a1 1.34.0-SNAPSHOT~ee14ceb163
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1713887936 1713887936
ci_job_id 494448731 494448731
ci_pipeline_id 32709875 32709875
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~ee14ceb163, baseline=1.34.0-SNAPSHOT~f34dfb52a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.183 ms) : 2149, 2216
.   : milestone, 2183,
iast (1.867 ms) : 1832, 1902
.   : milestone, 1867,
iast_GLOBAL (1.912 ms) : 1876, 1947
.   : milestone, 1912,
profiling (1.844 ms) : 1812, 1877
.   : milestone, 1844,
tracing (1.818 ms) : 1786, 1849
.   : milestone, 1818,
section candidate
no_agent (1.458 ms) : 1447, 1469
.   : milestone, 1458,
appsec (2.169 ms) : 2136, 2202
.   : milestone, 2169,
iast (1.867 ms) : 1833, 1902
.   : milestone, 1867,
iast_GLOBAL (1.902 ms) : 1868, 1937
.   : milestone, 1902,
profiling (1.836 ms) : 1804, 1869
.   : milestone, 1836,
tracing (1.817 ms) : 1785, 1848
.   : milestone, 1817,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.183 ms [2.149 ms, 2.216 ms] 723.123 µs (49.5%)
iast 1.867 ms [1.832 ms, 1.902 ms] 407.66 µs (27.9%)
iast_GLOBAL 1.912 ms [1.876 ms, 1.947 ms] 452.083 µs (31.0%)
profiling 1.844 ms [1.812 ms, 1.877 ms] 384.371 µs (26.3%)
tracing 1.818 ms [1.786 ms, 1.849 ms] 357.992 µs (24.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.469 ms] -
appsec 2.169 ms [2.136 ms, 2.202 ms] 710.751 µs (48.7%)
iast 1.867 ms [1.833 ms, 1.902 ms] 409.264 µs (28.1%)
iast_GLOBAL 1.902 ms [1.868 ms, 1.937 ms] 444.194 µs (30.5%)
profiling 1.836 ms [1.804 ms, 1.869 ms] 378.101 µs (25.9%)
tracing 1.817 ms [1.785 ms, 1.848 ms] 358.589 µs (24.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~ee14ceb163, baseline=1.34.0-SNAPSHOT~f34dfb52a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.175 s) : 15175000, 15175000
.   : milestone, 15175000,
appsec (14.87 s) : 14870000, 14870000
.   : milestone, 14870000,
iast (18.697 s) : 18697000, 18697000
.   : milestone, 18697000,
iast_GLOBAL (17.999 s) : 17999000, 17999000
.   : milestone, 17999000,
profiling (15.083 s) : 15083000, 15083000
.   : milestone, 15083000,
tracing (14.965 s) : 14965000, 14965000
.   : milestone, 14965000,
section candidate
no_agent (15.422 s) : 15422000, 15422000
.   : milestone, 15422000,
appsec (15.222 s) : 15222000, 15222000
.   : milestone, 15222000,
iast (18.742 s) : 18742000, 18742000
.   : milestone, 18742000,
iast_GLOBAL (17.835 s) : 17835000, 17835000
.   : milestone, 17835000,
profiling (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
tracing (15.228 s) : 15228000, 15228000
.   : milestone, 15228000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.175 s [15.175 s, 15.175 s] -
appsec 14.87 s [14.87 s, 14.87 s] -305.0 ms (-2.0%)
iast 18.697 s [18.697 s, 18.697 s] 3.522 s (23.2%)
iast_GLOBAL 17.999 s [17.999 s, 17.999 s] 2.824 s (18.6%)
profiling 15.083 s [15.083 s, 15.083 s] -92.0 ms (-0.6%)
tracing 14.965 s [14.965 s, 14.965 s] -210.0 ms (-1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.422 s [15.422 s, 15.422 s] -
appsec 15.222 s [15.222 s, 15.222 s] -200.0 ms (-1.3%)
iast 18.742 s [18.742 s, 18.742 s] 3.32 s (21.5%)
iast_GLOBAL 17.835 s [17.835 s, 17.835 s] 2.413 s (15.6%)
profiling 15.077 s [15.077 s, 15.077 s] -345.0 ms (-2.2%)
tracing 15.228 s [15.228 s, 15.228 s] -194.0 ms (-1.3%)

@PerfectSlayer PerfectSlayer added the type: bug Bug report and fix label Apr 24, 2024
PerfectSlayer
PerfectSlayer approved these changes Apr 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the workaround in the issue 🙏
We will stick with it until we find a better solution (if ever).

@randomanderson randomanderson merged commit 5316d23 into master Apr 24, 2024
@randomanderson randomanderson deleted the landerson/cache-permissions branch April 24, 2024 13:49
@github-actions github-actions Bot added this to the 1.34.0 milestone Apr 24, 2024
@PerfectSlayer PerfectSlayer mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.34.0

Development

Successfully merging this pull request may close these issues.

2 participants

@randomanderson @PerfectSlayer