-
Notifications
You must be signed in to change notification settings - Fork 323
Remove old context prototype #8162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~f050879f0a, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053480
Total [baseline] (10.443 s) : 0, 10443116
Agent [candidate] (1.066 s) : 0, 1065677
Total [candidate] (10.449 s) : 0, 10448814
section appsec
Agent [baseline] (1.185 s) : 0, 1185316
Total [baseline] (10.668 s) : 0, 10668332
Agent [candidate] (1.197 s) : 0, 1196908
Total [candidate] (10.725 s) : 0, 10725419
section iast
Agent [baseline] (1.182 s) : 0, 1182162
Total [baseline] (11.005 s) : 0, 11004595
Agent [candidate] (1.181 s) : 0, 1181066
Total [candidate] (10.939 s) : 0, 10938679
section profiling
Agent [baseline] (1.275 s) : 0, 1274636
Total [baseline] (10.786 s) : 0, 10785921
Agent [candidate] (1.278 s) : 0, 1277944
Total [candidate] (10.797 s) : 0, 10797389
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~f050879f0a, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.198 ms) : 0, 712198
BytebuddyAgent [candidate] (720.68 ms) : 0, 720680
GlobalTracer [baseline] (255.944 ms) : 0, 255944
GlobalTracer [candidate] (258.179 ms) : 0, 258179
AppSec [baseline] (56.169 ms) : 0, 56169
AppSec [candidate] (55.843 ms) : 0, 55843
Remote Config [baseline] (712.613 µs) : 0, 713
Remote Config [candidate] (732.375 µs) : 0, 732
Telemetry [baseline] (13.435 ms) : 0, 13435
Telemetry [candidate] (15.01 ms) : 0, 15010
section appsec
BytebuddyAgent [baseline] (729.715 ms) : 0, 729715
BytebuddyAgent [candidate] (736.875 ms) : 0, 736875
GlobalTracer [baseline] (252.431 ms) : 0, 252431
GlobalTracer [candidate] (255.171 ms) : 0, 255171
AppSec [baseline] (169.917 ms) : 0, 169917
AppSec [candidate] (171.174 ms) : 0, 171174
Remote Config [baseline] (651.464 µs) : 0, 651
Remote Config [candidate] (658.335 µs) : 0, 658
Telemetry [baseline] (7.941 ms) : 0, 7941
Telemetry [candidate] (7.981 ms) : 0, 7981
IAST [baseline] (19.249 ms) : 0, 19249
IAST [candidate] (19.719 ms) : 0, 19719
section iast
BytebuddyAgent [baseline] (830.954 ms) : 0, 830954
BytebuddyAgent [candidate] (830.885 ms) : 0, 830885
GlobalTracer [baseline] (247.692 ms) : 0, 247692
GlobalTracer [candidate] (246.793 ms) : 0, 246793
AppSec [baseline] (58.057 ms) : 0, 58057
AppSec [candidate] (58.05 ms) : 0, 58050
Remote Config [baseline] (656.709 µs) : 0, 657
Remote Config [candidate] (645.932 µs) : 0, 646
Telemetry [baseline] (8.524 ms) : 0, 8524
Telemetry [candidate] (8.483 ms) : 0, 8483
IAST [baseline] (21.336 ms) : 0, 21336
IAST [candidate] (21.188 ms) : 0, 21188
section profiling
BytebuddyAgent [baseline] (702.35 ms) : 0, 702350
BytebuddyAgent [candidate] (705.301 ms) : 0, 705301
GlobalTracer [baseline] (372.491 ms) : 0, 372491
GlobalTracer [candidate] (371.739 ms) : 0, 371739
AppSec [baseline] (53.905 ms) : 0, 53905
AppSec [candidate] (54.783 ms) : 0, 54783
Remote Config [baseline] (665.643 µs) : 0, 666
Remote Config [candidate] (654.379 µs) : 0, 654
Telemetry [baseline] (7.824 ms) : 0, 7824
Telemetry [candidate] (7.826 ms) : 0, 7826
ProfilingAgent [baseline] (95.65 ms) : 0, 95650
ProfilingAgent [candidate] (95.57 ms) : 0, 95570
Profiling [baseline] (95.673 ms) : 0, 95673
Profiling [candidate] (95.593 ms) : 0, 95593
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~f050879f0a, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060235
Total [baseline] (8.637 s) : 0, 8636532
Agent [candidate] (1.054 s) : 0, 1053917
Total [candidate] (8.591 s) : 0, 8590630
section iast
Agent [baseline] (1.178 s) : 0, 1177807
Total [baseline] (9.203 s) : 0, 9202735
Agent [candidate] (1.18 s) : 0, 1179665
Total [candidate] (9.185 s) : 0, 9185260
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1180031
Total [baseline] (9.16 s) : 0, 9160348
Agent [candidate] (1.181 s) : 0, 1181229
Total [candidate] (9.171 s) : 0, 9171415
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1183502
Total [baseline] (9.195 s) : 0, 9194946
Agent [candidate] (1.177 s) : 0, 1176551
Total [candidate] (9.164 s) : 0, 9164411
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~f050879f0a, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.676 ms) : 0, 716676
BytebuddyAgent [candidate] (713.553 ms) : 0, 713553
GlobalTracer [baseline] (256.53 ms) : 0, 256530
GlobalTracer [candidate] (255.932 ms) : 0, 255932
AppSec [baseline] (56.274 ms) : 0, 56274
AppSec [candidate] (57.463 ms) : 0, 57463
Remote Config [baseline] (730.605 µs) : 0, 731
Remote Config [candidate] (717.717 µs) : 0, 718
Telemetry [baseline] (14.931 ms) : 0, 14931
Telemetry [candidate] (11.268 ms) : 0, 11268
section iast
BytebuddyAgent [baseline] (828.68 ms) : 0, 828680
BytebuddyAgent [candidate] (830.056 ms) : 0, 830056
GlobalTracer [baseline] (246.011 ms) : 0, 246011
GlobalTracer [candidate] (246.263 ms) : 0, 246263
AppSec [baseline] (57.954 ms) : 0, 57954
AppSec [candidate] (58.175 ms) : 0, 58175
IAST [baseline] (21.095 ms) : 0, 21095
IAST [candidate] (20.856 ms) : 0, 20856
Remote Config [baseline] (641.938 µs) : 0, 642
Remote Config [candidate] (634.169 µs) : 0, 634
Telemetry [baseline] (8.465 ms) : 0, 8465
Telemetry [candidate] (8.557 ms) : 0, 8557
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (830.192 ms) : 0, 830192
BytebuddyAgent [candidate] (831.304 ms) : 0, 831304
GlobalTracer [baseline] (246.588 ms) : 0, 246588
GlobalTracer [candidate] (246.662 ms) : 0, 246662
AppSec [baseline] (58.228 ms) : 0, 58228
AppSec [candidate] (57.981 ms) : 0, 57981
IAST [baseline] (20.997 ms) : 0, 20997
IAST [candidate] (21.112 ms) : 0, 21112
Remote Config [baseline] (639.044 µs) : 0, 639
Remote Config [candidate] (640.983 µs) : 0, 641
Telemetry [baseline] (8.457 ms) : 0, 8457
Telemetry [candidate] (8.471 ms) : 0, 8471
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.718 ms) : 0, 832718
BytebuddyAgent [candidate] (827.664 ms) : 0, 827664
GlobalTracer [baseline] (247.789 ms) : 0, 247789
GlobalTracer [candidate] (246.525 ms) : 0, 246525
AppSec [baseline] (57.988 ms) : 0, 57988
AppSec [candidate] (57.698 ms) : 0, 57698
IAST [baseline] (20.896 ms) : 0, 20896
IAST [candidate] (20.696 ms) : 0, 20696
Remote Config [baseline] (645.516 µs) : 0, 646
Remote Config [candidate] (635.608 µs) : 0, 636
Telemetry [baseline] (8.371 ms) : 0, 8371
Telemetry [candidate] (8.337 ms) : 0, 8337
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~f050879f0a, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section baseline
no_agent (381.868 µs) : 362, 402
. : milestone, 382,
iast (500.606 µs) : 479, 522
. : milestone, 501,
iast_FULL (662.108 µs) : 640, 684
. : milestone, 662,
iast_GLOBAL (530.062 µs) : 508, 552
. : milestone, 530,
iast_HARDCODED_SECRET_DISABLED (498.459 µs) : 477, 520
. : milestone, 498,
iast_INACTIVE (469.44 µs) : 448, 491
. : milestone, 469,
iast_TELEMETRY_OFF (487.694 µs) : 466, 509
. : milestone, 488,
tracing (457.458 µs) : 437, 478
. : milestone, 457,
section candidate
no_agent (378.47 µs) : 358, 399
. : milestone, 378,
iast (501.712 µs) : 480, 523
. : milestone, 502,
iast_FULL (661.143 µs) : 639, 683
. : milestone, 661,
iast_GLOBAL (526.547 µs) : 504, 549
. : milestone, 527,
iast_HARDCODED_SECRET_DISABLED (504.833 µs) : 483, 527
. : milestone, 505,
iast_INACTIVE (463.162 µs) : 442, 484
. : milestone, 463,
iast_TELEMETRY_OFF (493.171 µs) : 472, 515
. : milestone, 493,
tracing (458.309 µs) : 437, 480
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~f050879f0a, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1377
. : milestone, 1358,
appsec (1.773 ms) : 1750, 1796
. : milestone, 1773,
appsec_no_iast (1.743 ms) : 1718, 1769
. : milestone, 1743,
iast (1.5 ms) : 1477, 1523
. : milestone, 1500,
profiling (1.516 ms) : 1492, 1539
. : milestone, 1516,
tracing (1.49 ms) : 1464, 1515
. : milestone, 1490,
section candidate
no_agent (1.362 ms) : 1342, 1382
. : milestone, 1362,
appsec (1.755 ms) : 1731, 1778
. : milestone, 1755,
appsec_no_iast (1.748 ms) : 1723, 1773
. : milestone, 1748,
iast (1.509 ms) : 1486, 1533
. : milestone, 1509,
profiling (1.525 ms) : 1502, 1547
. : milestone, 1525,
tracing (1.525 ms) : 1501, 1550
. : milestone, 1525,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~f050879f0a, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.341 ms) : 2299, 2383
. : milestone, 2341,
iast (2.105 ms) : 2052, 2159
. : milestone, 2105,
iast_GLOBAL (2.144 ms) : 2090, 2197
. : milestone, 2144,
profiling (2.442 ms) : 2256, 2628
. : milestone, 2442,
tracing (1.943 ms) : 1901, 1984
. : milestone, 1943,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.361 ms) : 2318, 2404
. : milestone, 2361,
iast (2.089 ms) : 2036, 2142
. : milestone, 2089,
iast_GLOBAL (2.139 ms) : 2085, 2193
. : milestone, 2139,
profiling (1.998 ms) : 1953, 2043
. : milestone, 1998,
tracing (1.941 ms) : 1900, 1983
. : milestone, 1941,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~f050879f0a, baseline=1.45.0-SNAPSHOT~0c2f7ff792
dateFormat X
axisFormat %s
section baseline
no_agent (14.717 s) : 14717000, 14717000
. : milestone, 14717000,
appsec (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
iast (18.674 s) : 18674000, 18674000
. : milestone, 18674000,
iast_GLOBAL (18.04 s) : 18040000, 18040000
. : milestone, 18040000,
profiling (15.522 s) : 15522000, 15522000
. : milestone, 15522000,
tracing (15.066 s) : 15066000, 15066000
. : milestone, 15066000,
section candidate
no_agent (15.601 s) : 15601000, 15601000
. : milestone, 15601000,
appsec (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
iast (18.919 s) : 18919000, 18919000
. : milestone, 18919000,
iast_GLOBAL (17.796 s) : 17796000, 17796000
. : milestone, 17796000,
profiling (14.951 s) : 14951000, 14951000
. : milestone, 14951000,
tracing (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
|
PerfectSlayer
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've extracted context to its own module.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-959