-
Notifications
You must be signed in to change notification settings - Fork 322
Upgrade actions/cache before it breaks #8261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check actions/cache#1510 for context
smola
approved these changes
Jan 21, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~9608d09d39, baseline=1.46.0-SNAPSHOT~01c83aa245
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055144
Total [baseline] (10.546 s) : 0, 10546353
Agent [candidate] (1.061 s) : 0, 1061255
Total [candidate] (10.426 s) : 0, 10426078
section appsec
Agent [baseline] (1.196 s) : 0, 1196497
Total [baseline] (10.757 s) : 0, 10757185
Agent [candidate] (1.196 s) : 0, 1195876
Total [candidate] (10.764 s) : 0, 10763611
section iast
Agent [baseline] (1.192 s) : 0, 1192292
Total [baseline] (11.022 s) : 0, 11022376
Agent [candidate] (1.183 s) : 0, 1182546
Total [candidate] (11.062 s) : 0, 11061819
section profiling
Agent [baseline] (1.265 s) : 0, 1264816
Total [baseline] (10.885 s) : 0, 10885126
Agent [candidate] (1.261 s) : 0, 1261198
Total [candidate] (10.94 s) : 0, 10940037
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~9608d09d39, baseline=1.46.0-SNAPSHOT~01c83aa245
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.749 ms) : 0, 714749
BytebuddyAgent [candidate] (719.262 ms) : 0, 719262
GlobalTracer [baseline] (255.692 ms) : 0, 255692
GlobalTracer [candidate] (255.883 ms) : 0, 255883
AppSec [baseline] (56.343 ms) : 0, 56343
AppSec [candidate] (57.49 ms) : 0, 57490
Remote Config [baseline] (732.79 µs) : 0, 733
Remote Config [candidate] (743.937 µs) : 0, 744
Telemetry [baseline] (12.696 ms) : 0, 12696
Telemetry [candidate] (12.744 ms) : 0, 12744
section appsec
BytebuddyAgent [baseline] (736.399 ms) : 0, 736399
BytebuddyAgent [candidate] (736.445 ms) : 0, 736445
GlobalTracer [baseline] (254.932 ms) : 0, 254932
GlobalTracer [candidate] (254.886 ms) : 0, 254886
AppSec [baseline] (171.495 ms) : 0, 171495
AppSec [candidate] (170.794 ms) : 0, 170794
IAST [baseline] (19.5 ms) : 0, 19500
IAST [candidate] (19.34 ms) : 0, 19340
Remote Config [baseline] (671.515 µs) : 0, 672
Remote Config [candidate] (668.086 µs) : 0, 668
Telemetry [baseline] (8.196 ms) : 0, 8196
Telemetry [candidate] (8.232 ms) : 0, 8232
section iast
BytebuddyAgent [baseline] (839.048 ms) : 0, 839048
BytebuddyAgent [candidate] (831.985 ms) : 0, 831985
GlobalTracer [baseline] (248.706 ms) : 0, 248706
GlobalTracer [candidate] (246.803 ms) : 0, 246803
AppSec [baseline] (58.314 ms) : 0, 58314
AppSec [candidate] (57.93 ms) : 0, 57930
IAST [baseline] (21.688 ms) : 0, 21688
IAST [candidate] (21.488 ms) : 0, 21488
Remote Config [baseline] (660.219 µs) : 0, 660
Remote Config [candidate] (661.823 µs) : 0, 662
Telemetry [baseline] (8.74 ms) : 0, 8740
Telemetry [candidate] (8.649 ms) : 0, 8649
section profiling
BytebuddyAgent [baseline] (709.213 ms) : 0, 709213
BytebuddyAgent [candidate] (706.224 ms) : 0, 706224
GlobalTracer [baseline] (351.966 ms) : 0, 351966
GlobalTracer [candidate] (352.902 ms) : 0, 352902
AppSec [baseline] (55.316 ms) : 0, 55316
AppSec [candidate] (54.649 ms) : 0, 54649
Remote Config [baseline] (711.623 µs) : 0, 712
Remote Config [candidate] (726.487 µs) : 0, 726
Telemetry [baseline] (8.832 ms) : 0, 8832
Telemetry [candidate] (8.895 ms) : 0, 8895
ProfilingAgent [baseline] (96.438 ms) : 0, 96438
ProfilingAgent [candidate] (95.66 ms) : 0, 95660
Profiling [baseline] (96.462 ms) : 0, 96462
Profiling [candidate] (95.688 ms) : 0, 95688
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~9608d09d39, baseline=1.46.0-SNAPSHOT~01c83aa245
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068735
Total [baseline] (8.666 s) : 0, 8665855
Agent [candidate] (1.057 s) : 0, 1057086
Total [candidate] (8.646 s) : 0, 8646393
section iast
Agent [baseline] (1.186 s) : 0, 1186138
Total [baseline] (9.238 s) : 0, 9237995
Agent [candidate] (1.189 s) : 0, 1188503
Total [candidate] (9.238 s) : 0, 9238130
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184679
Total [baseline] (9.171 s) : 0, 9170938
Agent [candidate] (1.188 s) : 0, 1188448
Total [candidate] (9.198 s) : 0, 9197691
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1178952
Total [baseline] (9.211 s) : 0, 9211189
Agent [candidate] (1.186 s) : 0, 1186175
Total [candidate] (9.213 s) : 0, 9212898
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~9608d09d39, baseline=1.46.0-SNAPSHOT~01c83aa245
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.535 ms) : 0, 723535
BytebuddyAgent [candidate] (714.33 ms) : 0, 714330
GlobalTracer [baseline] (257.606 ms) : 0, 257606
GlobalTracer [candidate] (256.358 ms) : 0, 256358
AppSec [baseline] (55.804 ms) : 0, 55804
AppSec [candidate] (56.349 ms) : 0, 56349
Remote Config [baseline] (760.886 µs) : 0, 761
Remote Config [candidate] (750.223 µs) : 0, 750
Telemetry [baseline] (15.806 ms) : 0, 15806
Telemetry [candidate] (14.305 ms) : 0, 14305
section iast
BytebuddyAgent [baseline] (834.63 ms) : 0, 834630
BytebuddyAgent [candidate] (836.622 ms) : 0, 836622
GlobalTracer [baseline] (247.386 ms) : 0, 247386
GlobalTracer [candidate] (248.048 ms) : 0, 248048
AppSec [baseline] (58.155 ms) : 0, 58155
AppSec [candidate] (58.18 ms) : 0, 58180
IAST [baseline] (21.474 ms) : 0, 21474
IAST [candidate] (21.183 ms) : 0, 21183
Remote Config [baseline] (665.383 µs) : 0, 665
Remote Config [candidate] (655.028 µs) : 0, 655
Telemetry [baseline] (8.77 ms) : 0, 8770
Telemetry [candidate] (8.691 ms) : 0, 8691
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.079 ms) : 0, 833079
BytebuddyAgent [candidate] (835.194 ms) : 0, 835194
GlobalTracer [baseline] (247.094 ms) : 0, 247094
GlobalTracer [candidate] (248.241 ms) : 0, 248241
AppSec [baseline] (58.313 ms) : 0, 58313
AppSec [candidate] (58.655 ms) : 0, 58655
IAST [baseline] (21.633 ms) : 0, 21633
IAST [candidate] (21.739 ms) : 0, 21739
Remote Config [baseline] (679.637 µs) : 0, 680
Remote Config [candidate] (664.241 µs) : 0, 664
Telemetry [baseline] (8.848 ms) : 0, 8848
Telemetry [candidate] (8.895 ms) : 0, 8895
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.773 ms) : 0, 828773
BytebuddyAgent [candidate] (833.071 ms) : 0, 833071
GlobalTracer [baseline] (246.939 ms) : 0, 246939
GlobalTracer [candidate] (248.858 ms) : 0, 248858
AppSec [baseline] (57.956 ms) : 0, 57956
AppSec [candidate] (58.532 ms) : 0, 58532
IAST [baseline] (21.059 ms) : 0, 21059
IAST [candidate] (21.279 ms) : 0, 21279
Remote Config [baseline] (659.724 µs) : 0, 660
Remote Config [candidate] (669.625 µs) : 0, 670
Telemetry [baseline] (8.66 ms) : 0, 8660
Telemetry [candidate] (8.734 ms) : 0, 8734
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9608d09d39, baseline=1.46.0-SNAPSHOT~01c83aa245
dateFormat X
axisFormat %s
section baseline
no_agent (383.754 µs) : 364, 404
. : milestone, 384,
iast (503.185 µs) : 482, 525
. : milestone, 503,
iast_FULL (740.095 µs) : 718, 762
. : milestone, 740,
iast_GLOBAL (549.555 µs) : 528, 572
. : milestone, 550,
iast_HARDCODED_SECRET_DISABLED (502.506 µs) : 481, 524
. : milestone, 503,
iast_INACTIVE (461.737 µs) : 441, 483
. : milestone, 462,
iast_TELEMETRY_OFF (497.254 µs) : 475, 520
. : milestone, 497,
tracing (449.394 µs) : 428, 471
. : milestone, 449,
section candidate
no_agent (385.462 µs) : 365, 406
. : milestone, 385,
iast (502.12 µs) : 480, 524
. : milestone, 502,
iast_FULL (743.158 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (550.263 µs) : 529, 572
. : milestone, 550,
iast_HARDCODED_SECRET_DISABLED (510.457 µs) : 488, 533
. : milestone, 510,
iast_INACTIVE (463.865 µs) : 442, 486
. : milestone, 464,
iast_TELEMETRY_OFF (504.749 µs) : 483, 527
. : milestone, 505,
tracing (454.157 µs) : 433, 475
. : milestone, 454,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9608d09d39, baseline=1.46.0-SNAPSHOT~01c83aa245
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1341, 1381
. : milestone, 1361,
appsec (1.756 ms) : 1732, 1780
. : milestone, 1756,
appsec_no_iast (1.748 ms) : 1726, 1771
. : milestone, 1748,
iast (1.514 ms) : 1490, 1537
. : milestone, 1514,
profiling (1.502 ms) : 1478, 1525
. : milestone, 1502,
tracing (1.494 ms) : 1468, 1520
. : milestone, 1494,
section candidate
no_agent (1.364 ms) : 1345, 1384
. : milestone, 1364,
appsec (1.751 ms) : 1727, 1775
. : milestone, 1751,
appsec_no_iast (1.771 ms) : 1748, 1795
. : milestone, 1771,
iast (1.526 ms) : 1503, 1550
. : milestone, 1526,
profiling (1.515 ms) : 1490, 1540
. : milestone, 1515,
tracing (1.473 ms) : 1448, 1498
. : milestone, 1473,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9608d09d39, baseline=1.46.0-SNAPSHOT~01c83aa245
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.345 ms) : 2302, 2388
. : milestone, 2345,
iast (2.092 ms) : 2037, 2146
. : milestone, 2092,
iast_GLOBAL (2.146 ms) : 2091, 2200
. : milestone, 2146,
profiling (1.951 ms) : 1908, 1994
. : milestone, 1951,
tracing (1.925 ms) : 1884, 1967
. : milestone, 1925,
section candidate
no_agent (1.463 ms) : 1452, 1475
. : milestone, 1463,
appsec (2.349 ms) : 2306, 2392
. : milestone, 2349,
iast (2.097 ms) : 2042, 2151
. : milestone, 2097,
iast_GLOBAL (2.137 ms) : 2082, 2191
. : milestone, 2137,
profiling (1.958 ms) : 1915, 2001
. : milestone, 1958,
tracing (1.928 ms) : 1887, 1970
. : milestone, 1928,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9608d09d39, baseline=1.46.0-SNAPSHOT~01c83aa245
dateFormat X
axisFormat %s
section baseline
no_agent (15.294 s) : 15294000, 15294000
. : milestone, 15294000,
appsec (15.17 s) : 15170000, 15170000
. : milestone, 15170000,
iast (19.058 s) : 19058000, 19058000
. : milestone, 19058000,
iast_GLOBAL (17.956 s) : 17956000, 17956000
. : milestone, 17956000,
profiling (15.144 s) : 15144000, 15144000
. : milestone, 15144000,
tracing (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
section candidate
no_agent (14.872 s) : 14872000, 14872000
. : milestone, 14872000,
appsec (15.024 s) : 15024000, 15024000
. : milestone, 15024000,
iast (18.773 s) : 18773000, 18773000
. : milestone, 18773000,
iast_GLOBAL (17.901 s) : 17901000, 17901000
. : milestone, 17901000,
profiling (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
tracing (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR upgrade the actions/cache action as it's deprecated and will stop working.
Motivation
Check actions/cache#1510 for context
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-269