Do not send headers to old kafka servers#836
Merged
Merged
Conversation
Kafka message bundles with versions below 2 (e.d. 0.10) do not support headers so do not inject them. Otherwise client gets really upset. This is how similar check is being done in Kafka client itself: https://github.com/apache/kafka/blob/05fcfde8f69b0349216553f711fdfc3f0259c601/clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java#L411-L412
mar-kolya
force-pushed
the
mar-kolya/do-not-send-headers-to-old-kafka
branch
from
0930ea2 to
55d7c2a
Compare
mar-kolya
force-pushed
the
mar-kolya/do-not-send-headers-to-old-kafka
branch
from
0ef35e3 to
c02110a
Compare
tylerbenson
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka message bundles with versions below 2 (e.d. 0.10) do not support
headers so do not inject them. Otherwise client gets really upset.