Glassfish: prevent blacklisting of specific classes and dump stacktrace in debug mode if this happens#839
Merged
Merged
Conversation
labbati
force-pushed
the
labbati/jdbc-error-glasshfish
branch
from
da91800 to
19d9880
Compare
tylerbenson
suggested changes
May 24, 2019
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Use BOOTSTRAP_PACKAGE_PREFIXES instead.
Also, I think this might work better as a separate integration.
tylerbenson
suggested changes
May 27, 2019
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Please improve the version range muzzle check.
tylerbenson
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interesting links:
When a resource is loaded by the Glassfish class loader and it is not loadable it gets added to a blacklist. Such blacklist is then used to prevent further attempts when the classes is loaded.
For a reason that was not clear, it looks like an opentracing class was attempted to be loaded too early in glassfish. We were not able to reproduce it locally so I cannot provide further details as of now. We were only able to observe on a customer's server. This did not allow us to perform a more in-depth investigation.
This PR proposes a workaround, we do not blacklist opentracing resources from being loaded (or attempted to be loaded) again when they are not found.
We had the option of preventing blacklist to be avoid when reading it or when writing it. We decided to hook into the write because the read method is read for EACH class loaded, while the write method only for resources that are not found.