Avoid setting hostname tag on local root span if empty#846
Merged
Conversation
tylerbenson
approved these changes
May 17, 2019
mar-kolya
reviewed
May 17, 2019
|
|
||
| String hostname = ""; | ||
| if (reportHostName) { | ||
| hostname = getHostname(); |
Contributor
There was a problem hiding this comment.
You may want to keep hostname vs hostName consistent :)
mar-kolya
reviewed
May 17, 2019
|
|
||
| final Map<String, String> result = | ||
| newHashMap(reportHostName ? (runtimeTags.size() + 1) : runtimeTags.size()); | ||
| newHashMap(hostNameIsValid ? (runtimeTags.size() + 1) : runtimeTags.size()); |
Contributor
There was a problem hiding this comment.
IMHO by now precalculating this becomes ridiculously complex we should consider dropping this - it's simply not worth the immeasurable savings in time/memory.
tylerbenson
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.