Use default service name for RabbitMQ consumer #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
reviewed
May 24, 2019
| /* | ||
| Use default service name. Common use-case here is to have consumer span parent | ||
| children spans in instrumented application. Since service name is inherited it makes | ||
| sense to default that to application service name rather than 'kafka'. |
So spans parented by consumer span had reasonable service name
mar-kolya
force-pushed
the
mar-kolya/rabbitmq-client-service-name
branch
from
932fafb to
a7271ed
Compare
Contributor
|
I created #858 to help provide potentially a better path forward for the default rabbitmq consumer implementations. I have some concerns around what the above would do for metrics / alerts on the rabbitmq service. By doing this you would just move deliver methods to not show up as rabbitmq and instead the service. |
tylerbenson
added a commit
that referenced
this pull request
May 29, 2019
These are breaking changes that need more vetting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So spans parented by consumer span had reasonable service name