Change the scope for the netty client callback#886
Merged
Conversation
tylerbenson
force-pushed
the
tyler/netty-client-callback
branch
2 times, most recently
from
a2181b1 to
9a8c8e2
Compare
tylerbenson
force-pushed
the
tyler/netty-client-callback
branch
from
219168b to
6705a6d
Compare
tylerbenson
force-pushed
the
tyler/netty-client-callback
branch
from
c2800e3 to
2e2cc97
Compare
labbati
approved these changes
Jul 18, 2019
Member
labbati
left a comment
labbati
left a comment
There was a problem hiding this comment.
Looks good to me, please mark this PR as breaking change. I feel like we should be good to release it but still it changes the structure the user expects as of now
Member
There was a problem hiding this comment.
Just to make sure, here the reasoning is instead of setting it explicitly I let HttpDecorator.onResponse() to do that!
Contributor
Author
There was a problem hiding this comment.
In this case, I think we were previously setting the client span's status to error if the callback threw an error, which I don't think is correct.
tylerbenson
commented
Jul 18, 2019
Contributor
Author
|
Let's figure out #917 first and apply the change to here before merging. |
Previously the scope was the http client span, which could result in deep nesting. Now it is the parent span.
Before
[——————Parent—————]
[ ^ ———Client—————]
[ ^—Child—]
Now:
[——————Parent—————]
[ ^ —Client—] [ ^—Child—]
Also improve the tests.
Adds reactive/circuitbreaker tests.
Fix some more tests.
tylerbenson
force-pushed
the
tyler/netty-client-callback
branch
from
0063eba to
ea4fc4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the scope was the http client span, which could result in deep nesting. Now it is the parent span.
Before
Now:
Also improve the tests.