Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 11 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~ce1c1ebcdd, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029268
Total [baseline] (10.601 s) : 0, 10600750
Agent [candidate] (1.023 s) : 0, 1022910
Total [candidate] (10.475 s) : 0, 10474851
section appsec
Agent [baseline] (1.163 s) : 0, 1162625
Total [baseline] (10.767 s) : 0, 10766726
Agent [candidate] (1.17 s) : 0, 1170105
Total [candidate] (10.715 s) : 0, 10715457
section iast
Agent [baseline] (1.151 s) : 0, 1151467
Total [baseline] (10.878 s) : 0, 10878215
Agent [candidate] (1.15 s) : 0, 1150143
Total [candidate] (10.921 s) : 0, 10920896
section profiling
Agent [baseline] (1.283 s) : 0, 1282878
Total [baseline] (10.957 s) : 0, 10957274
Agent [candidate] (1.264 s) : 0, 1264428
Total [candidate] (10.91 s) : 0, 10910068
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~ce1c1ebcdd, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.42 ms) : 0, 689420
BytebuddyAgent [candidate] (684.602 ms) : 0, 684602
GlobalTracer [baseline] (243.534 ms) : 0, 243534
GlobalTracer [candidate] (241.138 ms) : 0, 241138
AppSec [baseline] (55.115 ms) : 0, 55115
AppSec [candidate] (56.944 ms) : 0, 56944
Debugger [baseline] (8.363 ms) : 0, 8363
Debugger [candidate] (7.564 ms) : 0, 7564
Remote Config [baseline] (705.3 µs) : 0, 705
Remote Config [candidate] (712.659 µs) : 0, 713
Telemetry [baseline] (8.397 ms) : 0, 8397
Telemetry [candidate] (8.329 ms) : 0, 8329
section appsec
BytebuddyAgent [baseline] (700.692 ms) : 0, 700692
BytebuddyAgent [candidate] (706.084 ms) : 0, 706084
GlobalTracer [baseline] (237.409 ms) : 0, 237409
GlobalTracer [candidate] (238.707 ms) : 0, 238707
AppSec [baseline] (175.648 ms) : 0, 175648
AppSec [candidate] (175.793 ms) : 0, 175793
Debugger [baseline] (5.971 ms) : 0, 5971
Debugger [candidate] (5.993 ms) : 0, 5993
Remote Config [baseline] (626.831 µs) : 0, 627
Remote Config [candidate] (626.922 µs) : 0, 627
Telemetry [baseline] (7.825 ms) : 0, 7825
Telemetry [candidate] (8.172 ms) : 0, 8172
IAST [baseline] (21.774 ms) : 0, 21774
IAST [candidate] (22.151 ms) : 0, 22151
section iast
BytebuddyAgent [baseline] (803.12 ms) : 0, 803120
BytebuddyAgent [candidate] (802.82 ms) : 0, 802820
GlobalTracer [baseline] (231.35 ms) : 0, 231350
GlobalTracer [candidate] (230.858 ms) : 0, 230858
AppSec [baseline] (48.891 ms) : 0, 48891
AppSec [candidate] (49.449 ms) : 0, 49449
Debugger [baseline] (5.943 ms) : 0, 5943
Debugger [candidate] (5.9 ms) : 0, 5900
Remote Config [baseline] (596.05 µs) : 0, 596
Remote Config [candidate] (591.651 µs) : 0, 592
Telemetry [baseline] (7.948 ms) : 0, 7948
Telemetry [candidate] (7.939 ms) : 0, 7939
IAST [baseline] (27.678 ms) : 0, 27678
IAST [candidate] (29.084 ms) : 0, 29084
section profiling
BytebuddyAgent [baseline] (673.749 ms) : 0, 673749
BytebuddyAgent [candidate] (674.034 ms) : 0, 674034
GlobalTracer [baseline] (379.047 ms) : 0, 379047
GlobalTracer [candidate] (359.772 ms) : 0, 359772
AppSec [baseline] (54.809 ms) : 0, 54809
AppSec [candidate] (61.72 ms) : 0, 61720
Debugger [baseline] (6.133 ms) : 0, 6133
Debugger [candidate] (6.292 ms) : 0, 6292
Remote Config [baseline] (662.391 µs) : 0, 662
Remote Config [candidate] (649.977 µs) : 0, 650
Telemetry [baseline] (8.049 ms) : 0, 8049
Telemetry [candidate] (8.169 ms) : 0, 8169
ProfilingAgent [baseline] (109.836 ms) : 0, 109836
ProfilingAgent [candidate] (102.867 ms) : 0, 102867
Profiling [baseline] (109.861 ms) : 0, 109861
Profiling [candidate] (102.89 ms) : 0, 102890
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~ce1c1ebcdd, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020685
Total [baseline] (8.698 s) : 0, 8697973
Agent [candidate] (1.022 s) : 0, 1021554
Total [candidate] (8.659 s) : 0, 8658920
section iast
Agent [baseline] (1.15 s) : 0, 1149588
Total [baseline] (9.281 s) : 0, 9280840
Agent [candidate] (1.151 s) : 0, 1151425
Total [candidate] (9.232 s) : 0, 9232470
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.158 s) : 0, 1158106
Total [baseline] (9.226 s) : 0, 9225649
Agent [candidate] (1.158 s) : 0, 1157942
Total [candidate] (9.253 s) : 0, 9253431
section iast_TELEMETRY_OFF
Agent [baseline] (1.153 s) : 0, 1152783
Total [baseline] (9.313 s) : 0, 9313276
Agent [candidate] (1.147 s) : 0, 1147255
Total [candidate] (9.232 s) : 0, 9232091
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~ce1c1ebcdd, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.095 ms) : 0, 683095
BytebuddyAgent [candidate] (683.164 ms) : 0, 683164
GlobalTracer [baseline] (240.676 ms) : 0, 240676
GlobalTracer [candidate] (240.783 ms) : 0, 240783
AppSec [baseline] (54.626 ms) : 0, 54626
AppSec [candidate] (55.276 ms) : 0, 55276
Debugger [baseline] (9.8 ms) : 0, 9800
Debugger [candidate] (9.079 ms) : 0, 9079
Remote Config [baseline] (694.333 µs) : 0, 694
Remote Config [candidate] (704.914 µs) : 0, 705
Telemetry [baseline] (8.284 ms) : 0, 8284
Telemetry [candidate] (9.07 ms) : 0, 9070
section iast
BytebuddyAgent [baseline] (802.905 ms) : 0, 802905
BytebuddyAgent [candidate] (803.938 ms) : 0, 803938
GlobalTracer [baseline] (230.521 ms) : 0, 230521
GlobalTracer [candidate] (231.376 ms) : 0, 231376
AppSec [baseline] (50.191 ms) : 0, 50191
AppSec [candidate] (50.219 ms) : 0, 50219
Debugger [baseline] (5.906 ms) : 0, 5906
Debugger [candidate] (5.911 ms) : 0, 5911
Remote Config [baseline] (599.919 µs) : 0, 600
Remote Config [candidate] (598.852 µs) : 0, 599
Telemetry [baseline] (7.889 ms) : 0, 7889
Telemetry [candidate] (7.837 ms) : 0, 7837
IAST [baseline] (28.087 ms) : 0, 28087
IAST [candidate] (28.08 ms) : 0, 28080
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (808.349 ms) : 0, 808349
BytebuddyAgent [candidate] (808.25 ms) : 0, 808250
GlobalTracer [baseline] (232.302 ms) : 0, 232302
GlobalTracer [candidate] (232.507 ms) : 0, 232507
AppSec [baseline] (49.122 ms) : 0, 49122
AppSec [candidate] (48.854 ms) : 0, 48854
Debugger [baseline] (5.935 ms) : 0, 5935
Debugger [candidate] (5.963 ms) : 0, 5963
Remote Config [baseline] (604.167 µs) : 0, 604
Remote Config [candidate] (592.158 µs) : 0, 592
Telemetry [baseline] (7.919 ms) : 0, 7919
Telemetry [candidate] (7.978 ms) : 0, 7978
IAST [baseline] (30.234 ms) : 0, 30234
IAST [candidate] (30.154 ms) : 0, 30154
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.317 ms) : 0, 804317
BytebuddyAgent [candidate] (799.646 ms) : 0, 799646
GlobalTracer [baseline] (231.965 ms) : 0, 231965
GlobalTracer [candidate] (231.376 ms) : 0, 231376
AppSec [baseline] (55.937 ms) : 0, 55937
AppSec [candidate] (54.323 ms) : 0, 54323
Debugger [baseline] (5.96 ms) : 0, 5960
Debugger [candidate] (6.038 ms) : 0, 6038
Remote Config [baseline] (606.667 µs) : 0, 607
Remote Config [candidate] (626.539 µs) : 0, 627
Telemetry [baseline] (7.799 ms) : 0, 7799
Telemetry [candidate] (7.831 ms) : 0, 7831
IAST [baseline] (22.531 ms) : 0, 22531
IAST [candidate] (23.842 ms) : 0, 23842
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~ce1c1ebcdd, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.386 ms) : 1367, 1405
. : milestone, 1386,
appsec (1.752 ms) : 1728, 1777
. : milestone, 1752,
appsec_no_iast (1.752 ms) : 1729, 1775
. : milestone, 1752,
code_origins (1.671 ms) : 1645, 1698
. : milestone, 1671,
iast (1.538 ms) : 1513, 1563
. : milestone, 1538,
profiling (1.516 ms) : 1493, 1539
. : milestone, 1516,
tracing (1.508 ms) : 1482, 1533
. : milestone, 1508,
section candidate
no_agent (1.372 ms) : 1351, 1392
. : milestone, 1372,
appsec (1.755 ms) : 1731, 1779
. : milestone, 1755,
appsec_no_iast (1.747 ms) : 1723, 1770
. : milestone, 1747,
code_origins (1.665 ms) : 1638, 1692
. : milestone, 1665,
iast (1.536 ms) : 1511, 1560
. : milestone, 1536,
profiling (1.517 ms) : 1494, 1540
. : milestone, 1517,
tracing (1.497 ms) : 1473, 1522
. : milestone, 1497,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~ce1c1ebcdd, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (384.68 µs) : 365, 404
. : milestone, 385,
iast (529.872 µs) : 507, 553
. : milestone, 530,
iast_FULL (742.019 µs) : 720, 764
. : milestone, 742,
iast_GLOBAL (575.521 µs) : 553, 598
. : milestone, 576,
iast_HARDCODED_SECRET_DISABLED (524.085 µs) : 502, 546
. : milestone, 524,
iast_INACTIVE (476.809 µs) : 454, 500
. : milestone, 477,
iast_TELEMETRY_OFF (511.808 µs) : 489, 535
. : milestone, 512,
tracing (462.304 µs) : 440, 484
. : milestone, 462,
section candidate
no_agent (389.343 µs) : 369, 409
. : milestone, 389,
iast (526.175 µs) : 504, 549
. : milestone, 526,
iast_FULL (748.597 µs) : 727, 770
. : milestone, 749,
iast_GLOBAL (569.651 µs) : 547, 592
. : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (518.383 µs) : 497, 540
. : milestone, 518,
iast_INACTIVE (472.388 µs) : 450, 495
. : milestone, 472,
iast_TELEMETRY_OFF (519.149 µs) : 496, 542
. : milestone, 519,
tracing (467.517 µs) : 445, 490
. : milestone, 468,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ce1c1ebcdd, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (15.487 s) : 15487000, 15487000
. : milestone, 15487000,
appsec (15.17 s) : 15170000, 15170000
. : milestone, 15170000,
iast (18.884 s) : 18884000, 18884000
. : milestone, 18884000,
iast_GLOBAL (18.344 s) : 18344000, 18344000
. : milestone, 18344000,
profiling (15.823 s) : 15823000, 15823000
. : milestone, 15823000,
tracing (15.126 s) : 15126000, 15126000
. : milestone, 15126000,
section candidate
no_agent (14.805 s) : 14805000, 14805000
. : milestone, 14805000,
appsec (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
iast (18.56 s) : 18560000, 18560000
. : milestone, 18560000,
iast_GLOBAL (18.279 s) : 18279000, 18279000
. : milestone, 18279000,
profiling (14.845 s) : 14845000, 14845000
. : milestone, 14845000,
tracing (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ce1c1ebcdd, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (2.406 ms) : 2358, 2455
. : milestone, 2406,
iast (2.184 ms) : 2123, 2245
. : milestone, 2184,
iast_GLOBAL (2.228 ms) : 2167, 2290
. : milestone, 2228,
profiling (2.053 ms) : 2003, 2103
. : milestone, 2053,
tracing (2.011 ms) : 1963, 2058
. : milestone, 2011,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.422 ms) : 2372, 2472
. : milestone, 2422,
iast (2.191 ms) : 2130, 2252
. : milestone, 2191,
iast_GLOBAL (2.232 ms) : 2170, 2294
. : milestone, 2232,
profiling (2.036 ms) : 1987, 2085
. : milestone, 2036,
tracing (2.028 ms) : 1980, 2077
. : milestone, 2028,
|
There was a problem hiding this comment.
thought: Maybe org.jetbrains.kotlin.gradle.dsl.KotlinCompile can be available by declaring the kotlin plugin (without applying it). E.g. something like
import org.jetbrains.kotlin.gradle.dsl.KotlinCompile
plugins {
id ("org.jetbrains.kotlin.jvm") apply false
}
// ...There was a problem hiding this comment.
* Where:
Build file '/home/smola/go/src/github.com/DataDog/dd-trace-java/dd-smoke-tests/iast-propagation/build.gradle' line: 4
* What went wrong:
Error resolving plugin [id: 'org.jetbrains.kotlin.jvm', version: '1.9.24']
> The request for this plugin could not be satisfied because the plugin is already on the classpath with an unknown version, so compatibility cannot be checked.
At some point I gave up at trying to depend on the kotlin plugin classes from buildSrc.
There was a problem hiding this comment.
OK, that's annoying, I need to take a look at this at some point to make it work.
There was a problem hiding this comment.
In the end I just removed kotlin support altogether, since it was just not working.
5681d91 to
ce1c1eb
Compare
What Does This Do
Add gradle plugin to log metadata of configured projects when
-PddGradleDebugis set.This will generate
build/datadog.gradle-debug.logwith content as follows:Motivation
Verify impact to selected JDKs whenever we refactor configuration.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMJAVA-1342