Remove Trivy scan from PR checks#8890
Merged
PerfectSlayer merged 1 commit intomasterfrom May 27, 2025
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 55 metrics, 14 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~eb09981fbf, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020683
Total [baseline] (8.64 s) : 0, 8640459
Agent [candidate] (1.034 s) : 0, 1034100
Total [candidate] (8.682 s) : 0, 8682487
section iast
Agent [baseline] (1.147 s) : 0, 1146914
Total [baseline] (9.227 s) : 0, 9226896
Agent [candidate] (1.158 s) : 0, 1157971
Total [candidate] (9.25 s) : 0, 9249898
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.156 s) : 0, 1155557
Total [baseline] (9.258 s) : 0, 9258347
Agent [candidate] (1.152 s) : 0, 1152347
Total [candidate] (9.195 s) : 0, 9195201
section iast_TELEMETRY_OFF
Agent [baseline] (1.155 s) : 0, 1155219
Total [baseline] (9.243 s) : 0, 9243401
Agent [candidate] (1.154 s) : 0, 1154476
Total [candidate] (9.238 s) : 0, 9238280
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~eb09981fbf, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.172 ms) : 0, 682172
BytebuddyAgent [candidate] (692.876 ms) : 0, 692876
GlobalTracer [baseline] (239.836 ms) : 0, 239836
GlobalTracer [candidate] (243.114 ms) : 0, 243114
AppSec [baseline] (54.255 ms) : 0, 54255
AppSec [candidate] (56.002 ms) : 0, 56002
Debugger [baseline] (10.407 ms) : 0, 10407
Debugger [candidate] (8.987 ms) : 0, 8987
Remote Config [baseline] (682.798 µs) : 0, 683
Remote Config [candidate] (707.606 µs) : 0, 708
Telemetry [baseline] (9.703 ms) : 0, 9703
Telemetry [candidate] (8.456 ms) : 0, 8456
section iast
BytebuddyAgent [baseline] (800.593 ms) : 0, 800593
BytebuddyAgent [candidate] (808.024 ms) : 0, 808024
GlobalTracer [baseline] (229.813 ms) : 0, 229813
GlobalTracer [candidate] (232.25 ms) : 0, 232250
IAST [baseline] (28.377 ms) : 0, 28377
IAST [candidate] (28.661 ms) : 0, 28661
AppSec [baseline] (50.251 ms) : 0, 50251
AppSec [candidate] (50.869 ms) : 0, 50869
Debugger [baseline] (5.932 ms) : 0, 5932
Debugger [candidate] (5.984 ms) : 0, 5984
Remote Config [baseline] (592.558 µs) : 0, 593
Remote Config [candidate] (590.514 µs) : 0, 591
Telemetry [baseline] (7.878 ms) : 0, 7878
Telemetry [candidate] (7.946 ms) : 0, 7946
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.179 ms) : 0, 806179
BytebuddyAgent [candidate] (803.951 ms) : 0, 803951
GlobalTracer [baseline] (232.16 ms) : 0, 232160
GlobalTracer [candidate] (231.771 ms) : 0, 231771
IAST [baseline] (29.599 ms) : 0, 29599
IAST [candidate] (28.343 ms) : 0, 28343
AppSec [baseline] (49.613 ms) : 0, 49613
AppSec [candidate] (50.316 ms) : 0, 50316
Debugger [baseline] (5.943 ms) : 0, 5943
Debugger [candidate] (5.926 ms) : 0, 5926
Remote Config [baseline] (598.149 µs) : 0, 598
Remote Config [candidate] (586.683 µs) : 0, 587
Telemetry [baseline] (7.881 ms) : 0, 7881
Telemetry [candidate] (7.868 ms) : 0, 7868
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.381 ms) : 0, 806381
BytebuddyAgent [candidate] (805.338 ms) : 0, 805338
GlobalTracer [baseline] (232.33 ms) : 0, 232330
GlobalTracer [candidate] (232.407 ms) : 0, 232407
IAST [baseline] (22.554 ms) : 0, 22554
IAST [candidate] (23.466 ms) : 0, 23466
AppSec [baseline] (55.879 ms) : 0, 55879
AppSec [candidate] (55.173 ms) : 0, 55173
Debugger [baseline] (5.969 ms) : 0, 5969
Debugger [candidate] (5.978 ms) : 0, 5978
Remote Config [baseline] (607.52 µs) : 0, 608
Remote Config [candidate] (604.187 µs) : 0, 604
Telemetry [baseline] (7.78 ms) : 0, 7780
Telemetry [candidate] (7.829 ms) : 0, 7829
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~eb09981fbf, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1028850
Total [baseline] (10.498 s) : 0, 10497692
Agent [candidate] (1.026 s) : 0, 1025739
Total [candidate] (10.486 s) : 0, 10485509
section appsec
Agent [baseline] (1.17 s) : 0, 1169564
Total [baseline] (10.72 s) : 0, 10719735
Agent [candidate] (1.165 s) : 0, 1165262
Total [candidate] (10.662 s) : 0, 10661648
section iast
Agent [baseline] (1.15 s) : 0, 1149980
Total [baseline] (10.954 s) : 0, 10953903
Agent [candidate] (1.151 s) : 0, 1151484
Total [candidate] (10.87 s) : 0, 10869562
section profiling
Agent [baseline] (1.282 s) : 0, 1282196
Total [baseline] (10.944 s) : 0, 10943932
Agent [candidate] (1.287 s) : 0, 1286506
Total [candidate] (10.891 s) : 0, 10891357
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~eb09981fbf, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.478 ms) : 0, 688478
BytebuddyAgent [candidate] (685.774 ms) : 0, 685774
GlobalTracer [baseline] (242.22 ms) : 0, 242220
GlobalTracer [candidate] (241.826 ms) : 0, 241826
AppSec [baseline] (54.887 ms) : 0, 54887
AppSec [candidate] (55.66 ms) : 0, 55660
Debugger [baseline] (9.093 ms) : 0, 9093
Debugger [candidate] (9.767 ms) : 0, 9767
Remote Config [baseline] (685.744 µs) : 0, 686
Remote Config [candidate] (708.318 µs) : 0, 708
Telemetry [baseline] (9.759 ms) : 0, 9759
Telemetry [candidate] (8.352 ms) : 0, 8352
section appsec
BytebuddyAgent [baseline] (706.241 ms) : 0, 706241
BytebuddyAgent [candidate] (703.656 ms) : 0, 703656
GlobalTracer [baseline] (238.396 ms) : 0, 238396
GlobalTracer [candidate] (237.244 ms) : 0, 237244
IAST [baseline] (21.674 ms) : 0, 21674
IAST [candidate] (21.674 ms) : 0, 21674
AppSec [baseline] (176.543 ms) : 0, 176543
AppSec [candidate] (175.564 ms) : 0, 175564
Debugger [baseline] (5.912 ms) : 0, 5912
Debugger [candidate] (5.942 ms) : 0, 5942
Remote Config [baseline] (620.749 µs) : 0, 621
Remote Config [candidate] (622.974 µs) : 0, 623
Telemetry [baseline] (7.321 ms) : 0, 7321
Telemetry [candidate] (7.728 ms) : 0, 7728
section iast
BytebuddyAgent [baseline] (803.224 ms) : 0, 803224
BytebuddyAgent [candidate] (803.737 ms) : 0, 803737
GlobalTracer [baseline] (230.632 ms) : 0, 230632
GlobalTracer [candidate] (230.941 ms) : 0, 230941
IAST [baseline] (28.125 ms) : 0, 28125
IAST [candidate] (28.463 ms) : 0, 28463
AppSec [baseline] (49.355 ms) : 0, 49355
AppSec [candidate] (49.765 ms) : 0, 49765
Debugger [baseline] (5.935 ms) : 0, 5935
Debugger [candidate] (5.89 ms) : 0, 5890
Remote Config [baseline] (589.961 µs) : 0, 590
Remote Config [candidate] (590.798 µs) : 0, 591
Telemetry [baseline] (7.842 ms) : 0, 7842
Telemetry [candidate] (7.884 ms) : 0, 7884
section profiling
BytebuddyAgent [baseline] (673.835 ms) : 0, 673835
BytebuddyAgent [candidate] (685.24 ms) : 0, 685240
GlobalTracer [baseline] (378.95 ms) : 0, 378950
GlobalTracer [candidate] (364.684 ms) : 0, 364684
AppSec [baseline] (54.655 ms) : 0, 54655
AppSec [candidate] (62.392 ms) : 0, 62392
Debugger [baseline] (6.106 ms) : 0, 6106
Debugger [candidate] (6.365 ms) : 0, 6365
Remote Config [baseline] (644.024 µs) : 0, 644
Remote Config [candidate] (663.509 µs) : 0, 664
Telemetry [baseline] (8.124 ms) : 0, 8124
Telemetry [candidate] (8.29 ms) : 0, 8290
ProfilingAgent [baseline] (109.281 ms) : 0, 109281
ProfilingAgent [candidate] (107.237 ms) : 0, 107237
Profiling [baseline] (109.306 ms) : 0, 109306
Profiling [candidate] (107.262 ms) : 0, 107262
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~eb09981fbf, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1383
. : milestone, 1364,
appsec (1.735 ms) : 1711, 1759
. : milestone, 1735,
appsec_no_iast (1.737 ms) : 1713, 1760
. : milestone, 1737,
code_origins (1.666 ms) : 1636, 1696
. : milestone, 1666,
iast (1.51 ms) : 1485, 1535
. : milestone, 1510,
profiling (1.513 ms) : 1489, 1537
. : milestone, 1513,
tracing (1.508 ms) : 1484, 1532
. : milestone, 1508,
section candidate
no_agent (1.355 ms) : 1335, 1374
. : milestone, 1355,
appsec (1.748 ms) : 1725, 1772
. : milestone, 1748,
appsec_no_iast (1.742 ms) : 1719, 1765
. : milestone, 1742,
code_origins (1.679 ms) : 1653, 1706
. : milestone, 1679,
iast (1.503 ms) : 1478, 1527
. : milestone, 1503,
profiling (1.539 ms) : 1514, 1564
. : milestone, 1539,
tracing (1.476 ms) : 1451, 1501
. : milestone, 1476,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~eb09981fbf, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (377.01 µs) : 357, 397
. : milestone, 377,
iast (514.955 µs) : 492, 538
. : milestone, 515,
iast_FULL (727.181 µs) : 705, 749
. : milestone, 727,
iast_GLOBAL (554.684 µs) : 533, 576
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (520.678 µs) : 497, 544
. : milestone, 521,
iast_INACTIVE (464.706 µs) : 443, 486
. : milestone, 465,
iast_TELEMETRY_OFF (515.128 µs) : 492, 538
. : milestone, 515,
tracing (463.797 µs) : 441, 486
. : milestone, 464,
section candidate
no_agent (385.442 µs) : 366, 405
. : milestone, 385,
iast (528.11 µs) : 504, 552
. : milestone, 528,
iast_FULL (734.399 µs) : 713, 756
. : milestone, 734,
iast_GLOBAL (575.275 µs) : 553, 598
. : milestone, 575,
iast_HARDCODED_SECRET_DISABLED (527.042 µs) : 505, 549
. : milestone, 527,
iast_INACTIVE (466.164 µs) : 443, 489
. : milestone, 466,
iast_TELEMETRY_OFF (517.791 µs) : 495, 541
. : milestone, 518,
tracing (456.766 µs) : 436, 478
. : milestone, 457,
Dacapo |
smola
approved these changes
May 27, 2025
Member
smola
left a comment
There was a problem hiding this comment.
I guess we could have a non-privileged job to create the SBOM, upload it as an artifact, and use a separate job for the datadog-ci upload. I guess that would let the bulk of the job to be run on forks?
Still, approving to unblock.
Contributor
Contributor
Author
|
After discussing with @smola, we went with running Trivy only on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What Does This Do
Trivy check should not be required as it is failing for 3rd party contribution.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-528