-
Notifications
You must be signed in to change notification settings - Fork 322
Fixed build logic for dd-java-agent to correctly handle classes compiled with Java 6. #8899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
May 29, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 52 metrics, 13 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~3aa58001b6, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024238
Total [baseline] (8.712 s) : 0, 8712093
Agent [candidate] (1.037 s) : 0, 1037000
Total [candidate] (8.694 s) : 0, 8694121
section iast
Agent [baseline] (1.156 s) : 0, 1155637
Total [baseline] (9.235 s) : 0, 9234930
Agent [candidate] (1.151 s) : 0, 1151326
Total [candidate] (9.239 s) : 0, 9239157
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.155 s) : 0, 1155151
Total [baseline] (9.249 s) : 0, 9248984
Agent [candidate] (1.161 s) : 0, 1161381
Total [candidate] (9.247 s) : 0, 9247087
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1145547
Total [baseline] (9.205 s) : 0, 9204568
Agent [candidate] (1.15 s) : 0, 1150069
Total [candidate] (9.23 s) : 0, 9229939
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~3aa58001b6, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.516 ms) : 0, 685516
BytebuddyAgent [candidate] (694.052 ms) : 0, 694052
GlobalTracer [baseline] (240.769 ms) : 0, 240769
GlobalTracer [candidate] (244.127 ms) : 0, 244127
AppSec [baseline] (55.404 ms) : 0, 55404
AppSec [candidate] (55.937 ms) : 0, 55937
Debugger [baseline] (8.447 ms) : 0, 8447
Debugger [candidate] (6.295 ms) : 0, 6295
Remote Config [baseline] (688.524 µs) : 0, 689
Remote Config [candidate] (746.358 µs) : 0, 746
Telemetry [baseline] (9.798 ms) : 0, 9798
Telemetry [candidate] (12.119 ms) : 0, 12119
section iast
BytebuddyAgent [baseline] (807.086 ms) : 0, 807086
BytebuddyAgent [candidate] (803.42 ms) : 0, 803420
GlobalTracer [baseline] (231.45 ms) : 0, 231450
GlobalTracer [candidate] (231.595 ms) : 0, 231595
IAST [baseline] (27.857 ms) : 0, 27857
IAST [candidate] (26.135 ms) : 0, 26135
AppSec [baseline] (51.294 ms) : 0, 51294
AppSec [candidate] (52.268 ms) : 0, 52268
Debugger [baseline] (5.912 ms) : 0, 5912
Debugger [candidate] (5.885 ms) : 0, 5885
Remote Config [baseline] (584.407 µs) : 0, 584
Remote Config [candidate] (586.861 µs) : 0, 587
Telemetry [baseline] (7.855 ms) : 0, 7855
Telemetry [candidate] (7.908 ms) : 0, 7908
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.863 ms) : 0, 806863
BytebuddyAgent [candidate] (809.358 ms) : 0, 809358
GlobalTracer [baseline] (231.62 ms) : 0, 231620
GlobalTracer [candidate] (234.302 ms) : 0, 234302
IAST [baseline] (29.315 ms) : 0, 29315
IAST [candidate] (27.365 ms) : 0, 27365
AppSec [baseline] (48.577 ms) : 0, 48577
AppSec [candidate] (51.473 ms) : 0, 51473
Debugger [baseline] (5.889 ms) : 0, 5889
Debugger [candidate] (5.985 ms) : 0, 5985
Remote Config [baseline] (584.701 µs) : 0, 585
Remote Config [candidate] (589.807 µs) : 0, 590
Telemetry [baseline] (7.907 ms) : 0, 7907
Telemetry [candidate] (7.967 ms) : 0, 7967
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.484 ms) : 0, 798484
BytebuddyAgent [candidate] (801.214 ms) : 0, 801214
GlobalTracer [baseline] (230.638 ms) : 0, 230638
GlobalTracer [candidate] (232.086 ms) : 0, 232086
IAST [baseline] (22.423 ms) : 0, 22423
IAST [candidate] (28.115 ms) : 0, 28115
AppSec [baseline] (56.224 ms) : 0, 56224
AppSec [candidate] (50.719 ms) : 0, 50719
Debugger [baseline] (5.941 ms) : 0, 5941
Debugger [candidate] (5.913 ms) : 0, 5913
Remote Config [baseline] (609.703 µs) : 0, 610
Remote Config [candidate] (588.131 µs) : 0, 588
Telemetry [baseline] (7.795 ms) : 0, 7795
Telemetry [candidate] (7.829 ms) : 0, 7829
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~3aa58001b6, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029272
Total [baseline] (10.514 s) : 0, 10513588
Agent [candidate] (1.031 s) : 0, 1031419
Total [candidate] (10.497 s) : 0, 10497444
section appsec
Agent [baseline] (1.166 s) : 0, 1165615
Total [baseline] (10.73 s) : 0, 10730299
Agent [candidate] (1.165 s) : 0, 1164635
Total [candidate] (10.714 s) : 0, 10714272
section iast
Agent [baseline] (1.156 s) : 0, 1155759
Total [baseline] (10.929 s) : 0, 10928909
Agent [candidate] (1.152 s) : 0, 1151628
Total [candidate] (10.907 s) : 0, 10906595
section profiling
Agent [baseline] (1.281 s) : 0, 1280978
Total [baseline] (10.935 s) : 0, 10935296
Agent [candidate] (1.266 s) : 0, 1266441
Total [candidate] (10.898 s) : 0, 10898358
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~3aa58001b6, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.545 ms) : 0, 687545
BytebuddyAgent [candidate] (688.408 ms) : 0, 688408
GlobalTracer [baseline] (241.87 ms) : 0, 241870
GlobalTracer [candidate] (242.374 ms) : 0, 242374
AppSec [baseline] (55.632 ms) : 0, 55632
AppSec [candidate] (56.477 ms) : 0, 56477
Debugger [baseline] (9.886 ms) : 0, 9886
Debugger [candidate] (6.268 ms) : 0, 6268
Remote Config [baseline] (698.792 µs) : 0, 699
Remote Config [candidate] (755.24 µs) : 0, 755
Telemetry [baseline] (9.861 ms) : 0, 9861
Telemetry [candidate] (13.452 ms) : 0, 13452
section appsec
BytebuddyAgent [baseline] (703.397 ms) : 0, 703397
BytebuddyAgent [candidate] (701.827 ms) : 0, 701827
GlobalTracer [baseline] (237.599 ms) : 0, 237599
GlobalTracer [candidate] (238.268 ms) : 0, 238268
IAST [baseline] (21.624 ms) : 0, 21624
IAST [candidate] (21.744 ms) : 0, 21744
AppSec [baseline] (176.179 ms) : 0, 176179
AppSec [candidate] (176.208 ms) : 0, 176208
Debugger [baseline] (5.957 ms) : 0, 5957
Debugger [candidate] (5.975 ms) : 0, 5975
Remote Config [baseline] (618.739 µs) : 0, 619
Remote Config [candidate] (633.671 µs) : 0, 634
Telemetry [baseline] (7.427 ms) : 0, 7427
Telemetry [candidate] (7.267 ms) : 0, 7267
section iast
BytebuddyAgent [baseline] (807.52 ms) : 0, 807520
BytebuddyAgent [candidate] (803.157 ms) : 0, 803157
GlobalTracer [baseline] (231.173 ms) : 0, 231173
GlobalTracer [candidate] (231.901 ms) : 0, 231901
IAST [baseline] (28.422 ms) : 0, 28422
IAST [candidate] (26.971 ms) : 0, 26971
AppSec [baseline] (49.758 ms) : 0, 49758
AppSec [candidate] (51.81 ms) : 0, 51810
Debugger [baseline] (5.97 ms) : 0, 5970
Debugger [candidate] (5.879 ms) : 0, 5879
Remote Config [baseline] (598.436 µs) : 0, 598
Remote Config [candidate] (586.206 µs) : 0, 586
Telemetry [baseline] (7.923 ms) : 0, 7923
Telemetry [candidate] (7.847 ms) : 0, 7847
section profiling
BytebuddyAgent [baseline] (673.403 ms) : 0, 673403
BytebuddyAgent [candidate] (674.779 ms) : 0, 674779
GlobalTracer [baseline] (378.72 ms) : 0, 378720
GlobalTracer [candidate] (360.167 ms) : 0, 360167
AppSec [baseline] (54.584 ms) : 0, 54584
AppSec [candidate] (62.009 ms) : 0, 62009
Debugger [baseline] (6.165 ms) : 0, 6165
Debugger [candidate] (6.111 ms) : 0, 6111
Remote Config [baseline] (658.236 µs) : 0, 658
Remote Config [candidate] (654.631 µs) : 0, 655
Telemetry [baseline] (8.043 ms) : 0, 8043
Telemetry [candidate] (8.118 ms) : 0, 8118
ProfilingAgent [baseline] (108.83 ms) : 0, 108830
ProfilingAgent [candidate] (103.874 ms) : 0, 103874
Profiling [baseline] (108.855 ms) : 0, 108855
Profiling [candidate] (103.898 ms) : 0, 103898
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~3aa58001b6, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (387.404 µs) : 368, 407
. : milestone, 387,
iast (527.53 µs) : 505, 550
. : milestone, 528,
iast_FULL (740.838 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (577.025 µs) : 553, 601
. : milestone, 577,
iast_HARDCODED_SECRET_DISABLED (525.761 µs) : 504, 548
. : milestone, 526,
iast_INACTIVE (474.843 µs) : 452, 497
. : milestone, 475,
iast_TELEMETRY_OFF (525.992 µs) : 503, 549
. : milestone, 526,
tracing (466.468 µs) : 444, 489
. : milestone, 466,
section candidate
no_agent (380.764 µs) : 360, 401
. : milestone, 381,
iast (520.695 µs) : 499, 543
. : milestone, 521,
iast_FULL (744.776 µs) : 721, 768
. : milestone, 745,
iast_GLOBAL (590.456 µs) : 566, 615
. : milestone, 590,
iast_HARDCODED_SECRET_DISABLED (523.918 µs) : 502, 546
. : milestone, 524,
iast_INACTIVE (466.978 µs) : 445, 489
. : milestone, 467,
iast_TELEMETRY_OFF (516.626 µs) : 495, 538
. : milestone, 517,
tracing (470.895 µs) : 449, 493
. : milestone, 471,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~3aa58001b6, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.383 ms) : 1364, 1402
. : milestone, 1383,
appsec (1.746 ms) : 1722, 1769
. : milestone, 1746,
appsec_no_iast (1.761 ms) : 1738, 1785
. : milestone, 1761,
code_origins (1.68 ms) : 1653, 1706
. : milestone, 1680,
iast (1.531 ms) : 1506, 1557
. : milestone, 1531,
profiling (1.6 ms) : 1575, 1624
. : milestone, 1600,
tracing (1.5 ms) : 1476, 1525
. : milestone, 1500,
section candidate
no_agent (1.365 ms) : 1346, 1385
. : milestone, 1365,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.755 ms) : 1731, 1779
. : milestone, 1755,
code_origins (1.671 ms) : 1644, 1698
. : milestone, 1671,
iast (1.524 ms) : 1500, 1548
. : milestone, 1524,
profiling (1.564 ms) : 1539, 1589
. : milestone, 1564,
tracing (1.506 ms) : 1483, 1528
. : milestone, 1506,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~3aa58001b6, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (15.761 s) : 15761000, 15761000
. : milestone, 15761000,
appsec (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
iast (18.631 s) : 18631000, 18631000
. : milestone, 18631000,
iast_GLOBAL (17.99 s) : 17990000, 17990000
. : milestone, 17990000,
profiling (15.492 s) : 15492000, 15492000
. : milestone, 15492000,
tracing (15.242 s) : 15242000, 15242000
. : milestone, 15242000,
section candidate
no_agent (15.531 s) : 15531000, 15531000
. : milestone, 15531000,
appsec (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
iast (18.42 s) : 18420000, 18420000
. : milestone, 18420000,
iast_GLOBAL (17.737 s) : 17737000, 17737000
. : milestone, 17737000,
profiling (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
tracing (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~3aa58001b6, baseline=1.50.0-SNAPSHOT~ad6d5fef42
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.404 ms) : 2355, 2453
. : milestone, 2404,
iast (2.165 ms) : 2104, 2225
. : milestone, 2165,
iast_GLOBAL (2.216 ms) : 2155, 2277
. : milestone, 2216,
profiling (2.008 ms) : 1959, 2056
. : milestone, 2008,
tracing (1.999 ms) : 1952, 2046
. : milestone, 1999,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.388 ms) : 2339, 2436
. : milestone, 2388,
iast (2.166 ms) : 2105, 2227
. : milestone, 2166,
iast_GLOBAL (2.217 ms) : 2156, 2278
. : milestone, 2217,
profiling (2.017 ms) : 1969, 2066
. : milestone, 2017,
tracing (2.011 ms) : 1963, 2059
. : milestone, 2011,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixed build logic for dd-java-agent to correctly handle classes compiled with Java 6.
Motivation
Gradle's caching logic did not correctly handle the previous implementation.
Additional Notes
To test, just execute 2 times without changing any in sources:
Previous implementation worked for the first run and failed with
Exception in thread "main" java.lang.ClassNotFoundException: datadog.trace.bootstrap.AgentPreCheckon second run.Gradle's caching logic did not copy
AgentPreCheckclass from cache.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]