Skip to content

fix hibernate urls#904

Merged
mar-kolya merged 2 commits intomasterfrom
mar-kolya/fix-hibernate-urls
Jul 2, 2019
Merged

fix hibernate urls#904
mar-kolya merged 2 commits intomasterfrom
mar-kolya/fix-hibernate-urls

Conversation

@mar-kolya
Copy link
Copy Markdown
Contributor

No description provided.

mar-kolya added 2 commits July 2, 2019 10:41
Looks like old urls redirect to https with broken cert now
Using '+' pushes version of hibernate-core up as well and we do not
want thay.
@mar-kolya mar-kolya requested a review from labbati July 2, 2019 14:44
@mar-kolya mar-kolya changed the title Mar kolya/fix hibernate urls fix hibernate urls Jul 2, 2019
@mar-kolya mar-kolya marked this pull request as ready for review July 2, 2019 14:56
@mar-kolya mar-kolya requested a review from a team as a code owner July 2, 2019 14:56
Copy link
Copy Markdown
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@labbati labbati added this to the 0.31.0 milestone Jul 2, 2019
@mar-kolya mar-kolya merged commit 2afc606 into master Jul 2, 2019
@mar-kolya mar-kolya deleted the mar-kolya/fix-hibernate-urls branch July 2, 2019 15:09
Copy link
Copy Markdown
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this PR was needed? I think I'm missing something.

testCompile group: 'org.hibernate', name: 'hibernate-core', version: '3.3.0.GA'
testCompile group: 'org.hibernate', name: 'hibernate-annotations', version: '+'
testCompile group: 'org.hibernate', name: 'hibernate-core', version: '3.3.0.SP1'
testCompile group: 'org.hibernate', name: 'hibernate-annotations', version: '3.4.0.GA'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did these change?

<!DOCTYPE hibernate-configuration PUBLIC
"-//Hibernate/Hibernate Configuration DTD 3.0//EN"
"http://www.hibernate.org/dtd/hibernate-configuration-3.0.dtd">
"https://hibernate.org/dtd/hibernate-configuration-3.0.dtd">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious... why does this matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants