Skip to content

Trace 'records(TopicPartitions)` in kafka consumer#908

Merged
mar-kolya merged 1 commit into
masterfrom
mar-kolya/kafka-trace-records
Jul 8, 2019
Merged

Trace 'records(TopicPartitions)` in kafka consumer#908
mar-kolya merged 1 commit into
masterfrom
mar-kolya/kafka-trace-records

Conversation

@mar-kolya
Copy link
Copy Markdown
Contributor

Unfortunately no tests

@mar-kolya mar-kolya requested a review from a team as a code owner July 8, 2019 14:37
@mar-kolya mar-kolya force-pushed the mar-kolya/kafka-trace-records branch from 48e211b to 058c4ec Compare July 8, 2019 15:20
Copy link
Copy Markdown
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mar-kolya mar-kolya merged commit 2e62ca8 into master Jul 8, 2019
@mar-kolya mar-kolya deleted the mar-kolya/kafka-trace-records branch July 8, 2019 18:25
@tylerbenson tylerbenson added this to the 0.31.0 milestone Jul 10, 2019
@tylerbenson
Copy link
Copy Markdown
Contributor

@mar-kolya I think this is problematic. That other method returns a List, not an Iterable, so we can't safely instrument it with the same advice (since we're wrapping the return value). I think this needs to be reverted or fixed before we can release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: do not merge Do not merge changes tag: needs investigation Issues needing investigations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants