Remove version from gradle wrapper definition#919
Merged
Conversation
It doesn't look like it is doing anything useful but instead it seems to set version in resulting build jar which is not expected.
tylerbenson
approved these changes
Jul 16, 2019
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
That's prob where the odd version being submitted to bintray is coming from.
Contributor
Author
|
Sorry for originally introducing that :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't look like it is doing anything useful but instead it seems
to set version in resulting build jar which is not expected.