Better hostname detection#927
Merged
Merged
Conversation
Attempt to get hostname through environment variables and command before going to DNS
tylerbenson
approved these changes
Jul 22, 2019
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Looks good to me. Nice job. I could suggest some ways to extend testing, but it probably isn't worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to get hostname in the following way:
hostnamecommandInetAddress.getLocalHost().getHostName()(network/DNS)This method is faster, and generally more accurate (See this discussion). Although almost always the same, when the environment vars and network disagree, the environment vars are usually more correct.
Marked as a breaking change because there could be situations where environment variables and network are not the same and the user expects it to use the network hostname.
Testing
This is inherently difficult to test in an automated fashion: Windows/Mac/Linux differences; Spock in an IDE gives a different result than Spock on the command line (intellij doesn't forward environment vars). I did manually test in different environments.