-
Notifications
You must be signed in to change notification settings - Fork 316
Limit the number of verified tag vectors in CI Visibility metric tests #9905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the number of verified tag vectors in CI Visibility metric tests #9905
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 57ec2c7 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~57ec2c774e, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054131
Total [baseline] (8.644 s) : 0, 8643960
Agent [candidate] (1.047 s) : 0, 1046580
Total [candidate] (8.607 s) : 0, 8607225
section iast
Agent [baseline] (1.18 s) : 0, 1179545
Total [baseline] (9.243 s) : 0, 9242643
Agent [candidate] (1.184 s) : 0, 1184194
Total [candidate] (9.258 s) : 0, 9258378
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~57ec2c774e, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (709.343 ms) : 0, 709343
BytebuddyAgent [candidate] (704.439 ms) : 0, 704439
GlobalTracer [baseline] (247.506 ms) : 0, 247506
GlobalTracer [candidate] (246.114 ms) : 0, 246114
AppSec [baseline] (32.64 ms) : 0, 32640
AppSec [candidate] (32.129 ms) : 0, 32129
Debugger [baseline] (6.451 ms) : 0, 6451
Debugger [candidate] (6.381 ms) : 0, 6381
Remote Config [baseline] (725.67 µs) : 0, 726
Remote Config [candidate] (708.924 µs) : 0, 709
Telemetry [baseline] (12.999 ms) : 0, 12999
Telemetry [candidate] (12.761 ms) : 0, 12761
Flare Poller [baseline] (8.184 ms) : 0, 8184
Flare Poller [candidate] (7.908 ms) : 0, 7908
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (828.706 ms) : 0, 828706
BytebuddyAgent [candidate] (833.245 ms) : 0, 833245
GlobalTracer [baseline] (234.615 ms) : 0, 234615
GlobalTracer [candidate] (234.887 ms) : 0, 234887
IAST [baseline] (34.22 ms) : 0, 34220
IAST [candidate] (34.977 ms) : 0, 34977
AppSec [baseline] (26.943 ms) : 0, 26943
AppSec [candidate] (25.887 ms) : 0, 25887
Debugger [baseline] (5.974 ms) : 0, 5974
Debugger [candidate] (5.996 ms) : 0, 5996
Remote Config [baseline] (581.76 µs) : 0, 582
Remote Config [candidate] (585.02 µs) : 0, 585
Telemetry [baseline] (8.293 ms) : 0, 8293
Telemetry [candidate] (8.208 ms) : 0, 8208
Flare Poller [baseline] (4.127 ms) : 0, 4127
Flare Poller [candidate] (4.088 ms) : 0, 4088
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~57ec2c774e, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045582
Total [baseline] (10.668 s) : 0, 10668452
Agent [candidate] (1.046 s) : 0, 1045962
Total [candidate] (10.794 s) : 0, 10793910
section appsec
Agent [baseline] (1.23 s) : 0, 1229661
Total [baseline] (10.809 s) : 0, 10809384
Agent [candidate] (1.218 s) : 0, 1217954
Total [candidate] (10.906 s) : 0, 10906138
section iast
Agent [baseline] (1.196 s) : 0, 1195783
Total [baseline] (11.239 s) : 0, 11238529
Agent [candidate] (1.185 s) : 0, 1184727
Total [candidate] (11.105 s) : 0, 11105402
section profiling
Agent [baseline] (1.188 s) : 0, 1188468
Total [baseline] (10.896 s) : 0, 10896479
Agent [candidate] (1.198 s) : 0, 1198301
Total [candidate] (10.945 s) : 0, 10945246
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~57ec2c774e, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (703.366 ms) : 0, 703366
BytebuddyAgent [candidate] (704.079 ms) : 0, 704079
GlobalTracer [baseline] (245.819 ms) : 0, 245819
GlobalTracer [candidate] (245.975 ms) : 0, 245975
AppSec [baseline] (32.299 ms) : 0, 32299
AppSec [candidate] (32.253 ms) : 0, 32253
Debugger [baseline] (6.382 ms) : 0, 6382
Debugger [candidate] (6.37 ms) : 0, 6370
Remote Config [baseline] (710.152 µs) : 0, 710
Remote Config [candidate] (710.199 µs) : 0, 710
Telemetry [baseline] (15.055 ms) : 0, 15055
Telemetry [candidate] (14.88 ms) : 0, 14880
Flare Poller [baseline] (5.791 ms) : 0, 5791
Flare Poller [candidate] (5.674 ms) : 0, 5674
section appsec
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (734.979 ms) : 0, 734979
BytebuddyAgent [candidate] (726.901 ms) : 0, 726901
GlobalTracer [baseline] (239.116 ms) : 0, 239116
GlobalTracer [candidate] (236.74 ms) : 0, 236740
IAST [baseline] (25.053 ms) : 0, 25053
IAST [candidate] (24.692 ms) : 0, 24692
AppSec [baseline] (174.777 ms) : 0, 174777
AppSec [candidate] (174.281 ms) : 0, 174281
Debugger [baseline] (6.002 ms) : 0, 6002
Debugger [candidate] (6.005 ms) : 0, 6005
Remote Config [baseline] (654.844 µs) : 0, 655
Remote Config [candidate] (646.741 µs) : 0, 647
Telemetry [baseline] (8.588 ms) : 0, 8588
Telemetry [candidate] (8.574 ms) : 0, 8574
Flare Poller [baseline] (4.044 ms) : 0, 4044
Flare Poller [candidate] (3.94 ms) : 0, 3940
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (842.188 ms) : 0, 842188
BytebuddyAgent [candidate] (832.668 ms) : 0, 832668
GlobalTracer [baseline] (235.75 ms) : 0, 235750
GlobalTracer [candidate] (235.479 ms) : 0, 235479
IAST [baseline] (32.883 ms) : 0, 32883
IAST [candidate] (33.549 ms) : 0, 33549
AppSec [baseline] (29.037 ms) : 0, 29037
AppSec [candidate] (27.761 ms) : 0, 27761
Debugger [baseline] (6.096 ms) : 0, 6096
Debugger [candidate] (6.018 ms) : 0, 6018
Remote Config [baseline] (601.355 µs) : 0, 601
Remote Config [candidate] (592.666 µs) : 0, 593
Telemetry [baseline] (8.558 ms) : 0, 8558
Telemetry [candidate] (8.368 ms) : 0, 8368
Flare Poller [baseline] (4.139 ms) : 0, 4139
Flare Poller [candidate] (4.105 ms) : 0, 4105
section profiling
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (727.425 ms) : 0, 727425
BytebuddyAgent [candidate] (733.743 ms) : 0, 733743
GlobalTracer [baseline] (221.103 ms) : 0, 221103
GlobalTracer [candidate] (222.803 ms) : 0, 222803
AppSec [baseline] (31.801 ms) : 0, 31801
AppSec [candidate] (32.243 ms) : 0, 32243
Debugger [baseline] (8.329 ms) : 0, 8329
Debugger [candidate] (7.657 ms) : 0, 7657
Remote Config [baseline] (672.771 µs) : 0, 673
Remote Config [candidate] (675.126 µs) : 0, 675
Telemetry [baseline] (14.35 ms) : 0, 14350
Telemetry [candidate] (14.498 ms) : 0, 14498
Flare Poller [baseline] (4.088 ms) : 0, 4088
Flare Poller [candidate] (4.157 ms) : 0, 4157
ProfilingAgent [baseline] (110.246 ms) : 0, 110246
ProfilingAgent [candidate] (110.819 ms) : 0, 110819
Profiling [baseline] (110.888 ms) : 0, 110888
Profiling [candidate] (111.507 ms) : 0, 111507
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~57ec2c774e, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (1.224 ms) : 1212, 1236
. : milestone, 1224,
iast (3.082 ms) : 3047, 3118
. : milestone, 3082,
iast_FULL (5.874 ms) : 5815, 5933
. : milestone, 5874,
iast_GLOBAL (3.629 ms) : 3576, 3682
. : milestone, 3629,
profiling (2.105 ms) : 2085, 2126
. : milestone, 2105,
tracing (1.81 ms) : 1795, 1825
. : milestone, 1810,
section candidate
no_agent (1.223 ms) : 1210, 1235
. : milestone, 1223,
iast (3.277 ms) : 3231, 3323
. : milestone, 3277,
iast_FULL (5.83 ms) : 5772, 5889
. : milestone, 5830,
iast_GLOBAL (3.687 ms) : 3632, 3742
. : milestone, 3687,
profiling (1.952 ms) : 1936, 1969
. : milestone, 1952,
tracing (1.861 ms) : 1843, 1879
. : milestone, 1861,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~57ec2c774e, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (18.073 ms) : 17885, 18260
. : milestone, 18073,
appsec (18.905 ms) : 18711, 19098
. : milestone, 18905,
code_origins (17.591 ms) : 17416, 17766
. : milestone, 17591,
iast (17.616 ms) : 17439, 17792
. : milestone, 17616,
profiling (18.473 ms) : 18290, 18656
. : milestone, 18473,
tracing (17.594 ms) : 17419, 17768
. : milestone, 17594,
section candidate
no_agent (18.502 ms) : 18307, 18697
. : milestone, 18502,
appsec (18.572 ms) : 18381, 18763
. : milestone, 18572,
code_origins (17.994 ms) : 17815, 18173
. : milestone, 17994,
iast (18.595 ms) : 18404, 18785
. : milestone, 18595,
profiling (19.562 ms) : 19364, 19760
. : milestone, 19562,
tracing (17.546 ms) : 17370, 17721
. : milestone, 17546,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~57ec2c774e, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
appsec (15.162 s) : 15162000, 15162000
. : milestone, 15162000,
iast (18.536 s) : 18536000, 18536000
. : milestone, 18536000,
iast_GLOBAL (18.261 s) : 18261000, 18261000
. : milestone, 18261000,
profiling (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
tracing (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
section candidate
no_agent (15.398 s) : 15398000, 15398000
. : milestone, 15398000,
appsec (15.5 s) : 15500000, 15500000
. : milestone, 15500000,
iast (18.457 s) : 18457000, 18457000
. : milestone, 18457000,
iast_GLOBAL (17.973 s) : 17973000, 17973000
. : milestone, 17973000,
profiling (15.172 s) : 15172000, 15172000
. : milestone, 15172000,
tracing (15.194 s) : 15194000, 15194000
. : milestone, 15194000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~57ec2c774e, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.451 ms) : 2400, 2502
. : milestone, 2451,
iast (2.209 ms) : 2145, 2272
. : milestone, 2209,
iast_GLOBAL (2.248 ms) : 2184, 2312
. : milestone, 2248,
profiling (2.493 ms) : 2324, 2662
. : milestone, 2493,
tracing (2.023 ms) : 1973, 2072
. : milestone, 2023,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.684 ms) : 3467, 3901
. : milestone, 3684,
iast (2.21 ms) : 2146, 2273
. : milestone, 2210,
iast_GLOBAL (2.258 ms) : 2193, 2322
. : milestone, 2258,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.027 ms) : 1978, 2077
. : milestone, 2027,
|
What Does This Do
Updates
datadog.trace.civisibility.telemetry.CiVisibilityMetricCollectorTestto limit the number of tested metric/tags pairs.Motivation
The test is verifying all the possible metric/tag pairs, which is redundant. As the number of metrics grew over time, the test execution time increased non-linearly. It now takes more than 10 minutes to run.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]