Skip to content

Limit the number of verified tag vectors in CI Visibility metric tests #9905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
+4 −4
Merged

Limit the number of verified tag vectors in CI Visibility metric tests #9905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...c/test/groovy/datadog/trace/civisibility/telemetry/CiVisibilityMetricCollectorTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,18 +149,18 @@ class CiVisibilityMetricCollectorTest extends Specification {
}

/**
* This test enumerates all possible metric+tags variants,
* then tries submitting all possible variant pairs (combinations of 2 different metric+tags).
* This test enumerates a few different tag combinations for every metric,
* then submits a metric count for each one.
* The goal is to ensure that index calculation logic and card-marking are done right.
*/
def "test submission of all possible count metric pairs"() {
def "test submission of different count metric pairs"() {
setup:
List<PossibleMetric> possibleMetrics = []

for (CiVisibilityCountMetric metric : CiVisibilityCountMetric.values()) {
def metricTags = metric.getTags()

int cartesianProductSizeLimit = 2000 // limiting the number of combinations to avoid OOM/timeout
int cartesianProductSizeLimit = 20 // limiting the number of combinations to avoid OOM/timeout
for (TagValue[] tags : cartesianProduct(metricTags, cartesianProductSizeLimit)) { // iterate over combinations of metric tags
possibleMetrics += new PossibleMetric(metric, tags)
}
Expand Down