-
Notifications
You must be signed in to change notification settings - Fork 319
Add more information for timeout messages #9999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~e163ecf06e, baseline=1.56.0-SNAPSHOT~f4668ed591
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.107 s) : 0, 1106882
Total [baseline] (10.857 s) : 0, 10856922
Agent [candidate] (1.11 s) : 0, 1110230
Total [candidate] (10.863 s) : 0, 10863268
section appsec
Agent [baseline] (1.281 s) : 0, 1281149
Total [baseline] (11.042 s) : 0, 11042490
Agent [candidate] (1.279 s) : 0, 1279126
Total [candidate] (11.001 s) : 0, 11000573
section iast
Agent [baseline] (1.238 s) : 0, 1237551
Total [baseline] (11.252 s) : 0, 11252463
Agent [candidate] (1.237 s) : 0, 1237388
Total [candidate] (11.261 s) : 0, 11260520
section profiling
Agent [baseline] (1.23 s) : 0, 1229970
Total [baseline] (11.052 s) : 0, 11052279
Agent [candidate] (1.234 s) : 0, 1233543
Total [candidate] (11.082 s) : 0, 11082277
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~e163ecf06e, baseline=1.56.0-SNAPSHOT~f4668ed591
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (708.265 ms) : 0, 708265
BytebuddyAgent [candidate] (711.644 ms) : 0, 711644
GlobalTracer [baseline] (250.939 ms) : 0, 250939
GlobalTracer [candidate] (251.117 ms) : 0, 251117
AppSec [baseline] (32.784 ms) : 0, 32784
AppSec [candidate] (32.732 ms) : 0, 32732
Debugger [baseline] (65.452 ms) : 0, 65452
Debugger [candidate] (65.375 ms) : 0, 65375
Remote Config [baseline] (647.061 µs) : 0, 647
Remote Config [candidate] (647.202 µs) : 0, 647
Telemetry [baseline] (8.41 ms) : 0, 8410
Telemetry [candidate] (8.343 ms) : 0, 8343
Flare Poller [baseline] (3.787 ms) : 0, 3787
Flare Poller [candidate] (3.784 ms) : 0, 3784
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (729.996 ms) : 0, 729996
BytebuddyAgent [candidate] (729.992 ms) : 0, 729992
GlobalTracer [baseline] (241.973 ms) : 0, 241973
GlobalTracer [candidate] (240.715 ms) : 0, 240715
AppSec [baseline] (174.475 ms) : 0, 174475
AppSec [candidate] (173.961 ms) : 0, 173961
Debugger [baseline] (60.515 ms) : 0, 60515
Debugger [candidate] (60.489 ms) : 0, 60489
Remote Config [baseline] (642.671 µs) : 0, 643
Remote Config [candidate] (700.738 µs) : 0, 701
Telemetry [baseline] (8.147 ms) : 0, 8147
Telemetry [candidate] (8.182 ms) : 0, 8182
Flare Poller [baseline] (3.812 ms) : 0, 3812
Flare Poller [candidate] (3.786 ms) : 0, 3786
IAST [baseline] (25.038 ms) : 0, 25038
IAST [candidate] (24.822 ms) : 0, 24822
section iast
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (828.957 ms) : 0, 828957
BytebuddyAgent [candidate] (828.652 ms) : 0, 828652
GlobalTracer [baseline] (237.992 ms) : 0, 237992
GlobalTracer [candidate] (237.861 ms) : 0, 237861
AppSec [baseline] (31.369 ms) : 0, 31369
AppSec [candidate] (35.008 ms) : 0, 35008
Debugger [baseline] (60.956 ms) : 0, 60956
Debugger [candidate] (61.135 ms) : 0, 61135
Remote Config [baseline] (554.326 µs) : 0, 554
Remote Config [candidate] (555.038 µs) : 0, 555
Telemetry [baseline] (7.675 ms) : 0, 7675
Telemetry [candidate] (7.725 ms) : 0, 7725
Flare Poller [baseline] (3.506 ms) : 0, 3506
Flare Poller [candidate] (3.521 ms) : 0, 3521
IAST [baseline] (30.095 ms) : 0, 30095
IAST [candidate] (26.51 ms) : 0, 26510
section profiling
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (731.983 ms) : 0, 731983
BytebuddyAgent [candidate] (734.172 ms) : 0, 734172
GlobalTracer [baseline] (221.873 ms) : 0, 221873
GlobalTracer [candidate] (222.484 ms) : 0, 222484
AppSec [baseline] (32.058 ms) : 0, 32058
AppSec [candidate] (32.127 ms) : 0, 32127
Debugger [baseline] (62.87 ms) : 0, 62870
Debugger [candidate] (63.15 ms) : 0, 63150
Remote Config [baseline] (637.791 µs) : 0, 638
Remote Config [candidate] (649.79 µs) : 0, 650
Telemetry [baseline] (7.995 ms) : 0, 7995
Telemetry [candidate] (8.105 ms) : 0, 8105
Flare Poller [baseline] (3.798 ms) : 0, 3798
Flare Poller [candidate] (3.768 ms) : 0, 3768
ProfilingAgent [baseline] (97.488 ms) : 0, 97488
ProfilingAgent [candidate] (97.471 ms) : 0, 97471
Profiling [baseline] (98.074 ms) : 0, 98074
Profiling [candidate] (98.068 ms) : 0, 98068
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~e163ecf06e, baseline=1.56.0-SNAPSHOT~f4668ed591
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1102876
Total [baseline] (8.89 s) : 0, 8889917
Agent [candidate] (1.105 s) : 0, 1104667
Total [candidate] (8.89 s) : 0, 8890284
section iast
Agent [baseline] (1.237 s) : 0, 1237225
Total [baseline] (9.584 s) : 0, 9584397
Agent [candidate] (1.233 s) : 0, 1232973
Total [candidate] (9.521 s) : 0, 9520690
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~e163ecf06e, baseline=1.56.0-SNAPSHOT~f4668ed591
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (708.686 ms) : 0, 708686
BytebuddyAgent [candidate] (709.752 ms) : 0, 709752
GlobalTracer [baseline] (248.783 ms) : 0, 248783
GlobalTracer [candidate] (250.36 ms) : 0, 250360
AppSec [baseline] (32.4 ms) : 0, 32400
AppSec [candidate] (32.274 ms) : 0, 32274
Debugger [baseline] (63.891 ms) : 0, 63891
Debugger [candidate] (63.354 ms) : 0, 63354
Remote Config [baseline] (647.965 µs) : 0, 648
Remote Config [candidate] (631.043 µs) : 0, 631
Telemetry [baseline] (8.239 ms) : 0, 8239
Telemetry [candidate] (8.167 ms) : 0, 8167
Flare Poller [baseline] (3.712 ms) : 0, 3712
Flare Poller [candidate] (3.685 ms) : 0, 3685
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (829.458 ms) : 0, 829458
BytebuddyAgent [candidate] (825.936 ms) : 0, 825936
GlobalTracer [baseline] (238.333 ms) : 0, 238333
GlobalTracer [candidate] (237.648 ms) : 0, 237648
AppSec [baseline] (33.196 ms) : 0, 33196
AppSec [candidate] (32.453 ms) : 0, 32453
Debugger [baseline] (59.807 ms) : 0, 59807
Debugger [candidate] (60.093 ms) : 0, 60093
Remote Config [baseline] (544.885 µs) : 0, 545
Remote Config [candidate] (546.459 µs) : 0, 546
Telemetry [baseline] (7.66 ms) : 0, 7660
Telemetry [candidate] (7.626 ms) : 0, 7626
Flare Poller [baseline] (3.448 ms) : 0, 3448
Flare Poller [candidate] (3.431 ms) : 0, 3431
IAST [baseline] (28.463 ms) : 0, 28463
IAST [candidate] (28.901 ms) : 0, 28901
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~e163ecf06e, baseline=1.56.0-SNAPSHOT~f4668ed591
dateFormat X
axisFormat %s
section baseline
no_agent (19.234 ms) : 19035, 19432
. : milestone, 19234,
appsec (18.442 ms) : 18255, 18629
. : milestone, 18442,
code_origins (17.896 ms) : 17717, 18076
. : milestone, 17896,
iast (17.633 ms) : 17457, 17810
. : milestone, 17633,
profiling (20.81 ms) : 20602, 21019
. : milestone, 20810,
tracing (17.425 ms) : 17253, 17597
. : milestone, 17425,
section candidate
no_agent (19.085 ms) : 18890, 19280
. : milestone, 19085,
appsec (18.836 ms) : 18645, 19028
. : milestone, 18836,
code_origins (17.767 ms) : 17592, 17942
. : milestone, 17767,
iast (17.614 ms) : 17440, 17788
. : milestone, 17614,
profiling (19.602 ms) : 19405, 19799
. : milestone, 19602,
tracing (17.674 ms) : 17496, 17852
. : milestone, 17674,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~e163ecf06e, baseline=1.56.0-SNAPSHOT~f4668ed591
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1169, 1191
. : milestone, 1180,
iast (3.402 ms) : 3366, 3437
. : milestone, 3402,
iast_FULL (5.87 ms) : 5785, 5954
. : milestone, 5870,
iast_GLOBAL (3.536 ms) : 3482, 3589
. : milestone, 3536,
profiling (2.071 ms) : 2053, 2089
. : milestone, 2071,
tracing (1.82 ms) : 1805, 1835
. : milestone, 1820,
section candidate
no_agent (1.2 ms) : 1188, 1211
. : milestone, 1200,
iast (3.241 ms) : 3194, 3288
. : milestone, 3241,
iast_FULL (5.928 ms) : 5869, 5988
. : milestone, 5928,
iast_GLOBAL (3.458 ms) : 3407, 3509
. : milestone, 3458,
profiling (2.283 ms) : 2261, 2306
. : milestone, 2283,
tracing (1.841 ms) : 1825, 1856
. : milestone, 1841,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~e163ecf06e, baseline=1.56.0-SNAPSHOT~f4668ed591
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.449 ms) : 2399, 2500
. : milestone, 2449,
iast (2.209 ms) : 2145, 2273
. : milestone, 2209,
iast_GLOBAL (2.237 ms) : 2174, 2301
. : milestone, 2237,
profiling (2.474 ms) : 2315, 2633
. : milestone, 2474,
tracing (2.028 ms) : 1978, 2077
. : milestone, 2028,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.454 ms) : 2404, 2505
. : milestone, 2454,
iast (2.201 ms) : 2137, 2264
. : milestone, 2201,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.054 ms) : 2003, 2105
. : milestone, 2054,
tracing (2.024 ms) : 1975, 2073
. : milestone, 2024,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~e163ecf06e, baseline=1.56.0-SNAPSHOT~f4668ed591
dateFormat X
axisFormat %s
section baseline
no_agent (15.594 s) : 15594000, 15594000
. : milestone, 15594000,
appsec (14.731 s) : 14731000, 14731000
. : milestone, 14731000,
iast (18.328 s) : 18328000, 18328000
. : milestone, 18328000,
iast_GLOBAL (18.139 s) : 18139000, 18139000
. : milestone, 18139000,
profiling (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
tracing (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
section candidate
no_agent (15.108 s) : 15108000, 15108000
. : milestone, 15108000,
appsec (14.72 s) : 14720000, 14720000
. : milestone, 14720000,
iast (18.482 s) : 18482000, 18482000
. : milestone, 18482000,
iast_GLOBAL (17.979 s) : 17979000, 17979000
. : milestone, 17979000,
profiling (14.699 s) : 14699000, 14699000
. : milestone, 14699000,
tracing (14.766 s) : 14766000, 14766000
. : milestone, 14766000,
|
use @NonRetryable annotation on Exception Replay smoke tests to keep logs intact for troubleshooting
0d291fb to
3d4ad19
Compare
bric3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the retry mechanism filter. However, I skipped the other changes in processRequests
utils/test-utils/src/main/groovy/datadog/trace/test/util/NonRetryable.java
Outdated
Show resolved
Hide resolved
…tryable.java Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
|
🎯 Code Coverage 🔗 Commit SHA: e163ecf | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
* Add more information for timeout messages * Add NonRetryable annotation use @NonRetryable annotation on Exception Replay smoke tests to keep logs intact for troubleshooting
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]