Skip to content

[ci-visibility] Change git upload to opt out - #2829

Merged
juan-fernandez merged 2 commits into
masterfrom
juan-fernandez/change-git-upload-default
Feb 23, 2023
Merged

[ci-visibility] Change git upload to opt out#2829
juan-fernandez merged 2 commits into
masterfrom
juan-fernandez/change-git-upload-default

Conversation

@juan-fernandez

Copy link
Copy Markdown
Collaborator

What does this PR do?

Change DD_CIVISIBILITY_GIT_UPLOAD_ENABLED's default value to true, so that git upload becomes an opt out feature rather than opt in.

Motivation

Git tree information is necessary for intelligent test runner and will become necessary for other CI Visibility features.

@github-actions

github-actions Bot commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 3.81 MB
Deduped: 57.31 MB
No deduping: 63.91 MB

Dependency sizes

name version self size total size
@datadog/pprof 1.1.1 10.9 MB 17.75 MB
@datadog/native-iast-taint-tracking 1.1.0 13.38 MB 13.39 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 1.1.2 2.06 MB 2.08 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Feb 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2829 (e8ceef9) into master (9c54395) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2829   +/-   ##
=======================================
  Coverage   89.30%   89.30%           
=======================================
  Files         317      317           
  Lines       11252    11252           
  Branches       33       33           
=======================================
  Hits        10049    10049           
  Misses       1203     1203           
Impacted Files Coverage Δ
packages/dd-trace/src/config.js 98.20% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter

pr-commenter Bot commented Feb 21, 2023

Copy link
Copy Markdown

Benchmarks

Comparing candidate commit e8ceef9 in PR branch juan-fernandez/change-git-upload-default with baseline commit 9c54395 in branch master.

Found 4 performance improvements and 12 performance regressions! Performance is the same for 926 cases.

scenario:appsec-control-16

  • 🟥 cpu_usage_percentage [+2.149%; +3.264%]
  • 🟥 cpu_user_time [+6.459ms; +11.628ms] or [+2.409%; +4.337%]

scenario:spans-finish-immediately-16

  • 🟩 execution_time [-12.633ms; -7.502ms] or [-3.018%; -1.792%]

scenario:plugin-http-client-with-tracer-16

  • 🟥 cpu_system_time [+2.746ms; +19.685ms] or [+2.545%; +18.248%]

scenario:exporting-pipeline-0.4-16

  • 🟩 cpu_system_time [-6.611ms; -0.888ms] or [-15.269%; -2.052%]

scenario:appsec-control-with-attacks-16

  • 🟥 cpu_user_time [+6.228ms; +11.890ms] or [+2.312%; +4.413%]
  • 🟥 max_rss_usage [+0.771KB; +0.830KB] or [+1.512%; +1.627%]

scenario:plugin-http-server-with-tracer-16

  • 🟥 cpu_system_time [+1.780ms; +14.719ms] or [+2.542%; +21.023%]

scenario:log-with-error-16

  • 🟥 cpu_system_time [+0.401ms; +3.374ms] or [+2.005%; +16.875%]

scenario:net-with-tracer-16

  • 🟩 instructions [-11515118; -10680828] or [-1.704%; -1.581%]

scenario:appsec-appsec-enabled-18

  • 🟥 cpu_user_time [+7.429ms; +14.178ms] or [+2.162%; +4.127%]
  • 🟥 execution_time [+7.388ms; +9.388ms] or [+1.883%; +2.393%]

scenario:encoders-0.4-18

  • 🟥 max_rss_usage [+5.998KB; +6.128KB] or [+2.960%; +3.025%]

scenario:scope-manager-async_local_storage-18

  • 🟩 cpu_system_time [-11.210ms; -1.811ms] or [-44.558%; -7.200%]

scenario:appsec-appsec-enabled-with-attacks-18

  • 🟥 cpu_user_time [+7.388ms; +13.785ms] or [+2.106%; +3.930%]
  • 🟥 execution_time [+8.992ms; +10.884ms] or [+2.256%; +2.730%]

@juan-fernandez
juan-fernandez marked this pull request as ready for review February 21, 2023 10:39
@juan-fernandez
juan-fernandez requested a review from a team as a code owner February 21, 2023 10:39
@juan-fernandez
juan-fernandez merged commit 30d47d8 into master Feb 23, 2023
@juan-fernandez
juan-fernandez deleted the juan-fernandez/change-git-upload-default branch February 23, 2023 09:25
@CarlesDD CarlesDD mentioned this pull request Mar 2, 2023
@CarlesDD CarlesDD mentioned this pull request Mar 2, 2023
@CarlesDD CarlesDD mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants