Skip to content

Remove old fields from Instrumentation Telemetry Metrics - #3367

Merged
ida613 merged 1 commit into
masterfrom
remove-old-itel-metrics-fields
Sep 12, 2023
Merged

Remove old fields from Instrumentation Telemetry Metrics#3367
ida613 merged 1 commit into
masterfrom
remove-old-itel-metrics-fields

Conversation

@Qard

@Qard Qard commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes lib_language and lib_version from instrumentation telemetry metrics tags.

Motivation

The v2 spec of instrumentation telemetry has removed these tags from metrics data objects as the data is already present in headers and can be copied into every record together rather than duplicating data.

@Qard
Qard requested a review from a team as a code owner July 7, 2023 01:26
@github-actions

github-actions Bot commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 4.93 MB
Deduped: 58.03 MB
No deduping: 58.12 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@Qard
Qard force-pushed the remove-old-itel-metrics-fields branch from 94f8fb4 to c6554c5 Compare July 7, 2023 01:28
@codecov

codecov Bot commented Jul 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #3367 (5e2ea52) into master (1c14fe8) will increase coverage by 0.00%.
Report is 78 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3367   +/-   ##
=======================================
  Coverage   84.66%   84.67%           
=======================================
  Files         218      218           
  Lines        8583     8580    -3     
  Branches       33       33           
=======================================
- Hits         7267     7265    -2     
+ Misses       1316     1315    -1     
Files Changed Coverage Δ
packages/dd-trace/src/telemetry/metrics.js 94.44% <ø> (+0.89%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter

pr-commenter Bot commented Jul 7, 2023

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2023-07-26 19:08:55

Comparing candidate commit 5e2ea52 in PR branch remove-old-itel-metrics-fields with baseline commit 1c14fe8 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 465 metrics, 24 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟥 max_rss_usage [+120.184KB; +163.496KB] or [+14.604%; +19.866%]

scenario:plugin-graphql-with-depth-off-18

  • 🟥 max_rss_usage [+127.189KB; +158.203KB] or [+15.488%; +19.264%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟥 max_rss_usage [+108.984KB; +169.112KB] or [+13.208%; +20.495%]

@Qard
Qard force-pushed the remove-old-itel-metrics-fields branch 2 times, most recently from 239d4ea to ef4e5b8 Compare July 12, 2023 18:06
@Qard
Qard force-pushed the remove-old-itel-metrics-fields branch 2 times, most recently from eecdf00 to 228c521 Compare July 24, 2023 20:19
@Qard
Qard force-pushed the remove-old-itel-metrics-fields branch from 228c521 to 5e2ea52 Compare July 26, 2023 19:01
@ida613
ida613 merged commit e7239dd into master Sep 12, 2023
@Qard
Qard deleted the remove-old-itel-metrics-fields branch September 20, 2023 18:08
@khanayan123 khanayan123 mentioned this pull request Sep 26, 2023
@khanayan123 khanayan123 mentioned this pull request Sep 26, 2023
@Qard

Qard commented Sep 26, 2023

Copy link
Copy Markdown
Contributor Author

@ida613 I just noticed this was landed on master already. These changes were for Instrumentation Telemetry v2 so they should not land until the rest of that as this will break compatibility with v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants