Remove old fields from Instrumentation Telemetry Metrics - #3367
Conversation
Overall package sizeSelf size: 4.93 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
94f8fb4 to
c6554c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #3367 +/- ##
=======================================
Coverage 84.66% 84.67%
=======================================
Files 218 218
Lines 8583 8580 -3
Branches 33 33
=======================================
- Hits 7267 7265 -2
+ Misses 1316 1315 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-07-26 19:08:55 Comparing candidate commit 5e2ea52 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 465 metrics, 24 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
239d4ea to
ef4e5b8
Compare
eecdf00 to
228c521
Compare
228c521 to
5e2ea52
Compare
|
@ida613 I just noticed this was landed on master already. These changes were for Instrumentation Telemetry v2 so they should not land until the rest of that as this will break compatibility with v1. |
What does this PR do?
Removes
lib_languageandlib_versionfrom instrumentation telemetry metrics tags.Motivation
The v2 spec of instrumentation telemetry has removed these tags from metrics data objects as the data is already present in headers and can be copied into every record together rather than duplicating data.