Skip to content

fix error in pg plugin when using pg without pg-native - #526

Merged
rochdev merged 1 commit into
masterfrom
fix-pg-native-error
Apr 8, 2019
Merged

fix error in pg plugin when using pg without pg-native#526
rochdev merged 1 commit into
masterfrom
fix-pg-native-error

Conversation

@rochdev

@rochdev rochdev commented Apr 8, 2019

Copy link
Copy Markdown
Member

This PR fixes an error being logged when using pg without pg-native since the plugin would always attempt to patch the native version. The plugin will now only patch pg-native when the native files are required, which is the expected behavior.

Fixes #522

@rochdev rochdev added bug Something isn't working integrations labels Apr 8, 2019
@rochdev rochdev added this to the 0.10.4 milestone Apr 8, 2019
@rochdev
rochdev requested a review from brettlangdon April 8, 2019 17:44

@brettlangdon brettlangdon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rochdev
rochdev merged commit 672a7cf into master Apr 8, 2019
@rochdev
rochdev deleted the fix-pg-native-error branch April 8, 2019 18:40
@kevinburkenotion

Copy link
Copy Markdown

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

console log triggered if pg-native not installed - "Cannot find module 'pg-native'"

3 participants