fix(id): drop redundant tags optional chaining in agentless exporter/encoder - #9610
Merged
litianningdatadog merged 1 commit intoAug 3, 2026
Conversation
Contributor
Overall package sizeSelf size: 7.77 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.3 | 125.43 kB | 441.68 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 51f00d9 | Docs | Datadog PR Page | Give us feedback! |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The removed optional chaining is safe on the reviewed production paths: tracer configuration always materializes the tags object, DogStatsD always receives the generated tag array, and both CI writers pass the live tags object. Valid and empty-tag adversarial scenarios preserved metadata and metric output. No additional tests recommended: existing tests already cover the affected branches and the production-shaped inputs.
📊 Validated against 8 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit ceb03fb · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
Contributor
There was a problem hiding this comment.
Pull request overview
Removes redundant optional chaining around tags access in agentless exporters/encoders and DogStatsD, aligning the code with the invariant that tracer config initializes tags (and DogStatsD client config initializes tags as an array) before these code paths run.
Changes:
- Agentless APM exporter now reads
runtime-iddirectly fromconfig.tags['runtime-id']and updates the JSDoc contract forconfig.tags. - Agentless CI Visibility encoder reads
envandruntime-iddirectly fromthis.tags(non-optional) and updates a unit test to passtags: {}. - DogStatsD client now builds
#tagsPrefixusingthis.#tags.length(non-optional) in both constructor andupdateTags().
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/dd-trace/test/encode/agentless-ci-visibility.spec.js | Updates test setup to pass a realistic { tags: {} } config shape to the encoder. |
| packages/dd-trace/src/exporters/agentless/index.js | Removes optional chaining on config.tags when reading runtime-id and tightens the documented config contract. |
| packages/dd-trace/src/encode/agentless-ci-visibility.js | Removes optional chaining on this.tags for env/runtime-id emission in payload metadata. |
| packages/dd-trace/src/dogstatsd.js | Removes optional chaining on the internal #tags array when computing the cached tag prefix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## tianning.li/dd-trace-microvm-identity-refresh-option-b #9610 +/- ##
==========================================================================================
+ Coverage 97.38% 98.53% +1.15%
==========================================================================================
Files 955 955
Lines 133754 133754
Branches 10982 11721 +739
==========================================================================================
+ Hits 130250 131801 +1551
+ Misses 3504 1953 -1551 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BridgeAR
approved these changes
Jul 30, 2026
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
July 31, 2026 14:59
03a2c2a to
b93ba51
Compare
litianningdatadog
requested review from
khanayan123
and removed request for
a team
July 31, 2026 14:59
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
from
July 31, 2026 15:04
ceb03fb to
51fee3e
Compare
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
July 31, 2026 15:16
b93ba51 to
42fb068
Compare
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
from
July 31, 2026 15:17
51fee3e to
74187cb
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74187cb70a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
July 31, 2026 15:35
42fb068 to
60f47c6
Compare
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
2 times, most recently
from
July 31, 2026 18:47
670aa21 to
a42c365
Compare
BenchmarksBenchmark execution time: 2026-08-03 20:34:32 Comparing candidate commit 51f00d9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2330 metrics, 28 unstable metrics.
|
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
from
July 31, 2026 23:32
a42c365 to
0db171f
Compare
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
July 31, 2026 23:57
9a30816 to
986d2e2
Compare
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
from
July 31, 2026 23:57
0db171f to
9bf2cd7
Compare
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
August 1, 2026 00:11
986d2e2 to
4d60483
Compare
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
from
August 1, 2026 00:12
9bf2cd7 to
ce322a2
Compare
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
August 1, 2026 00:39
4d60483 to
7714864
Compare
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
from
August 1, 2026 00:40
ce322a2 to
cacbefe
Compare
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
August 1, 2026 00:57
7714864 to
df2c5cc
Compare
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
2 times, most recently
from
August 3, 2026 16:42
4e03431 to
cdf643d
Compare
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
August 3, 2026 18:14
c1717a5 to
ff4f1f5
Compare
litianningdatadog
requested review from
crysmags
and removed request for
a team
August 3, 2026 18:14
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
from
August 3, 2026 18:14
cdf643d to
a7dc32f
Compare
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
August 3, 2026 18:41
ff4f1f5 to
1b0e671
Compare
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
from
August 3, 2026 18:42
a7dc32f to
0338ffa
Compare
litianningdatadog
force-pushed
the
tianning.li/dd-trace-microvm-identity-refresh-option-b
branch
from
August 3, 2026 20:20
1b0e671 to
3effe66
Compare
…encoder
config.tags is always an object by the time these run - Config#applyDefaults
seeds it from DD_TAGS's default (parsed to {} for an empty string) before any
other config logic, and every production caller of these constructors passes
config.tags straight through. Addresses BridgeAR's "tags will always be an
object" review comments on #9355 for exporters/agentless/index.js and
encode/agentless-ci-visibility.js.
Also drops the same redundant `?.` on DogStatsDClient's #tags, which is
always populated via generateClientConfig()/buildClientConfig() (both build
it as an array, never undefined).
Updates one test that constructed AgentlessCiVisibilityEncoder without tags
(not a shape any real caller produces) to pass tags: {} instead.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
litianningdatadog
force-pushed
the
tianning.li/followup-cleanup
branch
from
August 3, 2026 20:21
0338ffa to
51f00d9
Compare
litianningdatadog
merged commit Aug 3, 2026
20917aa
into
tianning.li/dd-trace-microvm-identity-refresh-option-b
674 checks passed
BridgeAR
pushed a commit
that referenced
this pull request
Aug 12, 2026
…encoder (#9610) config.tags is always an object by the time these run - Config#applyDefaults seeds it from DD_TAGS's default (parsed to {} for an empty string) before any other config logic, and every production caller of these constructors passes config.tags straight through. Addresses BridgeAR's "tags will always be an object" review comments on #9355 for exporters/agentless/index.js and encode/agentless-ci-visibility.js. Also drops the same redundant `?.` on DogStatsDClient's #tags, which is always populated via generateClientConfig()/buildClientConfig() (both build it as an array, never undefined). Updates one test that constructed AgentlessCiVisibilityEncoder without tags (not a shape any real caller produces) to pass tags: {} instead. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
BridgeAR
pushed a commit
that referenced
this pull request
Aug 12, 2026
…encoder (#9610) config.tags is always an object by the time these run - Config#applyDefaults seeds it from DD_TAGS's default (parsed to {} for an empty string) before any other config logic, and every production caller of these constructors passes config.tags straight through. Addresses BridgeAR's "tags will always be an object" review comments on #9355 for exporters/agentless/index.js and encode/agentless-ci-visibility.js. Also drops the same redundant `?.` on DogStatsDClient's #tags, which is always populated via generateClientConfig()/buildClientConfig() (both build it as an array, never undefined). Updates one test that constructed AgentlessCiVisibilityEncoder without tags (not a shape any real caller produces) to pass tags: {} instead. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
BridgeAR
pushed a commit
that referenced
this pull request
Aug 12, 2026
…encoder (#9610) config.tags is always an object by the time these run - Config#applyDefaults seeds it from DD_TAGS's default (parsed to {} for an empty string) before any other config logic, and every production caller of these constructors passes config.tags straight through. Addresses BridgeAR's "tags will always be an object" review comments on #9355 for exporters/agentless/index.js and encode/agentless-ci-visibility.js. Also drops the same redundant `?.` on DogStatsDClient's #tags, which is always populated via generateClientConfig()/buildClientConfig() (both build it as an array, never undefined). Updates one test that constructed AgentlessCiVisibilityEncoder without tags (not a shape any real caller produces) to pass tags: {} instead. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
BridgeAR
pushed a commit
that referenced
this pull request
Aug 14, 2026
…encoder (#9610) config.tags is always an object by the time these run - Config#applyDefaults seeds it from DD_TAGS's default (parsed to {} for an empty string) before any other config logic, and every production caller of these constructors passes config.tags straight through. Addresses BridgeAR's "tags will always be an object" review comments on #9355 for exporters/agentless/index.js and encode/agentless-ci-visibility.js. Also drops the same redundant `?.` on DogStatsDClient's #tags, which is always populated via generateClientConfig()/buildClientConfig() (both build it as an array, never undefined). Updates one test that constructed AgentlessCiVisibilityEncoder without tags (not a shape any real caller produces) to pass tags: {} instead. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9355 addressing BridgeAR's review comments that
tagswill always be an object by the time these getters/checks run:packages/dd-trace/src/exporters/agentless/index.js—config.tags?.['runtime-id']→config.tags['runtime-id'](comment)packages/dd-trace/src/encode/agentless-ci-visibility.js—this.tags?.env/this.tags?.['runtime-id']→ non-optional (comment, comment)packages/dd-trace/src/dogstatsd.js— same redundant?.onDogStatsDClient#tags, which is always built as an array bygenerateClientConfig()/buildClientConfig()In every case, traced the constructor back to its only production caller:
config.tagscomes from the tracer'sConfig, which seedstagsto{}(neverundefined) in#applyDefaults()before any other config logic runs.Updated one test (
test/encode/agentless-ci-visibility.spec.js) that constructedAgentlessCiVisibilityEncoderwithouttags— a shape no real caller produces — to passtags: {}instead.Test plan
./node_modules/.bin/mocha packages/dd-trace/test/exporters/agentless/exporter.spec.js— 19 passing./node_modules/.bin/mocha packages/dd-trace/test/encode/agentless-ci-visibility.spec.js— 27 passing./node_modules/.bin/mocha packages/dd-trace/test/dogstatsd.spec.js— 48 passing, 1 pre-existing unrelated timeout (reproduced identically without this change)./node_modules/.bin/mocha packages/dd-trace/test/ci-visibility/exporters/agentless/writer.spec.js packages/dd-trace/test/ci-visibility/exporters/ci-validation.spec.js— 30 passingnpm run linton touched files🤖 Generated with Claude Code