Unify symfony by estringana · Pull Request #4153 · DataDog/dd-trace-php

estringana · 2026-09-02T11:11:33Z

Description

This PR: Symfony 6.2 as the second step from #4149

Removes the standalone appsec/tests/integration/src/test/www/symfony62/ copy
Adds the appsec-specific routes and fixtures (login, registration, dynamic path, locale routes, UTF-8 route, endpoint discovery) to tests/Frameworks/Symfony/Version_6_2/
Adds a docker-init.sh so the AppSec container can bootstrap the app (composer install, cache clear, SQLite DB setup)
All tracer test_web_symfony_62 jobs and all appsec integration test jobs pass

Next steps

Laminas MVC 3.3
WordPress 6.1
Roadrunner

Not doing

llm
payment
frankenphp

datadog-datadog-prod-us1 · 2026-09-02T11:21:19Z

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 9 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [7.2, valgrind] — 🔄 Retry may pass, looks flaky

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [7.3, valgrind] — 🔄 Retry may pass, looks flaky

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [8.5] — 🔄 Retry may pass, looks flaky

View more details · View in GitLab

View all 9 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 54.99% (+0.00%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 7de4755 | Docs | View more details | Give us feedback!}

pr-commenter · 2026-09-02T12:33:49Z

Benchmarks [ tracer ]

Benchmark execution time: 2026-09-03 12:22:15

Comparing candidate commit 80b703e in PR branch estringana/unify-symfony with baseline commit 2ad9386 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 190 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:SamplingRuleMatchingBench/benchRegexMatching1

🟥 execution_time [+46.425ns; +102.375ns] or [+3.171%; +6.993%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

🟥 execution_time [+60.878ns; +128.922ns] or [+4.111%; +8.706%]

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead-opcache

🟩 execution_time [-10.744µs; -5.352µs] or [-5.910%; -2.944%]

chatgpt-codex-connector · 2026-09-03T13:22:21Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-03T13:27:40.371163Z	`80b703e`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80b703ead8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-03T13:27:37Z

+        assert endpoints.find { it.path == '/telemetry' && it.method == 'GET' && it.operationName == 'http.request' && it.resourceName == 'GET /telemetry' } != null
+        assert endpoints.find { it.path == '/lucky/number' && it.method == 'GET' && it.operationName == 'http.request' && it.resourceName == 'GET /lucky/number' } != null
+        assert endpoints.find { it.path == '/lucky/fail' && it.method == 'GET' && it.operationName == 'http.request' && it.resourceName == 'GET /lucky/fail' } != null
+        assert endpoints.find { it.path == '/_error/{code}.{_format}' && it.method == 'GET' && it.operationName == 'http.request' && it.resourceName == 'GET /_error/{code}.{_format}' } != null


Expect the UTF-8 route instead of the dev-only error route

When this endpoint-discovery check runs in the AppSec container, docker-init.sh sets APP_ENV=prod for both initialization and Apache requests, while config/routes/framework.yaml registers /_error/{code}.{_format} only under when@dev. The collected endpoints therefore cannot satisfy this assertion; the newly added /café/{item} route is the endpoint present in its place, so the assertion should reflect the production route set.

Useful? React with 👍 / 👎.

estringana · 2026-09-03T14:13:58Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-03T14:14:04Z

View all feedbacks in Devflow UI.

2026-09-03 14:14:03 UTC ℹ️ Start processing command /merge

2026-09-03 14:14:58 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

Run /code blockers to see what is blocking it.
Run /remove to cancel it.

2026-09-03 18:17:29 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

estringana · 2026-09-03T16:19:58Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-03T16:20:03Z

View all feedbacks in Devflow UI.

2026-09-03 16:20:03 UTC ℹ️ Start processing command /merge

2026-09-03 16:20:05 UTC ❌ MergeQueue

PR already in the queue with status waiting

estringana · 2026-09-03T16:21:36Z

/code blockers

gh-worker-devflow-routing-ef8351 · 2026-09-03T16:22:13Z

View all feedbacks in Devflow UI.

2026-09-03 16:21:40 UTC ℹ️ Start processing command /code blockers
If you need support, contact us on Slack #devflow!

2026-09-03 16:21:41 UTC ℹ️ Devflow:

Checking merge blockers for #4153...

If you need support, contact us on Slack #devflow!

2026-09-03 16:22:11 UTC ❌ Devflow: /code blockers

Could not check merge blockers: status 504: {"errors":[{"status":"504","title":"Gateway Timeout"}]}

To get help about command usage, write /code blockers --help

If you need support, contact us on Slack #devflow with those details!

estringana · 2026-09-04T08:24:14Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-09-04T08:24:19Z

View all feedbacks in Devflow UI.

2026-09-04 08:24:19 UTC ℹ️ Start processing command /merge

2026-09-04 08:25:09 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

Run /code blockers to see what is blocking it.
Run /remove to cancel it.

2026-09-04 12:27:39 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

estringana changed the base branch from master to estringana/unify-frameworks September 2, 2026 11:12

Base automatically changed from estringana/unify-frameworks to master September 2, 2026 11:16

estringana added 5 commits September 2, 2026 16:42

Unify appsec Laravel framework to tracer

545c38d

Unify login mehtods

4ed55fa

Create docker init file

c105957

Unify Symfony appsec framework with tracer one

c52c949

Fix composer dev

802abe6

estringana force-pushed the estringana/unify-symfony branch from fdec45b to 802abe6 Compare September 2, 2026 14:44

estringana added 3 commits September 3, 2026 10:52

Fix symfony

5f32ef8

Fix symfony

0b3e501

Fix symfony

80b703e

estringana marked this pull request as ready for review September 3, 2026 13:22

estringana requested review from a team as code owners September 3, 2026 13:22

chatgpt-codex-connector Bot reviewed Sep 3, 2026

View reviewed changes

cataphract approved these changes Sep 3, 2026

View reviewed changes

estringana enabled auto-merge (squash) September 3, 2026 14:13

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: waiting label Sep 3, 2026

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: removed and removed mergequeue-status: waiting labels Sep 3, 2026

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: waiting and removed mergequeue-status: removed labels Sep 4, 2026

Merge branch 'master' into estringana/unify-symfony

fc1cf10

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: removed and removed mergequeue-status: waiting labels Sep 4, 2026

Merge branch 'master' into estringana/unify-symfony

7de4755

Uh oh!

Conversation

estringana commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Next steps

Not doing

Uh oh!

datadog-datadog-prod-us1 Bot commented Sep 2, 2026 • edited by datadog-prod-us1-4 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

pr-commenter Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ tracer ]

Explanation

More details about the CI and significant changes

scenario:SamplingRuleMatchingBench/benchRegexMatching1

scenario:SamplingRuleMatchingBench/benchRegexMatching2

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead-opcache

Uh oh!

chatgpt-codex-connector Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

estringana commented Sep 3, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

estringana commented Sep 3, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

estringana commented Sep 3, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026

Uh oh!

estringana commented Sep 4, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

estringana commented Sep 2, 2026 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Sep 2, 2026 •

edited by datadog-prod-us1-4 Bot

Loading

pr-commenter Bot commented Sep 2, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 3, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 3, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026 •

edited

Loading