Skip to content

chore(w3c): allow colons in datadog tags propagated in tracestate #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2022
Merged

chore(w3c): allow colons in datadog tags propagated in tracestate #4741

merged 2 commits into from
Dec 6, 2022

Conversation

@ZStriker19
Copy link
Collaborator

@ZStriker19 ZStriker19 commented Dec 6, 2022 •
edited by mabdinur
Loading

Description

Datadog tag values allows colon : (0x3A) which is not currently allowed in the W3C Trace Context propagation with tracestate. We update the propagation to allow : and not allow ~ (0x7E).

Checklist

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added and follows the library release note guidelines, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.

@ZStriker19 ZStriker19 requested a review from a team as a code owner December 6, 2022 18:01
@ZStriker19 ZStriker19 added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 6, 2022
@ZStriker19 ZStriker19 mentioned this pull request Dec 6, 2022
Merged
11 tasks
@majorgreys majorgreys changed the title chore(w3c): change allowed value character and separator from : to ~ chore(w3c): allow colons in datadog tags propagated in tracestate Dec 6, 2022
majorgreys
majorgreys reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@majorgreys majorgreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like us to add a test that ensures that we are allowing the colons in tags.

@mabdinur mabdinur enabled auto-merge (squash) December 6, 2022 19:15
@mabdinur mabdinur merged commit 4f2d217 into 1.x Dec 6, 2022
@mabdinur mabdinur deleted the chore/change_allowed_char_for_tracestate_from_equals_to_tilde branch December 6, 2022 19:32
@github-actions github-actions bot added this to the v1.7.0 milestone Dec 6, 2022
@mabdinur mabdinur restored the chore/change_allowed_char_for_tracestate_from_equals_to_tilde branch December 17, 2022 03:58
mabdinur added a commit that referenced this pull request Dec 17, 2022
@mabdinur
Revert "chore(w3c): allow colons in datadog tags propagated in traces…
1749c4f 
…tate (#4741)"

This reverts commit 4f2d217.
@mabdinur mabdinur mentioned this pull request Dec 17, 2022
Merged
brettlangdon pushed a commit that referenced this pull request Dec 19, 2022
@mabdinur
Revert "chore(w3c): allow colons in datadog tags propagated in traces…
6cb75c6 
…tate" (#4799)

Reverts #4741. `:` should delimit datadog tracestate
tags not `~`.


#### Note
When injecting/extracting ddtrace tags from headers `=` characters
should be replaced with `~`. This fix will be introduced in a future PR.
mabdinur added a commit that referenced this pull request Dec 19, 2022
@mabdinur
Revert "chore(w3c): allow colons in datadog tags propagated in traces…
59b5489 
…tate" (#4799)

Reverts #4741. `:` should delimit datadog tracestate
tags not `~`.


#### Note
When injecting/extracting ddtrace tags from headers `=` characters
should be replaced with `~`. This fix will be introduced in a future PR.
@mabdinur mabdinur mentioned this pull request Dec 19, 2022
Merged
mabdinur added a commit that referenced this pull request Dec 19, 2022
@mabdinur
Revert "chore(w3c): allow colons in datadog tags propagated in traces…
cc4bac9 
…tate" (backport #4799 to 1.7) (#4804)

Reverts #4741. `:` should delimit datadog tracestate
tags not `~`.


#### Note
When injecting/extracting ddtrace tags from headers `=` characters
should be replaced with `~`. This fix will be introduced in a future PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majorgreys majorgreys majorgreys left review comments

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

@mabdinur mabdinur mabdinur approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

v1.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ZStriker19 @majorgreys @Kyle-Verhoog @mabdinur