Skip to content

Revert "chore(w3c): allow colons in datadog tags propagated in tracestate" #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2022
Merged

Revert "chore(w3c): allow colons in datadog tags propagated in tracestate" #4799

merged 2 commits into from
Dec 19, 2022

Conversation

@mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Dec 17, 2022 •
edited
Loading

Reverts #4741. : should delimit datadog tracestate tags not ~.

Note

When injecting/extracting ddtrace tags from headers = characters should be replaced with ~. This fix will be introduced in a future PR.

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 17, 2022
@mabdinur mabdinur added this to the v1.7.0 milestone Dec 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022 •
edited
Loading

Codecov Report

Merging #4799 (12269d0) into 1.x (1a308d1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              1.x    #4799      +/-   ##
==========================================
- Coverage   78.02%   78.02%   -0.01%     
==========================================
  Files         808      808              
  Lines       62053    62053              
==========================================
- Hits        48416    48415       -1     
- Misses      13637    13638       +1
Impacted Files Coverage Δ
tests/tracer/test_context.py 100.00% <ø> (ø)
tests/tracer/test_propagation.py 99.39% <ø> (ø)
tests/tracer/test_utils.py 97.26% <ø> (ø)
ddtrace/internal/utils/http.py 91.17% <100.00%> (ø)
ddtrace/propagation/http.py 95.32% <100.00%> (ø)
ddtrace/internal/telemetry/writer.py 76.55% <0.00%> (-0.69%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mabdinur mabdinur marked this pull request as ready for review December 19, 2022 14:26
@mabdinur mabdinur requested a review from a team as a code owner December 19, 2022 14:26
@brettlangdon brettlangdon enabled auto-merge (squash) December 19, 2022 16:40
@brettlangdon brettlangdon merged commit 6cb75c6 into 1.x Dec 19, 2022
@brettlangdon brettlangdon deleted the revert-4741-chore/change_allowed_char_for_tracestate_from_equals_to_tilde branch December 19, 2022 16:41
mabdinur added a commit that referenced this pull request Dec 19, 2022
@mabdinur
Revert "chore(w3c): allow colons in datadog tags propagated in traces…
59b5489 
…tate" (#4799)

Reverts #4741. `:` should delimit datadog tracestate
tags not `~`.


#### Note
When injecting/extracting ddtrace tags from headers `=` characters
should be replaced with `~`. This fix will be introduced in a future PR.
mabdinur added a commit that referenced this pull request Dec 19, 2022
@mabdinur
Revert "chore(w3c): allow colons in datadog tags propagated in traces…
cc4bac9 
…tate" (backport #4799 to 1.7) (#4804)

Reverts #4741. `:` should delimit datadog tracestate
tags not `~`.


#### Note
When injecting/extracting ddtrace tags from headers `=` characters
should be replaced with `~`. This fix will be introduced in a future PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majorgreys majorgreys majorgreys approved these changes

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

v1.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mabdinur @codecov-commenter @majorgreys @brettlangdon