Skip to content

Conversation

@mabdinur
Copy link
Contributor

Reverts #4741. : should delimit datadog tracestate tags not ~.

Note

When injecting/extracting ddtrace tags from headers = characters should be replaced with ~. This fix will be introduced in a future PR.

…tate" (#4799)

Reverts #4741. `:` should delimit datadog tracestate
tags not `~`.


#### Note
When injecting/extracting ddtrace tags from headers `=` characters
should be replaced with `~`. This fix will be introduced in a future PR.
@mabdinur mabdinur requested a review from a team as a code owner December 19, 2022 20:36
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #4804 (59b5489) into 1.7 (1a308d1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              1.7    #4804      +/-   ##
==========================================
- Coverage   78.02%   78.02%   -0.01%     
==========================================
  Files         808      808              
  Lines       62053    62053              
==========================================
- Hits        48416    48414       -2     
- Misses      13637    13639       +2     
Impacted Files Coverage Δ
tests/tracer/test_context.py 100.00% <ø> (ø)
tests/tracer/test_propagation.py 99.39% <ø> (ø)
tests/tracer/test_utils.py 97.26% <ø> (ø)
ddtrace/internal/utils/http.py 91.17% <100.00%> (ø)
ddtrace/propagation/http.py 95.32% <100.00%> (ø)
ddtrace/internal/remoteconfig/worker.py 95.65% <0.00%> (-4.35%) ⬇️
tests/utils.py 90.18% <0.00%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mabdinur mabdinur merged commit cc4bac9 into 1.7 Dec 19, 2022
@mabdinur mabdinur deleted the backport-4799-to-1-7 branch December 19, 2022 21:34
@github-actions github-actions bot added this to the v1.7.0 milestone Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants