include both page title and section header in search results #17877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgdeutsch
changed the title
kayayarai
approved these changes
Apr 27, 2023
hestonhoffman
approved these changes
Apr 27, 2023
StefonSimmons
approved these changes
Apr 27, 2023
this is good to be merged, thank you @hestonhoffman ! |
hestonhoffman
deleted the
brian.deutsch/integrations-search-result-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
render both the page title and section header (when applicable) in the page hierarchy of search results.
Motivation
https://datadoghq.atlassian.net/browse/WEB-3507
Preview
do some queries from the search results page, confirm both page title and section header are present in the page hierarchy.
i.e.
Documentation » Integrations » Postgres » Data Collectedhttps://docs-staging.datadoghq.com/brian.deutsch/integrations-search-result-header/search/?s=postgres
https://docs-staging.datadoghq.com/brian.deutsch/integrations-search-result-header/search/?s=aws
https://docs-staging.datadoghq.com/brian.deutsch/integrations-search-result-header/search/?s=synthetics
there should be no console errors, and styles should be unaffected.
Additional Notes
Reviewer checklist