(DOCS-5872) DogstatsD with UDS requires additional steps#21142
Merged
git-thuerk-done merged 4 commits intomasterfrom Dec 20, 2023
Merged
(DOCS-5872) DogstatsD with UDS requires additional steps#21142git-thuerk-done merged 4 commits intomasterfrom
git-thuerk-done merged 4 commits intomasterfrom
Conversation
hestonhoffman
commented
Dec 20, 2023
Contributor
Preview links (active after the
|
git-thuerk-done
requested changes
Dec 20, 2023
Contributor
git-thuerk-done
left a comment
git-thuerk-done
left a comment
There was a problem hiding this comment.
Hi @hestonhoffman Looks good, I think something got left out from the shell script though in the Test with Netcat section?
Let me know and I can re-review :)
| sudo chown dd-agent:dd-agent /var/run/datadog/ | ||
| ``` | ||
| 1. Edit the [Agent's main configuration file][1]: | ||
| 1. Set `use_dogstatsd` to `true`. |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Set `use_dogstatsd` to `true`. | |
| 1. Set `use_dogstatsd` to `true`. |
minor nit my eyes got a little confused seeing the 1. and 2. steps here and then below step 4 to restart your Agent. I think it's ok since it's indented, just an observation :)
Contributor
Author
There was a problem hiding this comment.
Yeah, you're right. I did this all in the web UI cos I was too lazy to create a branch and this is where it got me.
Contributor
Author
There was a problem hiding this comment.
This should be fixed now. These indented steps are sub-steps. They should look okay in the preview
git-thuerk-done
approved these changes
Dec 20, 2023
MaelNamNam
pushed a commit
that referenced
this pull request
Jan 17, 2024
* (DOCS-5872) DogstatsD with UDS requires additional steps * Update content/en/developers/dogstatsd/unix_socket.md * Fix wierdness * Fix indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge instructions