Skip to content

Fix DD_TRACE_RATE_LIMIT description#22405

Merged
brett0000FF merged 1 commit intomasterfrom
brett0000FF/DOCS-7470
Mar 29, 2024
Merged

Fix DD_TRACE_RATE_LIMIT description#22405
brett0000FF merged 1 commit intomasterfrom
brett0000FF/DOCS-7470

Conversation

@brett0000FF
Copy link
Copy Markdown
Contributor

@brett0000FF brett0000FF commented Mar 28, 2024

What does this PR do? What is the motivation?

  • DD_TRACE_RATE_LIMIT config is incorrectly described as a ratio (0.0 -> 1.0).
  • It should instead be N traces per second per service instance.

Merge instructions

  • Please merge after reviewing

Additional notes

@brett0000FF brett0000FF requested a review from a team as a code owner March 28, 2024 19:28
@brett0000FF brett0000FF requested a review from Qard March 28, 2024 19:30
@github-actions
Copy link
Copy Markdown
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Copy Markdown
Contributor

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rochdev Can you also review this change?

Copy link
Copy Markdown
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brett0000FF brett0000FF requested a review from rochdev March 28, 2024 20:24
@brett0000FF brett0000FF merged commit 34e96d2 into master Mar 29, 2024
@brett0000FF brett0000FF deleted the brett0000FF/DOCS-7470 branch March 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants