Skip to content

[DOCS-8454] Consolidate guides: Feature Flags#25073

Merged
dd-mergequeue[bot] merged 14 commits intomasterfrom
rtrieu/docs-8454-consolidate-guides
Jan 30, 2025
Merged

[DOCS-8454] Consolidate guides: Feature Flags#25073
dd-mergequeue[bot] merged 14 commits intomasterfrom
rtrieu/docs-8454-consolidate-guides

Conversation

@rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Sep 4, 2024

What does this PR do? What is the motivation?

  • Integrates the guide on setting up Feature Flags into the docs
  • Chops up Feature Flags into a landing page, setup page, and managing/using page

Merge instructions

  • Please merge after reviewing

Additional notes

@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label Sep 4, 2024
@rtrieu rtrieu requested review from a team as code owners September 4, 2024 19:46
@rtrieu rtrieu requested a review from meghanlo September 4, 2024 19:46
@rtrieu rtrieu force-pushed the rtrieu/docs-8454-consolidate-guides branch from 0a22f64 to 4b656b9 Compare September 4, 2024 19:53
@github-actions github-actions bot added Architecture Everything related to the Doc backend Guide Content impacting a guide labels Sep 4, 2024
Copy link
Contributor

@meghanlo meghanlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtrieu rtrieu removed the WORK IN PROGRESS No review needed, it's a wip ;) label Sep 5, 2024
@alai97 alai97 added the editorial review Waiting on a more in-depth review label Sep 5, 2024
Copy link
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rtrieu looks good! I noted some things to update just for wording and flow, and then the links in the partial need fixed. I know a lot of this you just moved content from the guide but thought it could use a fresh update :)

rtrieu and others added 2 commits September 6, 2024 12:44
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
@rtrieu
Copy link
Contributor Author

rtrieu commented Sep 6, 2024

Appreciate your edits on this, @aliciascott !!

Copy link
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for fixing the partial :)

@rtrieu rtrieu removed the editorial review Waiting on a more in-depth review label Sep 9, 2024
@rtrieu rtrieu requested a review from a team September 9, 2024 16:06
@git-thuerk-done
Copy link
Contributor

Hi @rtrieu I noticed this one is a little stale and now has merge conflicts, let me know if you need a re-review!

@rtrieu
Copy link
Contributor Author

rtrieu commented Nov 7, 2024

@aliciascott Thanks, I had forgotten about this!

@rtrieu
Copy link
Contributor Author

rtrieu commented Jan 30, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 30, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-30 18:11:49 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-30 18:20:44 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c6c5a46 into master Jan 30, 2025
14 of 15 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rtrieu/docs-8454-consolidate-guides branch January 30, 2025 18:20
@rtrieu rtrieu mentioned this pull request Mar 18, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend Guide Content impacting a guide mergequeue-status: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants