adjust RUM response status documentation #28270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out Browsers are enforcing different rules to access response status.
drichards-87
requested changes
Mar 20, 2025
Contributor
drichards-87
left a comment
drichards-87
left a comment
There was a problem hiding this comment.
Left a few minor suggestions. Also, just an FYI that there's a merge conflict in the PR.
content/en/real_user_monitoring/browser/monitoring_resource_performance.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/monitoring_resource_performance.md
Outdated
Show resolved
Hide resolved
content/en/real_user_monitoring/browser/monitoring_resource_performance.md
Outdated
Show resolved
Hide resolved
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
Member
Author
|
Thank you @drichards-87 , I commited your suggestions and fixed the conflicts! |
Contributor
Preview links (active after the
|
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
It turns out Browsers are enforcing different rules to access response status. For detailed timings,
Timing-Allow-Originis needed, but for status code,Access-Control-Allow-Originheaders and thecrossoriginattribute are needed.Merge instructions
Merge readiness:
Merge queue is enabled in this repo. Your branch name MUST follow the
<slack_username>/<branch_name>convention, or your pull request will not pass in CI. If your branch doesn't follow this format, rename it or create a new branch and PR.To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes