Skip to content

Conversation

@git-thuerk-done
Copy link
Contributor

@git-thuerk-done git-thuerk-done commented Mar 24, 2025

What does this PR do? What is the motivation?

HTTP tests are now supported in Mobile App testing.
I added this under the Manually Add Steps Section under a new section called "Interaction" as it appears this has now changed (used to be called Special Actions).
Additionally updated the same step under the Browser testing page and cleaned up the order.

Also adds two new Request options: AWS Signature, and OAuth 2.0

For docs reviewer: There is technically very little net new content here - I added the HTTP steps to the Mobile app page as a direct copy from the Browser pages, mostly this is just shuffling content around.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@git-thuerk-done git-thuerk-done requested a review from a team as a code owner March 24, 2025 22:47
@git-thuerk-done git-thuerk-done added the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 24, 2025
@github-actions github-actions bot added the Images Images are added/removed with this PR label Mar 24, 2025
@github-actions
Copy link
Contributor

Copy link
Contributor

@LuizGiserman LuizGiserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes for it to be 100%. Thank you very much for updating all of the interaction steps ! I don't even know when this changed in the interface.

Alicia Scott and others added 2 commits March 25, 2025 09:07
Co-authored-by: Luiz Giserman <40475681+LuizGiserman@users.noreply.github.com>
Copy link
Contributor

@LuizGiserman LuizGiserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you !

@git-thuerk-done git-thuerk-done removed the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 25, 2025
@maycmlee
Copy link
Contributor

Created docs card: https://datadoghq.atlassian.net/browse/DOCS-10460

@maycmlee maycmlee added the editorial review Waiting on a more in-depth review label Mar 25, 2025
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, Alicia! I made some suggestions to fine-tune some of the wording - as always, let me know if I can clarify anything or if you want to bounce some ideas off me 🙂


#### Hover on element

This step uses a dedicated click, not a hovering mechanism, to avoid generating a separate step every time a user hovers over an element during recording.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure what a dedicated click is, as opposed to a regular click, and how this relates to hovering, which I think of as...not clicking. But if it's a technical thing that makes sense to synthetics people, ignore me!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah again not sure, this was here before :) Let me look. (inherited products are fun) :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look at this in the next iteration to see if I can make this more clear.

@git-thuerk-done
Copy link
Contributor Author

This looks great, Alicia! I made some suggestions to fine-tune some of the wording - as always, let me know if I can clarify anything or if you want to bounce some ideas off me 🙂

Awesome let me take a look! I did not write a lot of the original content as it was copied over but always happy to improve!

Alicia Scott and others added 2 commits March 27, 2025 08:33
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, Alicia! Thank you so much for taking on all that feedback, and as always, it's totally cool if not all of it was what you were looking for for this task 🙂 Just a couple of remaining pesky links I noticed and then we're good to go here 🎉


| Type | Operator | Value type |
|-----------------|------------------------------------------------------------------------------------------------------------------------|----------------------------------------------------------|
| `body` | `contains`, `does not contain`, `is`, `is not`, <br> `matches`, `does not match`, <br> [`jsonpath`][11], [`xpath`][12] | _String_ <br> _[Regex][13]_ <br> _String_, _[Regex][13]_ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the URL for [13]! Looks like the ones for [11] and [12] are still missing, but once they're in there, we should be ready to boogie 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thank you!! Not sure how I missed this :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to miss for sure!

Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's beautiful!! Great job, Alicia, and thanks again!

@git-thuerk-done
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 28, 2025

View all feedbacks in Devflow UI.
2025-03-28 15:54:12 UTC ℹ️ Start processing command /merge


2025-03-28 15:54:20 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 17m (p90).


2025-03-28 16:08:17 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit eeabe97 into master Mar 28, 2025
19 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aliciascott/DOCS-10436-mobile-http-step branch March 28, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial review Waiting on a more in-depth review Images Images are added/removed with this PR mergequeue-status: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants