-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[DOCS-10436] adding HTTP tests to Mobile app testing #28334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-10436] adding HTTP tests to Mobile app testing #28334
Conversation
Preview links (active after the
|
LuizGiserman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes for it to be 100%. Thank you very much for updating all of the interaction steps ! I don't even know when this changed in the interface.
Co-authored-by: Luiz Giserman <40475681+LuizGiserman@users.noreply.github.com>
LuizGiserman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thank you !
|
Created docs card: https://datadoghq.atlassian.net/browse/DOCS-10460 |
janine-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, Alicia! I made some suggestions to fine-tune some of the wording - as always, let me know if I can clarify anything or if you want to bounce some ideas off me 🙂
|
|
||
| #### Hover on element | ||
|
|
||
| This step uses a dedicated click, not a hovering mechanism, to avoid generating a separate step every time a user hovers over an element during recording. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure what a dedicated click is, as opposed to a regular click, and how this relates to hovering, which I think of as...not clicking. But if it's a technical thing that makes sense to synthetics people, ignore me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah again not sure, this was here before :) Let me look. (inherited products are fun) :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look at this in the next iteration to see if I can make this more clear.
content/en/synthetics/mobile_app_testing/mobile_app_tests/steps.md
Outdated
Show resolved
Hide resolved
content/en/synthetics/mobile_app_testing/mobile_app_tests/steps.md
Outdated
Show resolved
Hide resolved
content/en/synthetics/mobile_app_testing/mobile_app_tests/steps.md
Outdated
Show resolved
Hide resolved
content/en/synthetics/mobile_app_testing/mobile_app_tests/steps.md
Outdated
Show resolved
Hide resolved
Awesome let me take a look! I did not write a lot of the original content as it was copied over but always happy to improve! |
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
janine-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing, Alicia! Thank you so much for taking on all that feedback, and as always, it's totally cool if not all of it was what you were looking for for this task 🙂 Just a couple of remaining pesky links I noticed and then we're good to go here 🎉
|
|
||
| | Type | Operator | Value type | | ||
| |-----------------|------------------------------------------------------------------------------------------------------------------------|----------------------------------------------------------| | ||
| | `body` | `contains`, `does not contain`, `is`, `is not`, <br> `matches`, `does not match`, <br> [`jsonpath`][11], [`xpath`][12] | _String_ <br> _[Regex][13]_ <br> _String_, _[Regex][13]_ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the URL for [13]! Looks like the ones for [11] and [12] are still missing, but once they're in there, we should be ready to boogie 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh thank you!! Not sure how I missed this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy to miss for sure!
janine-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's beautiful!! Great job, Alicia, and thanks again!
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do? What is the motivation?
HTTP tests are now supported in Mobile App testing.
I added this under the Manually Add Steps Section under a new section called "Interaction" as it appears this has now changed (used to be called Special Actions).
Additionally updated the same step under the Browser testing page and cleaned up the order.
Also adds two new Request options: AWS Signature, and OAuth 2.0
For docs reviewer: There is technically very little net new content here - I added the HTTP steps to the Mobile app page as a direct copy from the Browser pages, mostly this is just shuffling content around.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes