Update example code for instrumenting Python Lambda using CDK #28353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maycmlee
approved these changes
Mar 25, 2025
avangelillo
reviewed
Mar 25, 2025
| api_key_secret_arn="<DATADOG_API_KEY_SECRET_ARN>", | ||
| ) | ||
| datadog.add_lambda_functions([<LAMBDA_FUNCTIONS>]) | ||
| datadogLambda.add_lambda_functions([<LAMBDA_FUNCTIONS>]) |
There was a problem hiding this comment.
Also pretty minor, but the convention for python is usually snake case (datadogLambda -> datadog_lambda)
Contributor
Author
There was a problem hiding this comment.
Good point. Addressed!
| datadogLambda.add_lambda_functions([<LAMBDA_FUNCTIONS>]) | ||
| ``` | ||
|
|
||
| To fill in the placeholders: |
There was a problem hiding this comment.
Does <LAMBDA_FUNCTIONS> need a section in the placeholders list too?
Contributor
Preview links (active after the
|
avangelillo
approved these changes
Mar 31, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Replace class name and variable name
DatadogwithDatadogLambdabecause the former has been removed in the latest version of the CDK construct.Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes