Skip to content

Add env vars for excluding OPW logs #28409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 6 commits into from
Apr 2, 2025
Merged

Add env vars for excluding OPW logs #28409

dd-mergequeue merged 6 commits into from
Apr 2, 2025

Conversation

@maycmlee
Copy link
Contributor

@maycmlee maycmlee commented Mar 27, 2025 •
edited
Loading

What does this PR do? What is the motivation?

Adds env var information to prevent sending duplicate OPW logs.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@maycmlee maycmlee added the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 27, 2025
@maycmlee maycmlee requested a review from a team as a code owner March 27, 2025 17:47
@maycmlee maycmlee changed the title add note Add env vars for excluding OPW logs Mar 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

tessneau
tessneau approved these changes Apr 1, 2025
View reviewed changes
content/en/observability_pipelines/troubleshooting.md Outdated

## Duplicate Observability Pipelines logs

If you see duplicate Observability Pipelines logs in [Log Explorer][7] and your Agent is running in a Docker container, you need to exclude Observability Pipelines logs using the `DD_CONTAINER_EXCLUDE_LOGS` environment variable. For Helm, use `datadog.containerExcludeLogs`. Otherwise, you get duplicate Observability Pipelines logs because the Worker also sends logs to Datadog. See [Docker Log Collection][8] or [Setting environment variables for Helm][9] for more information.
Copy link
Member

@tessneau tessneau Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

@maycmlee maycmlee Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@maycmlee @tessneau
Update content/en/observability_pipelines/sources/datadog_agent.md
4b8e8e4 
Co-authored-by: Tess Neau <tess.neau@datadoghq.com>
maycmlee
maycmlee commented Apr 1, 2025
View reviewed changes
@maycmlee maycmlee removed the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 2, 2025
@drichards-87 drichards-87 self-assigned this Apr 2, 2025
drichards-87
drichards-87 requested changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just have one minor piece of feedback.

maycmlee
maycmlee commented Apr 2, 2025
View reviewed changes
@maycmlee @drichards-87
Apply suggestions from code review
a7f08be 
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
@maycmlee maycmlee requested a review from drichards-87 April 2, 2025 15:57
@maycmlee
Copy link
Contributor Author

maycmlee commented Apr 2, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 2, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-02 15:57:38 UTC ℹ️ Start processing command /merge

2025-04-02 15:58:29 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-02 16:22:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 19m (p90).

2025-04-02 16:41:15 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit bd47de7 into master Apr 2, 2025
21 of 24 checks passed
@dd-mergequeue dd-mergequeue bot deleted the may/env-var-duplicate-logs branch April 2, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tessneau tessneau tessneau approved these changes

@drichards-87 drichards-87 drichards-87 approved these changes

Assignees

@drichards-87 drichards-87

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maycmlee @tessneau @drichards-87