Skip to content

Conversation

@tylfin
Copy link
Member

@tylfin tylfin commented Mar 31, 2025

What does this PR do? What is the motivation?

This pull request includes updates to the documentation for the Dynamic Instrumentation Expression Language. The changes introduce special variables for collection and dictionary operations, and improve clarity regarding their usage.

Documentation updates:

  • Added a new section on special variables (@it, @key, @value) for collection and dictionary operations, including descriptions and examples.
  • Updated the explanation of collection operations to reference the new special variables section.
  • Removed outdated references at the end of the collection operations section.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@tylfin tylfin requested a review from a team as a code owner March 31, 2025 07:49
@tylfin tylfin requested a review from a team March 31, 2025 07:51
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3421 branch 2 times, most recently from 8fe8cc2 to fb635d7 Compare March 31, 2025 08:56
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3421 branch 2 times, most recently from 0b740b5 to 3ef3e39 Compare March 31, 2025 13:26
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3421 branch from 3ef3e39 to cd942bf Compare March 31, 2025 13:33
@rtrieu rtrieu self-assigned this Mar 31, 2025
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback.

@tylfin tylfin requested a review from rtrieu April 1, 2025 14:17
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits for consistency and clarity.

tylfin and others added 2 commits April 1, 2025 16:44
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@tylfin tylfin requested a review from rtrieu April 8, 2025 13:15
@tylfin
Copy link
Member Author

tylfin commented Apr 8, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 8, 2025

View all feedbacks in Devflow UI.

2025-04-08 13:42:06 UTC ℹ️ Start processing command /merge


2025-04-08 13:42:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 18m (p90).


2025-04-08 13:58:13 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 35b34b0 into master Apr 8, 2025
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the tyler.finethy/DEBUG-3421 branch April 8, 2025 13:58
estherk15 pushed a commit that referenced this pull request May 8, 2025
…28444)

* docs(debugger): add special variables section to expression language docs

* Update content/en/dynamic_instrumentation/expression-language.md

Co-authored-by: Thomas Watson <w@tson.dk>

* Apply suggestions from code review

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

---------

Co-authored-by: Thomas Watson <w@tson.dk>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants