Azhao95 dd/grace permissions instructions #28462
Conversation
|
This is my major docs PR, would love some feedback! |
Preview links (active after the
|
rtrieu
left a comment
rtrieu
left a comment
There was a problem hiding this comment.
Left you some feedback and hopefully answered some of your questions!
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
dd-devflow
bot
added
mergequeue-status: waiting
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
add screenshot of grace integration model to image repo
rtrieu
left a comment
rtrieu
left a comment
There was a problem hiding this comment.
Hi @azhao95-dd, I left some feedback and questions to further clarify the content.
| By default, access to integration resources (accounts, services, webhooks) is unrestricted. Granular access controls can be used to restrict the behavior of users, teams, roles, or your full organization at the integration resource level. To learn more and see if an integration is supported, review the [integration's documentation][46] | ||
| {{< img src="getting_started/integrations/GRACE integration-account-modal.png" alt="Granular access controls" style="width:100%;" >}} | ||
|
|
||
| 1. While viewing an integration, locate the resource that should have granular access controls applied. |
There was a problem hiding this comment.
It's not exactly clear what and where users should be looking. Can you clarify or add a screenshot? The screenshot above is a bit too cropped to see where users should be.
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
more descriptions on where to locate GRACE controls
|
Thanks!! updated with some more specificity. |
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: waiting
and removed
mergequeue-status: removed
labels
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: waiting
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Co-authored-by: rtrieu <107086888+rtrieu@users.noreply.github.com>
What does this PR do? What is the motivation?
Add instructions for setting up GRACE permissions for Integrations resources.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes