Skip to content

[AZINTS] update event hub forwarder installation docs#29224

Merged
dd-mergequeue[bot] merged 7 commits into
masterfrom
ava.silver/azints/update-event-hub-forwarder-installation-docs
May 8, 2025
Merged

[AZINTS] update event hub forwarder installation docs#29224
dd-mergequeue[bot] merged 7 commits into
masterfrom
ava.silver/azints/update-event-hub-forwarder-installation-docs

Conversation

@ava-silver
Copy link
Copy Markdown
Contributor

@ava-silver ava-silver commented May 7, 2025

What does this PR do? What is the motivation?

Updates the docs due to the migration of the event hub forwarder to nodejs model v4: DataDog/datadog-serverless-functions#934

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@github-actions github-actions Bot added the Guide Content impacting a guide label May 7, 2025
Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2025

<div class="alert alert-info">
Starting April 30, 2025, Azure no longer supports Node.js 18. To ensure compatibility, first update your forwarder code, then upgrade to the latest Azure LTS version of Node.js (20).
If you previously deployed with an ARM template, you can update using the template with the same parameters.
Starting April 30, 2025, Azure no longer supports Node.js 18. To ensure compatibility, update using the Deploy to Azure (ARM) template with the same parameters.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we only support deploying with the arm template, we should only recommend that now.

{{< tabs >}}

{{% tab "Automated installation" %}}
{{% tab "Event Hub" %}}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removes multiple options for event hub and renames for clarity

@ava-silver ava-silver marked this pull request as ready for review May 8, 2025 15:05
@ava-silver ava-silver requested a review from a team as a code owner May 8, 2025 15:05
[2]: https://manage.windowsazure.com
[3]: /help/
[4]: /integrations/azure/?tab=azurecliv20#optional-parameters
[5]: /logs/indexes/#set-daily-quota
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you reorder the links?

Copy link
Copy Markdown
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ava-silver I have a few suggestions and then the PR should be good to go. Let me know if you have any questions!

Comment thread content/en/logs/guide/azure-logging-guide.md Outdated
<div class="alert alert-info">
Starting April 30, 2025, Azure no longer supports Node.js 18. To ensure compatibility, first update your forwarder code, then upgrade to the latest Azure LTS version of Node.js (20).
If you previously deployed with an ARM template, you can update using the template with the same parameters.
Starting April 30, 2025, Azure no longer supports Node.js 18. To ensure compatibility, update using the Deploy to Azure (ARM) template with the same parameters.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Azure ARM" would be redundant here

Suggested change
Starting April 30, 2025, Azure no longer supports Node.js 18. To ensure compatibility, update using the Deploy to Azure (ARM) template with the same parameters.
Starting April 30, 2025, Azure no longer supports Node.js 18. To ensure compatibility, update using the Deploy to Azure Resource Manager (ARM) template with the same parameters.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking either Deploy to Azure template, like the button says, or the actual name of the template: Azure Resource Manager template would be good. I'll opt for just the latter for simplicity, since combining the two into Deploy to Azure Resource Manager feels more confusing potentially.

ava-silver and others added 3 commits May 8, 2025 13:41
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@ava-silver ava-silver requested a review from rtrieu May 8, 2025 17:45
@ava-silver
Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented May 8, 2025

View all feedbacks in Devflow UI.

2025-05-08 17:48:12 UTC ℹ️ Start processing command /merge


2025-05-08 17:48:20 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-08 18:14:17 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-05-08 18:33:06 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue Bot merged commit f47fdb6 into master May 8, 2025
19 of 22 checks passed
@dd-mergequeue dd-mergequeue Bot deleted the ava.silver/azints/update-event-hub-forwarder-installation-docs branch May 8, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Guide Content impacting a guide mergequeue-status: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants