Skip to content

Conversation

@barboraplasovska
Copy link
Contributor

What does this PR do? What is the motivation?

Fixes description and instructions as to how GraphQL Apollo should be setup on iOS.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@barboraplasovska barboraplasovska self-assigned this Nov 21, 2025
@barboraplasovska barboraplasovska requested a review from a team as a code owner November 21, 2025 12:28
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

@rtrieu
Copy link
Contributor

rtrieu commented Nov 21, 2025

Hi @barboraplasovska thank you for this PR! As a general rule, we don't suggest how any products/features/offerings may work in the future, only as it works now. I'll go ahead and put a WIP label on this, which you can remove when this update has been released, and the docs team will review it. Let me know if you have any questions. Thanks!

@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label Nov 21, 2025
@barboraplasovska
Copy link
Contributor Author

Hey @rtrieu, thanks for the review! For a bit of context, I have originally added this part of the documentation because I expected the feature to be released soon. Unfortunately, it’s still a WIP, and since the docs already mention it without saying it’s unreleased, I’ve had a customer try to use it assuming it was available.

Given the docs team’s protocol about not describing unreleased features, would it be better to temporarily remove this section entirely, or keep it and add a note clarifying that it’s not released yet?

I’m happy to adjust the PR to follow whichever option aligns best with your guidelines.

Thanks again!

@rtrieu
Copy link
Contributor

rtrieu commented Nov 21, 2025

Hi @barboraplasovska let's definitely remove the section until it's available :) Thanks!

@barboraplasovska barboraplasovska force-pushed the bplasovska/fix-graphql-ios-description branch from ac35470 to 3a281a9 Compare November 27, 2025 11:55
@barboraplasovska barboraplasovska removed the WORK IN PROGRESS No review needed, it's a wip ;) label Nov 27, 2025
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working with Rosa on this one, @barboraplasovska! The removal looks great, and we'll be happy to help you get it back in the docs when it's ready 🙂

@janine-c janine-c merged commit 9d36fed into master Nov 27, 2025
20 of 21 checks passed
@janine-c janine-c deleted the bplasovska/fix-graphql-ios-description branch November 27, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants