Add k8s for secrets#34259
Conversation
Preview links (active after the
|
| ``` | ||
| --set service.ports[0].protocol=TCP,service.ports[0].port=8088,service.ports[0].targetPort=8282 | ||
| ``` | ||
| 1. If you are using **Secrets Management**, |
There was a problem hiding this comment.
^typo here? I see "If you are using Secrets Management" twice
There was a problem hiding this comment.
Ah yeah, forgot to clean that up. Thanks!
| secretFileContents: | ||
| { | ||
| "us1_api": "<api_key>", | ||
| "secret_identifier1": "<secret1>" |
There was a problem hiding this comment.
A bit nuanced - I have to admit. But on the secrets management tab for the json file dropdown, the bootstrap.secretFileContents should still be in yaml format in the values.yaml file, similar to the yaml file dropdown on lines 349-351. Technically right now, the user can't actually pass in a local json or yaml file to configure their secretFileContents. They have to manually input their secrets in yaml format under the secretFileContents field. This is only specific for the K8s case (not the other installation platforms).
There was a problem hiding this comment.
Thanks @jackie8c! Nuanced, but really important! That makes sense. Do you think we should just remove the K8s tab for JSON? And then for the YAML file section for K8s, say something like:
You can't pass in a file to configure
secretFileContentsbut you can enter the your secrets and identifier mapping insecretFileContents?
Or should that info go elsewhere? It'd be a little confusing because the tab says YAML file, but I can't think of an alternative.
There was a problem hiding this comment.
I think we should keep the information where it is already in the respective secrets managers. I think we should retain the K8s tab for JSON and mention the same statement you would be using in the YAML file section for K8s: "You can't pass in a file to configure secretFileContents but you can enter the your secrets and identifier mappings in secretFileContents." Just to keep it consistent, in case they do actually use a local JSON file with their secrets.
* [DOCS-12091] Add identifiers for sources (#33370) * add identifiers for sources * apply suggestions * remove DD_OP_ * Add set secrets shortcode (#33432) * add shortcode * small edit * Update layouts/shortcodes/observability_pipelines/set_secrets_intro.en.md Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> --------- Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> * Update env vars for secrets mgmt (#33499) * dest env vars * update source env vars * [DOCS-12091] Add Secrets Management tabs for sources (#33429) * add sm tabs * use set secrets intro shortcode * update key pass * fix commas * add descriptions * update * fix case * small edits * [DOCS-12091] Add identifiers for destinations (#33411) * update destinations * revert change * update set secrets aopensearch * add set secrets to all destinations * update descriptions * Update content/en/observability_pipelines/destinations/amazon_security_lake.md * Apply suggestions from code review Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> * fix gpubsub link * small edits --------- Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> * [DOCS-12091] Update existing pipelines (#33815) * updates * add restart * small edits * updates for secrets (#33817) * [DOCS-12091] Update adv worker config for secrets management (#33825) * add secrets * small edit * small edits * [DOCS-12091] OP Route to multiple DD orgs (#33541) * add info * remove destination type restriction * add metrics info * small edits * add search syntax link * add images * fix header * add warning * edits * add limit * [DOCS-12091] Add Secrets Mgmt doc and update Install the Worker (#33745) * update platforms * add linux * add secrets doc * update linux * fix typo * add secret manager instructions * Apply suggestions from code review Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Apply suggestion from @rtrieu Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Apply suggestion from @maycmlee --------- Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Add k8s for secrets (#34259) * add k8s * add bootstrap file links * updates * fix typo * update region name placeholder * small updates * update file methods * small edits * update image --------- Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
3 participants
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes