-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Clarifying tag key parameters #35343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clreaume
wants to merge
7
commits into
master
Choose a base branch
from
cara/tag-key-parameters-clarification
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−17
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c1c5f30
Clarifying tag key parameters
clreaume 4f9994b
After chatting with Claude, removed commas from allowlist, added emoj…
clreaume 4e9a3d1
- after consultation with claude, clarified:
clreaume a530189
Merge branch 'master' into cara/tag-key-parameters-clarification
clreaume 2c35545
Adding recommendation to use <key>:<value> format
clreaume d06667b
Clarifying that span tags are indeed normalized to lowercase, while s…
clreaume 73e155b
Clarifying that requirements apply to full tag strings, inclusive, wh…
clreaume File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this to say we do not allow back slashes?
\?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to add clarity there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi Ray, that's what Claude told me! can you please verify? (I'd also love if you could verify that commas aren't allowed.) if so, I can add it to the parenthetical in the line below ("All other characters..."). good call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commas in tag keys are not allowed and are sanitized to underscores (_) — no error is returned.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! you called out tag keys—are commas allowed in tag values? my understanding was that these constraints applied to the entire tag string (i.e., all of
<key>:<value>or<value>)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The allowed characters in tag values are: alphanumeric (a-z, 0-9), _, -, ., /, :, @. Commas are not in the valid set.