✨ [RUM-14241] Implement Assembly with Hooks system#11
Merged
Conversation
|
✅ Code Quality ✅ Code Vulnerabilities ✅ Library Vulnerabilities 🎉 All green!🛠️ No new code quality issues 🔗 Commit SHA: 5d2362f | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
b3e93ef to
4661527
Compare
Assembly will depend on the data format: rum, telemetry, logs, spans
Similar to browser-core but without the HookNames constraints to allow to add specific hooks for spans and logs later
4661527 to
634b50f
Compare
cdn34dd
reviewed
Feb 19, 2026
cdn34dd
left a comment
Collaborator
There was a problem hiding this comment.
The PR is well structured, seems good to merge, I would make one change though. I don't think hooks and commonContext belong inside domain. I think of domain as a place for product features, things like Rum, Logs, Traces, Session Replay, etc.
Hooks, Assembly, commonContext I think should place outside as these are part of the event pipeline but not a feature.
regroup assembly / hooks / common context
cdn34dd
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Allow domain components to declare which data they add to which event format:
Changes
EventFormatwithrumandtelmetry(logsandspanswill be added later)mainandtelemetryformat typesCommonContextTest instructions
no functional changes, CI should pass
Checklist