Skip to content

👷 fix renovate config and integration app yarn version#112

Merged
bcaudan merged 2 commits into
mainfrom
bcaudan/renovate-fix
May 4, 2026
Merged

👷 fix renovate config and integration app yarn version#112
bcaudan merged 2 commits into
mainfrom
bcaudan/renovate-fix

Conversation

@bcaudan

@bcaudan bcaudan commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Address two warnings reported on the recent Renovate setup:

  • #111 — Renovate failed to look up registry.ddbuild.io/images/docker and registry.ddbuild.io/slack-notifier.
  • #109 — Lockfile maintenance for e2e/integration/apps/forge-vite failed because the runner's global yarn 1 refused to install in a project declaring yarn 4.

Changes

  • Replace the matchRegistryUrls ignore rule with matchDatasources: ["docker"] + matchPackageNames: ["registry.ddbuild.io/**"]. The previous rule never matched because Renovate's docker datasource embeds the registry in the package name rather than a separate registryUrl, so lookups against the internal registry kept failing.
  • Add "packageManager": "yarn@4.12.0" to each integration app's package.json (forge-vite, forge-webpack, electron-vite, electron-builder-vite). Without it the apps inherited the root's packageManager via directory walk-up, but the Renovate runner fell back to global yarn 1. Making each app self-describing lets the runner (with corepack) resolve the correct yarn.

Test instructions

Config-only change; verification happens on the next scheduled Renovate run. After this lands:

  • The Dependency Dashboard should no longer list the two registry.ddbuild.io/... lookup failures.
  • A subsequent lockfile-maintenance PR for any integration app should succeed instead of erroring on the yarn version mismatch.

Checklist

N/A, config-only

bcaudan added 2 commits May 4, 2026 10:44
The previous matchRegistryUrls rule didn't fire because Renovate's docker datasource extracts the registry as part of the package name, not as a separate registryUrl. Switch to matchDatasources + matchPackageNames glob so renovate stops trying to look up registry.ddbuild.io/images/docker and registry.ddbuild.io/slack-notifier.
Without an explicit packageManager field, each integration app inherited yarn@4.12.0 via directory walk-up to the root package.json. Renovate's runner then fell back to global yarn 1 and refused to install. Making each app self-describing lets Renovate (with corepack) resolve the correct yarn version.
@bcaudan bcaudan marked this pull request as ready for review May 4, 2026 08:49
@bcaudan bcaudan requested a review from a team as a code owner May 4, 2026 08:49
@bcaudan bcaudan merged commit 9d257fd into main May 4, 2026
15 checks passed
@bcaudan bcaudan deleted the bcaudan/renovate-fix branch May 4, 2026 08:54
bcaudan added a commit that referenced this pull request May 4, 2026
These two subprojects also have their own yarn.lock and were missing the
packageManager field, so Renovate's runner fell back to global yarn 1 when
trying to update their lockfiles. Mirroring the fix from #112 for the
integration apps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant