♻️ replace time imports from browser-core with js-core/time#138
Merged
bcaudan merged 2 commits intoJun 18, 2026
Conversation
- Replace timeStampNow, elapsed, ONE_SECOND, ONE_MINUTE, ONE_HOUR, toServerDuration imports from @datadog/browser-core with @datadog/js-core/time - Bump @datadog/js-core from 0.0.1 to 0.0.3
- Move `TimeStamp` type imports from `@datadog/browser-core` to `@datadog/js-core/time` across all source and spec files
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87a4bceff4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cdn34dd
approved these changes
Jun 17, 2026
bcaudan
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reduce dependency on
@datadog/browser-coreby migrating time-related imports (timeStampNow,dateNow,elapsed,ONE_SECOND,ONE_MINUTE,ONE_HOUR,toServerDuration) to@datadog/js-core/time, the canonical package for these utilities.Changes
src/files from@datadog/browser-coreto@datadog/js-core/time:Assembly.ts,config.ts,OperationCollection.ts,ViewCollection.ts,ViewContext.ts,SessionContext.ts,SessionManager.ts,session.constants.ts,BatchProducer.tsBatchProducer.spec.tsto mock@datadog/js-core/timeinstead of@datadog/browser-coreTest instructions
yarn testChecklist