✨ [RUM-14259] Add RUM error collection#23
Merged
Conversation
bcaudan
force-pushed
the
bcaudan/main-view-part2
branch
from
5d2abd6 to
0dd3e7c
Compare
bcaudan
force-pushed
the
bcaudan/error-collection
branch
from
8c999ff to
2b01cab
Compare
cdn34dd
reviewed
Mar 6, 2026
| error: { | ||
| id: string; | ||
| message: string; | ||
| source: 'source'; |
Collaborator
There was a problem hiding this comment.
Isn't this a bit too restrictive ?, The original type has a lot more, but maybe for now if we want to limit it, support some of the more immediate types we'll need ?
source: 'source' | 'console' | 'custom';
Collaborator
Author
There was a problem hiding this comment.
Let's add custom for the addError api and introduce other when we add support for them.
bcaudan
force-pushed
the
bcaudan/error-collection
branch
from
ac61bb2 to
2b01cab
Compare
- expose addError via getApi() pattern on ErrorCollection and RumCollection - widen RawRumError source/handling types to support manual errors - wrap stopSession and _generateActivity with callMonitored - add unit tests for getApi().addError
cdn34dd
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Collect errors from node main process
Changes
Test instructions
Generate errors from the playground:
Checklist