✨[RUM-14240] Add session manager#3
Merged
Merged
Conversation
Let's avoid to maintain high level integration test
bcaudan
force-pushed
the
bcaudan/session-management
branch
from
482d416 to
6c226b1
Compare
cdn34dd
reviewed
Feb 4, 2026
cdn34dd
left a comment
cdn34dd
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good, just left a couple of tweaks.
cdn34dd
approved these changes
Feb 4, 2026
As init is async, avoid partially init object by exposing static start + private constructor
cdn34dd
reviewed
Feb 4, 2026
cdn34dd
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Keep track of the end user session
Changes
@datadog/browser-coreas a dependency, in order to reuse some utilitiesindex.spec.ts, in order to not maintain high level integration testsTest instructions
Checklist