Skip to content

👷 [RUM-14260] add rust license tracking#57

Merged
bcaudan merged 2 commits into
mainfrom
bcaudan/minidump-license
Mar 25, 2026
Merged

👷 [RUM-14260] add rust license tracking#57
bcaudan merged 2 commits into
mainfrom
bcaudan/minidump-license

Conversation

@bcaudan

@bcaudan bcaudan commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Motivation

List minidump-processor dependencies in LICENSE-3rdparty.csv

Changes

  • Update LICENSE-3rdparty.csv structure:
Component Scope
npm-prod NPM production deps (dependencies in any package.json)
npm-dev NPM dev deps (devDependencies in any package.json)
rust-prod Rust crates compiled into the distributed WASM binary (non-dev deps)
rust-dev Rust crates used only during minidump-processor development (dev-deps)
  • Adapt scripts/check-licenses.ts

Test instructions

run node scripts/check-licenses.ts with different cases:

  • add dependency
  • remove dependency
  • add unknown component

Checklist

  • Tested locally (playground)
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated related documentation.

- restructure LICENSE-3rdparty.csv with npm-prod/npm-dev/rust-prod/rust-dev categories
- update DEVELOPMENT.md
@bcaudan bcaudan marked this pull request as ready for review March 25, 2026 13:28
@bcaudan bcaudan requested a review from a team as a code owner March 25, 2026 13:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6026255cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/check-licenses.ts Outdated
@bcaudan bcaudan merged commit 02f6da7 into main Mar 25, 2026
12 checks passed
@bcaudan bcaudan deleted the bcaudan/minidump-license branch March 25, 2026 16:03
@bcaudan bcaudan mentioned this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants