🔥 remove _generateActivity and clean up e2e infrastructure#90
Merged
Conversation
bcaudan
force-pushed
the
bcaudan/cleanup-generate-activity
branch
from
23a5c31 to
40a2a99
Compare
bcaudan
force-pushed
the
bcaudan/cleanup-generate-activity
branch
from
40a2a99 to
66a28fe
Compare
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
- preload exposes DD_E2E_RUM_BROWSER_SDK env var as window.e2eConfig.rumBrowserSdk
- main-window.ts conditionally inits browser-sdk with trackUserInteractions: true
- rumBrowserSdk Playwright fixture (null by default) passes config via env var
- waitForEventCount / getEventsByType accept optional predicate for scoped assertions
- tests using renewSession() wrap with test.use({ rumBrowserSdk: {} })
bcaudan
force-pushed
the
bcaudan/cleanup-generate-activity
branch
from
66a28fe to
229dac9
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 229dac9f13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cdn34dd
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_generateActivity()was a test escape hatch that directly emittedEND_USER_ACTIVITY, bypassing the real user-activity pipeline. Removing it forces tests to use a real DOM click tracked by browser-sdk, flowing through the fullDatadogEventBridge → BridgeHandler → UserActivityTracker → END_USER_ACTIVITYchain for genuine end-to-end coverage.The removal also prompted a naming cleanup: e2e files previously conflated "renderer process" (Electron concept) with "bridge window" (test concept).
Changes
_generateActivityfrom the SDK public API and all consumer code (playground, e2e app)main-window/bridge-windowfor clearer semanticsBridgeWindowPagepage object with static factory methods to open and await bridge windowsrumBrowserSdkPlaywright fixture option to opt in to browser-sdk per test describe blockTest instructions
Checklist